-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for manufacturerCode in access.zapt. #24427
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-mfg-code-access
Jan 18, 2023
Merged
Account for manufacturerCode in access.zapt. #24427
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-mfg-code-access
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
January 14, 2023 04:42
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
robszewczyk
January 14, 2023 04:42
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 14, 2023 04:42
PR #24427: Size comparison from cae6319 to d58eca8 Increases (7 builds for bl602, cc13x2_26x2, efr32, psoc6, telink)
Decreases (13 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 14, 2023
bzbarsky-apple
force-pushed
the
fix-mfg-code-access
branch
from
January 18, 2023 03:16
d58eca8
to
edf40a4
Compare
PR #24427: Size comparison from 89c6fb6 to edf40a4 Increases (6 builds for cc13x2_26x2, psoc6, telink)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, cyw30739, qpg, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Unlike all other places that use .code, access.zapt was not accounting for manufacturerCode. Ideally this would just use the named ids instead of reinventing the id wheel, but for now this at least makes the behavior match.
bzbarsky-apple
force-pushed
the
fix-mfg-code-access
branch
from
January 18, 2023 12:02
edf40a4
to
e09dd09
Compare
PR #24427: Size comparison from c5cb0dd to e09dd09 Increases (7 builds for cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, psoc6)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Jan 18, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Unlike all other places that use .code, access.zapt was not accounting for manufacturerCode. Ideally this would just use the named ids instead of reinventing the id wheel, but for now this at least makes the behavior match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike all other places that use .code, access.zapt was not accounting for manufacturerCode.
Ideally this would just use the named ids instead of reinventing the id wheel, but for now this at least makes the behavior match.