Chip tool fixes #24420
Merged
Chip tool fixes #24420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t SessionHandle &" to match how SessionHandle is often used as a parameter & to support rvalue * Add Java/JNI hooks into for-test classes (like MessagingContext) to allow for unit tests of Java & JNI functionality * Add first JNI unit test, GetConnectedDeviceCallbackJniTest, testing success/failure cases for device callback
JNIEnv::NewObject(_jclass*, _jmethodID*, ...) chip::Controller::GetConnectedDeviceCallback::OnDeviceConnectionFailureFn(void*, chip::ScopedNodeId const&, chip::ChipError) chip::OperationalSessionSetup::DequeueConnectionCallbacks(chip::ChipError) chip::OperationalSessionSetup::OnNodeAddressResolutionFailed(chip::PeerId const&, chip::ChipError) chip::AddressResolve::Impl::Resolver::HandleAction(chip::IntrusiveList<chip::AddressResolve::Impl::NodeLookupHandle, (chip::IntrusiveMode)0, chip::IntrusiveListBaseHook<chip::AddressResolve::Impl::NodeLookupHandle, (chip::IntrusiveMode)0> >::Iterator&) chip::AddressResolve::Impl::Resolver::HandleTimer() chip::System::LayerImplSelect::HandleEvents() Though JNI tests were added to try to catch this at presubmit, those tests did not fail, which leads me to believe there's a difference in the JRE (wherein the version with the user-reported bug), a cast to an int is not being done, whereas in android emulator, the cast to int is done
…se tests must be run externally due to android emulator dependency
|
PR #24420: Size comparison from cae6319 to 333b8bb Increases (9 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (8 builds for bl602, cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 14, 2023
|
PR #24420: Size comparison from 808b9fe to fadb72e Increases (13 builds for bl602, bl702, cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #24420: Size comparison from 7ceb958 to fd794da Increases (2 builds for cc13x2_26x2, esp32)
Decreases (14 builds for bl702, cc13x2_26x2, esp32, k32w, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 19, 2023
|
PR #24420: Size comparison from 583e976 to b117988 Increases (3 builds for esp32, telink)
Decreases (9 builds for bl602, bl702, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
WARNING e: /__w/connectedhomeip/connectedhomeip/examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/setuppayloadscanner/CHIPDeviceInfo.kt: (24, 16): Unresolved reference: parcelize
WARNING e: /__w/connectedhomeip/connectedhomeip/examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/setuppayloadscanner/CHIPDeviceInfo.kt: (27, 2): Unresolved reference: Parcelize
INFO
INFO > Task :app:compileDebugKotlin FAILED
INFO w: Runtime JAR files in the classpath should have the same version. These files were found in the classpath:
please fix the above parcelize issue, thanks
pullapprove
bot
requested review from
cliffamzn,
joonhaengHeo,
sharadb-amazon and
younghak-hwang
and removed request for
pjzander-signify
|
PR #24420: Size comparison from 94f8c34 to 9792a8b Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to the Java CHIPTool which I found while trying to compile