Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdns] Added two nullptr checks to prevent falling into hard fault #24233

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[mdns] Added two nullptr checks to prevent falling into hard fault #24233

merged 1 commit into from
Jan 4, 2023

Conversation

kkasperczyk-no
Copy link
Contributor

In mDNS code there isn't a check that would verify if memory was allocated successfully using new. In case it didn't the application will fall into hard fault due to usage of non-allocated memory.

Added two checks verifying that memory was allocated successfully before using.

@kkasperczyk-no
[mdns] Added two nullptr checks to prevent falling into hard fault
574e46d 
In mDNS code there isn't a check that would verify if memory
was allocated successfully using new. In case it didn't the
application will fall into hard fault due to usage of
non-allocated memory.

Added two checks verifying that memory was allocated
successfully before using.
@kkasperczyk-no kkasperczyk-no added the bug Something isn't working label Jan 3, 2023
@github-actions github-actions bot added the lib label Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 3, 2023 •
edited
Loading

PR #24233: Size comparison from 9a1c31c to 574e46d

Increases (29 builds for bl602, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 9a1c31c 574e46d change % change
bl602 lighting-app bl602 (read/write) 1356434 1356450 16 0.0
.text 1039192 1039208 16 0.0
bl602+rpc (read/write) 1402218 1402234 16 0.0
.text 1070614 1070630 16 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1038920 1039056 136 0.0
.text 850240 850376 136 0.0
lock-app BRD4161A+wf200 (read/write) 1069152 1069168 16 0.0
.text 908924 908940 16 0.0
esp32 all-clusters-app c3devkit (read only) 1219472 1219518 46 0.0
(read/write) 1790954 1791050 96 0.0
.flash.rodata 248392 248488 96 0.0
.flash.text 1219472 1219518 46 0.0
m5stack (read only) 1233407 1233447 40 0.0
(read/write) 564187 564263 76 0.0
.flash.rodata 314180 314256 76 0.0
.flash.text 1228023 1228063 40 0.0
linux all-clusters-app debug (read only) 3114537 3114873 336 0.0
.rodata 281611 281707 96 0.0
.text 2648242 2648482 240 0.0
all-clusters-minimal-app debug (read only) 2938137 2938473 336 0.0
.rodata 281035 281131 96 0.0
.text 2475458 2475698 240 0.0
bridge-app debug (read only) 2497209 2497545 336 0.0
.rodata 212320 212416 96 0.0
.text 2113106 2113346 240 0.0
chip-tool debug (read only) 11182713 11183065 352 0.0
.rodata 605029 605125 96 0.0
.text 9078820 9079076 256 0.0
chip-tool-ipv6only arm64 (read only) 10595932 10596380 448 0.0
.rodata 535180 535260 80 0.0
.text 8412948 8413316 368 0.0
lighting-app debug+rpc (read only) 2664337 2664673 336 0.0
.rodata 228224 228320 96 0.0
.text 2259362 2259602 240 0.0
lock-app debug (read only) 2623465 2623801 336 0.0
.rodata 244488 244584 96 0.0
.text 2207074 2207314 240 0.0
ota-provider-app debug (read only) 2197337 2197689 352 0.0
.rodata 195784 195880 96 0.0
.text 1861650 1861906 256 0.0
ota-requestor-app debug (read only) 2358841 2359177 336 0.0
.rodata 202512 202608 96 0.0
.text 2007426 2007666 240 0.0
shell debug (read only) 2646993 2647329 336 0.0
.rodata 239858 239954 96 0.0
.text 2247426 2247666 240 0.0
thermostat-no-ble arm64 (read only) 2478044 2478508 464 0.0
.rodata 149560 149656 96 0.1
.text 2067888 2068256 368 0.0
tv-app debug (read only) 3286737 3287089 352 0.0
.rodata 268856 268952 96 0.0
.text 2823554 2823810 256 0.0
tv-casting-app debug (read only) 5645937 5646289 352 0.0
.rodata 359321 359417 96 0.0
.text 5009026 5009282 256 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2463832 2463984 152 0.0
.text 1426476 1426628 152 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp (read/write) 1349822 1349938 116 0.0
rodata 204212 204296 84 0.0
text 755954 755990 36 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1749660 1749796 136 0.0
.debug_abbrev 1238156 1238158 2 0.0
.debug_info 27060316 27061030 714 0.0
.debug_line 3720067 3720447 380 0.0
.debug_loc 3624770 3625001 231 0.0
.debug_ranges 346584 346592 8 0.0
.debug_str 3453864 3454261 397 0.0
.text 1549984 1550120 136 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1692188 1692324 136 0.0
.debug_abbrev 1230047 1230049 2 0.0
.debug_info 26797115 26797829 714 0.0
.debug_line 3738965 3739345 380 0.0
.debug_loc 3612376 3612607 231 0.0
.debug_ranges 345200 345208 8 0.0
.debug_str 3442876 3443273 397 0.0
.text 1493240 1493376 136 0.0
light cy8ckit_062s2_43012 (read/write) 1610404 1610540 136 0.0
.debug_abbrev 1064846 1064848 2 0.0
.debug_info 22259724 22260439 715 0.0
.debug_line 3303995 3304375 380 0.0
.debug_loc 3310296 3310527 231 0.0
.debug_ranges 309336 309344 8 0.0
.debug_str 3248462 3248859 397 0.0
.text 1419648 1419784 136 0.0
lock cy8ckit_062s2_43012 (read/write) 1644356 1644476 120 0.0
.debug_abbrev 1066756 1066758 2 0.0
.debug_info 22478113 22478828 715 0.0
.debug_line 3305102 3305482 380 0.0
.debug_loc 3331730 3331961 231 0.0
.debug_ranges 311192 311200 8 0.0
.debug_str 3264300 3264697 397 0.0
.text 1448608 1448728 120 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1071556 1071564 8 0.0
text 726280 726282 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 691436 691438 2 0.0
light-switch-app tlsr9518adk80d text 638046 638048 2 0.0
thermostat tlsr9518adk80d text 638746 638748 2 0.0
Decreases (1 build for bl702)
platform target config section 9a1c31c 574e46d change % change
bl702 lighting-app bl702 (read/write) 1196351 1196335 -16 -0.0
.debug_info 39187934 39187933 -1 -0.0
.text 956882 956880 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 9a1c31c 574e46d change % change
bl602 lighting-app bl602 (read/write) 1356434 1356450 16 0.0
.bss 86977 86977 0 0.0
.data 9984 9984 0 0.0
.text 1039192 1039208 16 0.0
bl602+rpc (read/write) 1402218 1402234 16 0.0
.bss 95017 95017 0 0.0
.data 10384 10384 0 0.0
.text 1070614 1070630 16 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1196351 1196335 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67102 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1529044 1529044 0 0.0
.debug_aranges 132568 132568 0 0.0
.debug_frame 486476 486476 0 0.0
.debug_info 39187934 39187933 -1 -0.0
.debug_line 5162847 5162847 0 0.0
.debug_loc 3381394 3381394 0 0.0
.debug_ranges 363816 363816 0 0.0
.debug_str 3483437 3483437 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569377 569377 0 0.0
.symtab 172160 172160 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956882 956880 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284827 1284827 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75118 75118 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1676376 1676376 0 0.0
.debug_aranges 140688 140688 0 0.0
.debug_frame 513896 513896 0 0.0
.debug_info 43480352 43480352 0 0.0
.debug_line 5552342 5552342 0 0.0
.debug_loc 3576086 3576086 0 0.0
.debug_ranges 387352 387352 0 0.0
.debug_str 3885835 3885835 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130144 130144 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629661 629661 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030860 1030860 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679883 679883 0 0.0
(read/write) 171564 171564 0 0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 589576 589576 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644139 644139 0 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 79139 0 0.0
.text 564680 564680 0 0.0
lock-ftd LP_CC2652R7 (read only) 677415 677415 0 0.0
(read/write) 171592 171592 0 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 599520 599520 0 0.0
lock-mtd LP_CC2652R7 (read only) 662203 662203 0 0.0
(read/write) 182068 182068 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 558216 558216 0 0.0
pump-app LP_CC2652R7 (read only) 690439 690439 0 0.0
(read/write) 159304 159304 0 0.0
.bss 78756 78756 0 0.0
.data 3296 3296 0 0.0
.rodata 91031 91031 0 0.0
.text 598924 598924 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674363 674363 0 0.0
(read/write) 175484 175484 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86587 0 0.0
.text 587296 587296 0 0.0
shell LP_CC2652R7 (read only) 671106 671106 0 0.0
(read/write) 182668 182668 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 584052 584052 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588482 588482 0 0.0
.app_xip_area 464828 464828 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592310 592310 0 0.0
.app_xip_area 463360 463360 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551854 551854 0 0.0
.app_xip_area 433696 433696 0 0.0
.bss 60656 60656 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976468 976468 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 822108 822108 0 0.0
BRD4161A+rs911x (read/write) 1038920 1039056 136 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 850240 850376 136 0.0
BRD4187C (read/write) 1149948 1149948 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 984268 984268 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069152 1069168 16 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 908924 908940 16 0.0
window-app BRD4187C (read/write) 1142592 1142592 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 975472 975472 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219472 1219518 46 0.0
(read/write) 1790954 1791050 96 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248392 248488 96 0.0
.flash.text 1219472 1219518 46 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233407 1233447 40 0.0
(read/write) 564187 564263 76 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314180 314256 76 0.0
.flash.text 1228023 1228063 40 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662716 662716 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 564468 564468 0 0.0
light k32w0+release (read/write) 673400 673400 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 593788 593788 0 0.0
lock k32w0+release (read/write) 634244 634244 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 553852 553852 0 0.0
linux all-clusters-app debug (read only) 3114537 3114873 336 0.0
(read/write) 158600 158600 0 0.0
.bss 62464 62464 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87240 87240 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281611 281707 96 0.0
.text 2648242 2648482 240 0.0
all-clusters-minimal-app debug (read only) 2938137 2938473 336 0.0
(read/write) 150000 150000 0 0.0
.bss 61664 61664 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281035 281131 96 0.0
.text 2475458 2475698 240 0.0
bridge-app debug (read only) 2497209 2497545 336 0.0
(read/write) 133120 133120 0 0.0
.bss 52544 52544 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 70696 70696 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212320 212416 96 0.0
.text 2113106 2113346 240 0.0
chip-tool debug (read only) 11182713 11183065 352 0.0
(read/write) 646808 646808 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 611568 611568 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 605029 605125 96 0.0
.text 9078820 9079076 256 0.0
chip-tool-ipv6only arm64 (read only) 10595932 10596380 448 0.0
(read/write) 695928 695928 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 640376 640376 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 535180 535260 80 0.0
.text 8412948 8413316 368 0.0
lighting-app debug+rpc (read only) 2664337 2664673 336 0.0
(read/write) 132488 132488 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 74024 74024 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228224 228320 96 0.0
.text 2259362 2259602 240 0.0
lock-app debug (read only) 2623465 2623801 336 0.0
(read/write) 127472 127472 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70936 70936 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244488 244584 96 0.0
.text 2207074 2207314 240 0.0
ota-provider-app debug (read only) 2197337 2197689 352 0.0
(read/write) 105904 105904 0 0.0
.bss 46592 46592 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 52120 52120 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 195784 195880 96 0.0
.text 1861650 1861906 256 0.0
ota-requestor-app debug (read only) 2358841 2359177 336 0.0
(read/write) 113952 113952 0 0.0
.bss 49088 49088 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57208 57208 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202512 202608 96 0.0
.text 2007426 2007666 240 0.0
shell debug (read only) 2646993 2647329 336 0.0
(read/write) 143064 143064 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78136 78136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239858 239954 96 0.0
.text 2247426 2247666 240 0.0
thermostat-no-ble arm64 (read only) 2478044 2478508 464 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149560 149656 96 0.1
.text 2067888 2068256 368 0.0
tv-app debug (read only) 3286737 3287089 352 0.0
(read/write) 262312 262312 0 0.0
.bss 170808 170808 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80544 80544 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268856 268952 96 0.0
.text 2823554 2823810 256 0.0
tv-casting-app debug (read only) 5645937 5646289 352 0.0
(read/write) 162672 162672 0 0.0
.bss 52184 52184 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101960 101960 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 359321 359417 96 0.0
.text 5009026 5009282 256 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463832 2463984 152 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1426476 1426628 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179071 1179071 0 0.0
bss 145205 145205 0 0.0
rodata 136900 136900 0 0.0
text 815854 815854 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1349822 1349938 116 0.0
bss 105144 105144 0 0.0
rodata 204212 204296 84 0.0
text 755954 755990 36 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1124719 1124719 0 0.0
bss 144440 144440 0 0.0
rodata 113220 113220 0 0.0
text 786010 786010 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1749660 1749796 136 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238156 1238158 2 0.0
.debug_aranges 110768 110768 0 0.0
.debug_frame 371956 371956 0 0.0
.debug_info 27060316 27061030 714 0.0
.debug_line 3720067 3720447 380 0.0
.debug_loc 3624770 3625001 231 0.0
.debug_ranges 346584 346592 8 0.0
.debug_str 3453864 3454261 397 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572205 572205 0 0.0
.symtab 422128 422128 0 0.0
.text 1549984 1550120 136 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1692188 1692324 136 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1230047 1230049 2 0.0
.debug_aranges 110240 110240 0 0.0
.debug_frame 375012 375012 0 0.0
.debug_info 26797115 26797829 714 0.0
.debug_line 3738965 3739345 380 0.0
.debug_loc 3612376 3612607 231 0.0
.debug_ranges 345200 345208 8 0.0
.debug_str 3442876 3443273 397 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536294 536294 0 0.0
.symtab 408560 408560 0 0.0
.text 1493240 1493376 136 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1610404 1610540 136 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064846 1064848 2 0.0
.debug_aranges 102440 102440 0 0.0
.debug_frame 345344 345344 0 0.0
.debug_info 22259724 22260439 715 0.0
.debug_line 3303995 3304375 380 0.0
.debug_loc 3310296 3310527 231 0.0
.debug_ranges 309336 309344 8 0.0
.debug_str 3248462 3248859 397 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472619 472619 0 0.0
.symtab 376928 376928 0 0.0
.text 1419648 1419784 136 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1644356 1644476 120 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066756 1066758 2 0.0
.debug_aranges 102824 102824 0 0.0
.debug_frame 347144 347144 0 0.0
.debug_info 22478113 22478828 715 0.0
.debug_line 3305102 3305482 380 0.0
.debug_loc 3331730 3331961 231 0.0
.debug_ranges 311192 311200 8 0.0
.debug_str 3264300 3264697 397 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475336 475336 0 0.0
.symtab 378928 378928 0 0.0
.text 1448608 1448728 120 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151236 1151236 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 598336 598336 0 0.0
lock-app qpg6105+debug (read/write) 1117556 1117556 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 564652 564652 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1071556 1071564 8 0.0
bss 98856 98856 0 0.0
text 726280 726282 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1010856 1010856 0 0.0
bss 98080 98080 0 0.0
text 691436 691438 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932296 932296 0 0.0
bss 90320 90320 0 0.0
text 638046 638048 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1010264 1010264 0 0.0
bss 98380 98380 0 0.0
text 703822 703822 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945900 945900 0 0.0
bss 91276 91276 0 0.0
text 649302 649302 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935460 935460 0 0.0
bss 91712 91712 0 0.0
text 638746 638748 2 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but will still crash the application, right? I guess at least the message will say why we crashed?

@kkasperczyk-no
Copy link
Contributor Author

This seems fine, but will still crash the application, right? I guess at least the message will say why we crashed?

Yes, it would be better to change the API to make the method return some error code and handle it in the application. But for now I just wanted to crash the application in the controlled way instead of jumping into not allocated address in memory.

@Damian-Nordic Damian-Nordic merged commit ff845ba into project-chip:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuDuda LuDuda LuDuda approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
bug Something isn't working lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkasperczyk-no @LuDuda @bzbarsky-apple @Damian-Nordic