Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command line support in linux tv-casting-app #24215

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

chrisdecenzo
Copy link
Contributor

Fixes #24214

tv-casting-app works similar to chip-tool in that cluster commands can be passed as command line arguments and these will be invoked by tv-casting-app

Recent changes to auto-load fabrics has broken this feature

@github-actions
Copy link

github-actions bot commented Dec 29, 2022

PR #24215: Size comparison from 19c8ea4 to 58b6fea

Increases (2 builds for cc13x2_26x2, nrfconnect)
platform target config section 19c8ea4 58b6fea change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 644131 644139 8 0.0
.text 564672 564680 8 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 759970 759974 4 0.0
Decreases (1 build for esp32)
platform target config section 19c8ea4 58b6fea change % change
esp32 all-clusters-app c3devkit (read only) 1219474 1219472 -2 -0.0
.flash.text 1219474 1219472 -2 -0.0
Full report (22 builds for cc13x2_26x2, efr32, esp32, linux, mbed, nrfconnect, qpg)
platform target config section 19c8ea4 58b6fea change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679883 679883 0 0.0
(read/write) 171564 171564 0 0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 589576 589576 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644131 644139 8 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 79139 0 0.0
.text 564672 564680 8 0.0
lock-ftd LP_CC2652R7 (read only) 677415 677415 0 0.0
(read/write) 171592 171592 0 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 599520 599520 0 0.0
lock-mtd LP_CC2652R7 (read only) 662203 662203 0 0.0
(read/write) 182068 182068 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 558216 558216 0 0.0
pump-app LP_CC2652R7 (read only) 690439 690439 0 0.0
(read/write) 159304 159304 0 0.0
.bss 78756 78756 0 0.0
.data 3296 3296 0 0.0
.rodata 91031 91031 0 0.0
.text 598924 598924 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674363 674363 0 0.0
(read/write) 175484 175484 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86587 0 0.0
.text 587296 587296 0 0.0
shell LP_CC2652R7 (read only) 671106 671106 0 0.0
(read/write) 182668 182668 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 584052 584052 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976468 976468 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 822108 822108 0 0.0
BRD4161A+rs911x (read/write) 1038920 1038920 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 850240 850240 0 0.0
BRD4187C (read/write) 1149948 1149948 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 984268 984268 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069152 1069152 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 908924 908924 0 0.0
window-app BRD4187C (read/write) 1142592 1142592 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 975472 975472 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219474 1219472 -2 -0.0
(read/write) 1790954 1790954 0 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248392 248392 0 0.0
.flash.text 1219474 1219472 -2 -0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233407 1233407 0 0.0
(read/write) 564183 564183 0 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314176 314176 0 0.0
.flash.text 1228023 1228023 0 0.0
.iram0.text 124803 124803 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10595932 10595932 0 0.0
(read/write) 695928 695928 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 640376 640376 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 535180 535180 0 0.0
.text 8412948 8412948 0 0.0
thermostat-no-ble arm64 (read only) 2478044 2478044 0 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149560 149560 0 0.0
.text 2067888 2067888 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463832 2463832 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1426476 1426476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191003 1191003 0 0.0
bss 145205 145205 0 0.0
rodata 144544 144544 0 0.0
text 820134 820134 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1361266 1361266 0 0.0
bss 105144 105144 0 0.0
rodata 211640 211640 0 0.0
text 759970 759974 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136647 1136647 0 0.0
bss 144440 144440 0 0.0
rodata 120860 120860 0 0.0
text 790290 790290 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151236 1151236 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 598336 598336 0 0.0
lock-app qpg6105+debug (read/write) 1117556 1117556 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 564652 564652 0 0.0

@github-actions
Copy link

PR #24215: Size comparison from a4a407b to 6f16b46

Increases (1 build for cc32xx)
platform target config section a4a407b 6f16b46 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20229260 20229261 1 0.0
Full report (1 build for cc32xx)
platform target config section a4a407b 6f16b46 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930266 930266 0 0.0
.debug_aranges 87376 87376 0 0.0
.debug_frame 300288 300288 0 0.0
.debug_info 20229260 20229261 1 0.0
.debug_line 2661728 2661728 0 0.0
.debug_loc 2806516 2806516 0 0.0
.debug_ranges 283400 283400 0 0.0
.debug_str 3028246 3028246 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

@chrisdecenzo chrisdecenzo merged commit 9697944 into master Mar 28, 2023
@chrisdecenzo chrisdecenzo deleted the tv-casting1 branch March 28, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tv-casting-app, command line arguments are broken
4 participants