-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix command line support in linux tv-casting-app #24215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic and
dhrishi
December 28, 2022 23:53
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
December 28, 2022 23:53
PR #24215: Size comparison from 19c8ea4 to 58b6fea Increases (2 builds for cc13x2_26x2, nrfconnect)
Decreases (1 build for esp32)
Full report (22 builds for cc13x2_26x2, efr32, esp32, linux, mbed, nrfconnect, qpg)
|
andy31415
reviewed
Jan 4, 2023
examples/tv-casting-app/tv-casting-common/src/CastingServer.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jan 4, 2023
examples/tv-casting-app/tv-casting-common/src/TargetVideoPlayerInfo.cpp
Outdated
Show resolved
Hide resolved
sharadb-amazon
approved these changes
Jan 4, 2023
pullapprove
bot
requested review from
joonhaengHeo,
nivi-apple and
younghak-hwang
and removed request for
pjzander-signify
March 14, 2023 17:35
PR #24215: Size comparison from a4a407b to 6f16b46 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24214
tv-casting-app works similar to chip-tool in that cluster commands can be passed as command line arguments and these will be invoked by tv-casting-app
Recent changes to auto-load fabrics has broken this feature