-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelize zap_convert_all.py. #24181
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
bzbarsky-apple:parallel-zap-convert
Dec 22, 2022
Merged
Parallelize zap_convert_all.py. #24181
Damian-Nordic
merged 1 commit into
project-chip:master
from
bzbarsky-apple:parallel-zap-convert
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24181: Size comparison from 74296b8 to fb7e7de Increases (6 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (5 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
It's 4-5x faster for me this way. Also sets ZAP_SKIP_REAL_VERSION so that once project-chip/zap#876 merges we stop messing with the ZAP repo just to run it.
bzbarsky-apple
force-pushed
the
parallel-zap-convert
branch
from
December 22, 2022 00:52
fb7e7de
to
8f203e1
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
December 22, 2022 00:52
pullapprove
bot
requested review from
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 22, 2022 00:52
PR #24181: Size comparison from 74296b8 to 8f203e1 Increases (3 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (15 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Dec 22, 2022
Damian-Nordic
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's 4-5x faster for me this way.
Also sets ZAP_SKIP_REAL_VERSION so that once
project-chip/zap#876 merges we stop messing with the ZAP repo just to run it.