Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device type version support in matter IDL #24003

Merged
merged 5 commits into from
Dec 9, 2022
Merged

Add device type version support in matter IDL #24003

merged 5 commits into from
Dec 9, 2022

Conversation

andy31415
Copy link
Contributor

Adds:

  • parsing suport for version
  • make version mandatory
  • update codegen to output version
  • update unit tests

@github-actions
Copy link

github-actions bot commented Dec 9, 2022 •
edited
Loading

PR #24003: Size comparison from d1c9050 to 90280f0

Increases (7 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
platform target config section d1c9050 90280f0 change % change
bl602 lighting-app bl602+rpc (read/write) 1400958 1400966 8 0.0
.text 1069328 1069330 2 0.0
bl702 lighting-app bl702 .debug_info 39221970 39221971 1 0.0
.text 956102 956104 2 0.0
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 159640 159648 8 0.0
esp32 all-clusters-app m5stack (read/write) 564175 564179 4 0.0
.flash.rodata 314088 314092 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27069376 27069377 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22487070 22487071 1 0.0
telink lighting-app tlsr9518adk80d (read/write) 1033924 1033932 8 0.0
text 719648 719650 2 0.0
Decreases (3 builds for cc13x2_26x2, cyw30739, esp32)
platform target config section d1c9050 90280f0 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 690191 690183 -8 -0.0
.text 598772 598764 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588438 588430 -8 -0.0
.app_xip_area 464696 464688 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1218900 1218896 -4 -0.0
.flash.text 1218900 1218896 -4 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section d1c9050 90280f0 change % change
bl602 lighting-app bl602 (read/write) 1355182 1355182 0 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1037910 1037910 0 0.0
bl602+rpc (read/write) 1400958 1400966 8 0.0
.bss 95097 95097 0 0.0
.data 10384 10384 0 0.0
.text 1069328 1069330 2 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195583 1195583 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67182 67182 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1529212 1529212 0 0.0
.debug_aranges 132680 132680 0 0.0
.debug_frame 486788 486788 0 0.0
.debug_info 39221970 39221971 1 0.0
.debug_line 5145782 5145782 0 0.0
.debug_loc 3378919 3378919 0 0.0
.debug_ranges 363704 363704 0 0.0
.debug_str 3479635 3479635 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116336 116336 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568751 568751 0 0.0
.symtab 172112 172112 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956102 956104 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284011 1284011 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75198 75198 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1677326 1677326 0 0.0
.debug_aranges 140824 140824 0 0.0
.debug_frame 514260 514260 0 0.0
.debug_info 43520246 43520246 0 0.0
.debug_line 5536797 5536797 0 0.0
.debug_loc 3573964 3573964 0 0.0
.debug_ranges 387272 387272 0 0.0
.debug_str 3882056 3882056 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130048 130048 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628973 628973 0 0.0
.symtab 190288 190288 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030036 1030036 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679635 679635 0 0.0
(read/write) 171892 171892 0 0.0
.bss 81220 81220 0 0.0
.data 3380 3380 0 0.0
.rodata 89987 89987 0 0.0
.text 589336 589336 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643891 643891 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79123 79123 0 0.0
.text 564448 564448 0 0.0
lock-ftd LP_CC2652R7 (read only) 677263 677263 0 0.0
(read/write) 171832 171832 0 0.0
.bss 78876 78876 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 599368 599368 0 0.0
lock-mtd LP_CC2652R7 (read only) 661963 661963 0 0.0
(read/write) 182388 182388 0 0.0
.bss 74132 74132 0 0.0
.data 3304 3304 0 0.0
.rodata 103499 103499 0 0.0
.text 557984 557984 0 0.0
pump-app LP_CC2652R7 (read only) 690191 690183 -8 -0.0
(read/write) 159640 159648 8 0.0
.bss 78844 78844 0 0.0
.data 3296 3296 0 0.0
.rodata 90935 90935 0 0.0
.text 598772 598764 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 674091 674091 0 0.0
(read/write) 175844 175844 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86483 86483 0 0.0
.text 587128 587128 0 0.0
shell LP_CC2652R7 (read only) 670830 670830 0 0.0
(read/write) 183024 183024 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86726 86726 0 0.0
.text 583788 583788 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588438 588430 -8 -0.0
.app_xip_area 464696 464688 -8 -0.0
.bss 66200 66200 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592138 592138 0 0.0
.app_xip_area 463100 463100 0 0.0
.bss 71488 71488 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551498 551498 0 0.0
.app_xip_area 433260 433260 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976164 976164 0 0.0
.bss 152252 152252 0 0.0
.data 2168 2168 0 0.0
.text 821724 821724 0 0.0
BRD4161A+rs911x (read/write) 1037800 1037800 0 0.0
.bss 186728 186728 0 0.0
.data 2012 2012 0 0.0
.text 849040 849040 0 0.0
BRD4187C (read/write) 1149228 1149228 0 0.0
.bss 138648 138648 0 0.0
.data 2516 2516 0 0.0
.text 983468 983468 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163488 1163488 0 0.0
.bss 158296 158296 0 0.0
.data 2020 2020 0 0.0
.text 1003152 1003152 0 0.0
window-app BRD4187C (read/write) 1141744 1141744 0 0.0
.bss 140064 140064 0 0.0
.data 2540 2540 0 0.0
.text 974544 974544 0 0.0
esp32 all-clusters-app c3devkit (read only) 1218900 1218896 -4 -0.0
(read/write) 1790954 1790954 0 0.0
.dram0.bss 76992 76992 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248312 248312 0 0.0
.flash.text 1218900 1218896 -4 -0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233127 1233127 0 0.0
(read/write) 564175 564179 4 0.0
.dram0.bss 82144 82144 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314088 314092 4 0.0
.flash.text 1227743 1227743 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662532 662532 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564204 564204 0 0.0
light k32w0+release (read/write) 673112 673112 0 0.0
.bss 74904 74904 0 0.0
.data 2060 2060 0 0.0
.text 593420 593420 0 0.0
lock k32w0+release (read/write) 634068 634068 0 0.0
.bss 75664 75664 0 0.0
.data 2080 2080 0 0.0
.text 553596 553596 0 0.0
linux all-clusters-app debug (read only) 3111513 3111513 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62432 62432 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281227 281227 0 0.0
.text 2645794 2645794 0 0.0
all-clusters-minimal-app debug (read only) 2935193 2935193 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280683 280683 0 0.0
.text 2473058 2473058 0 0.0
bridge-app debug (read only) 2427777 2427777 0 0.0
(read/write) 129576 129576 0 0.0
.bss 50976 50976 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210848 210848 0 0.0
.text 2049570 2049570 0 0.0
chip-tool debug (read only) 11248889 11248889 0 0.0
(read/write) 659960 659960 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624736 624736 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 604933 604933 0 0.0
.text 9116724 9116724 0 0.0
chip-tool-ipv6only arm64 (read only) 10625164 10625164 0 0.0
(read/write) 708097 708097 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652392 652392 0 0.0
.dynamic 560 560 0 0.0
.got 13960 13960 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 531628 531628 0 0.0
.text 8434116 8434116 0 0.0
lighting-app debug+rpc (read only) 2661361 2661361 0 0.0
(read/write) 132328 132328 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73896 73896 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227840 227840 0 0.0
.text 2256962 2256962 0 0.0
lock-app debug (read only) 2620425 2620425 0 0.0
(read/write) 127344 127344 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244104 244104 0 0.0
.text 2204610 2204610 0 0.0
ota-provider-app debug (read only) 2187081 2187081 0 0.0
(read/write) 105480 105480 0 0.0
.bss 46528 46528 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51768 51768 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 194952 194952 0 0.0
.text 1852610 1852610 0 0.0
ota-requestor-app debug (read only) 2355801 2355801 0 0.0
(read/write) 113824 113824 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57128 57128 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202064 202064 0 0.0
.text 2005026 2005026 0 0.0
shell debug (read only) 2643969 2643969 0 0.0
(read/write) 142936 142936 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239474 239474 0 0.0
.text 2244978 2244978 0 0.0
thermostat-no-ble arm64 (read only) 2422604 2422604 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145092 145092 0 0.0
.text 2033792 2033792 0 0.0
tv-app debug (read only) 3283313 3283313 0 0.0
(read/write) 262120 262120 0 0.0
.bss 170776 170776 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268376 268376 0 0.0
.text 2820946 2820946 0 0.0
tv-casting-app debug (read only) 5641657 5641657 0 0.0
(read/write) 162384 162384 0 0.0
.bss 52088 52088 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101760 101760 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 358841 358841 0 0.0
.text 5005874 5005874 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463424 2463424 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1426068 1426068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190779 1190779 0 0.0
bss 145285 145285 0 0.0
rodata 144448 144448 0 0.0
text 819880 819880 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1360858 1360858 0 0.0
bss 105224 105224 0 0.0
rodata 211552 211552 0 0.0
text 759590 759590 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136423 1136423 0 0.0
bss 144520 144520 0 0.0
rodata 120764 120764 0 0.0
text 790048 790048 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841976 841976 0 0.0
(read/write) 1748580 1748580 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188704 188704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238183 1238183 0 0.0
.debug_aranges 110904 110904 0 0.0
.debug_frame 372248 372248 0 0.0
.debug_info 27069376 27069377 1 0.0
.debug_line 3707334 3707334 0 0.0
.debug_loc 3621030 3621030 0 0.0
.debug_ranges 345760 345760 0 0.0
.debug_str 3449295 3449295 0 0.0
.heap 841976 841976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571607 571607 0 0.0
.symtab 422000 422000 0 0.0
.text 1548824 1548824 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1691108 1691108 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1230074 1230074 0 0.0
.debug_aranges 110376 110376 0 0.0
.debug_frame 375304 375304 0 0.0
.debug_info 26806193 26806193 0 0.0
.debug_line 3726271 3726271 0 0.0
.debug_loc 3608636 3608636 0 0.0
.debug_ranges 344376 344376 0 0.0
.debug_str 3438307 3438307 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535696 535696 0 0.0
.symtab 408432 408432 0 0.0
.text 1492080 1492080 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1609300 1609300 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064871 1064871 0 0.0
.debug_aranges 102576 102576 0 0.0
.debug_frame 345640 345640 0 0.0
.debug_info 22268868 22268868 0 0.0
.debug_line 3293598 3293598 0 0.0
.debug_loc 3306543 3306543 0 0.0
.debug_ranges 308512 308512 0 0.0
.debug_str 3243893 3243893 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472021 472021 0 0.0
.symtab 376800 376800 0 0.0
.text 1418464 1418464 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845904 845904 0 0.0
(read/write) 1642740 1642740 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184968 184968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066787 1066787 0 0.0
.debug_aranges 102960 102960 0 0.0
.debug_frame 347436 347436 0 0.0
.debug_info 22487070 22487071 1 0.0
.debug_line 3293345 3293345 0 0.0
.debug_loc 3327910 3327910 0 0.0
.debug_ranges 310368 310368 0 0.0
.debug_str 3259736 3259736 0 0.0
.heap 845904 845904 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473683 473683 0 0.0
.symtab 378400 378400 0 0.0
.text 1446912 1446912 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151252 1151252 0 0.0
.bss 100436 100436 0 0.0
.data 840 840 0 0.0
.text 598352 598352 0 0.0
lock-app qpg6105+debug (read/write) 1117284 1117284 0 0.0
.bss 95908 95908 0 0.0
.data 836 836 0 0.0
.text 564380 564380 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1091720 1091720 0 0.0
bss 99808 99808 0 0.0
text 739452 739452 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1031092 1031092 0 0.0
bss 99032 99032 0 0.0
text 704660 704660 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952508 952508 0 0.0
bss 91272 91272 0 0.0
text 651264 651264 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033924 1033932 8 0.0
bss 100420 100420 0 0.0
text 719648 719650 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 966092 966092 0 0.0
bss 92228 92228 0 0.0
text 662510 662510 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952832 952832 0 0.0
bss 92664 92664 0 0.0
text 649670 649670 0 0.0

@andy31415 andy31415 merged commit 0ddcf2c into project-chip:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app controller examples review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @yufengwangca @bzbarsky-apple