[python] fix platform specific wheel to be spec compliant #23703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #23703: Size comparison from 4c6b72d to 8411ede Increases (4 builds for cyw30739, telink)
Decreases (5 builds for nrfconnect, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #23703: Size comparison from 4c6b72d to 2f0890d Increases (4 builds for cyw30739, linux)
Decreases (5 builds for esp32, nrfconnect, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 21, 2022
|
Hm, for some reason this fix seems not to work with the setuptools/distutils version which is part of the |
|
I added setuptools version to the constraints file by using @AnthonyDiGirolamo maybe you have thoughts on this? |
The current build approach causes bdist_wheel to store the shared library
in the purelib folder. However, a platform specific wheel should have
shared libraries in the platform specific folder, not in the purelib folder.
This has been discovered using `auditwheel check`:
```
RuntimeError: Invalid binary wheel, found the following shared library/libraries in purelib folder:
_ChipDeviceCtrl.so
The wheel has to be platlib compliant in order to be repaired by auditwheel.
```
This makes the wheel pass `auditwheel check`.
|
PR #23703: Size comparison from 4c6b72d to 2a63cf8 Decreases (1 build for nrfconnect)
Full report (3 builds for mbed, nrfconnect)
|
agners
force-pushed
the
fix-platform-wheel-build
branch
from
2a63cf8
to
7863895
Compare
arkq
approved these changes
Nov 22, 2022
|
Actually, setuptools on master branch is new enough ( So this PR actually does what its advertising on master branch. It does apply on |
|
PR #23703: Size comparison from eb03243 to 7863895 Increases (4 builds for cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build approach causes bdist_wheel to store the shared library in the purelib folder. However, a platform specific wheel should have shared libraries in the platform specific folder, not in the purelib folder.
This has been discovered using
auditwheel check:This makes the wheel pass
auditwheel check.