-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min event filter to chip-repl ReadEvent #23657
Add min event filter to chip-repl ReadEvent #23657
Conversation
PR #23657: Size comparison from 8c09eae to 735fa17 Full report (7 builds for bl702, mbed, nrfconnect, qpg)
|
735fa17
to
3b1c41f
Compare
3b1c41f
to
1caf45b
Compare
PR #23657: Size comparison from a45cf79 to 1caf45b Increases (7 builds for esp32, k32w, psoc6, telink)
Decreases (6 builds for bl702, esp32, k32w, nrfconnect, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you also add the test around https://github.com/project-chip/connectedhomeip/blob/master/src/controller/python/test/test_scripts/cluster_objects.py#L360,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
PR #23657: Size comparison from 494f5f5 to 7f3860c Increases (9 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (3 builds for psoc6, telink)
Full report (33 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Test:
await devCtrl.ReadEvent(0x12344321, [(1, Clusters.TestCluster.Events.TestEvent)])
confirmed on server side that no event filter was received with ReadEvent request.await devCtrl.ReadEvent(0x12344321, [(1, Clusters.TestCluster.Events.TestEvent)], eventNumberFilter=6)
confirmed on server side that event filter of 6 was received in the ReadEvent request.