Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DefaultStorageKeyAllocator into Keys and Allocator #23422

Merged
merged 11 commits into from
Nov 3, 2022
Merged

Split DefaultStorageKeyAllocator into Keys and Allocator #23422

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fbe7dc7
Separate out key allocation from storage keys. Make storage keys gene…
andy31415 Nov 1, 2022
1dc48c9
Convert a lot of usage of default storage key allocator into using th…
andy31415 Nov 1, 2022
60e92bc
Fix some compilations
andy31415 Nov 1, 2022
1aeff43
More compile fixes. Minmdns compiles
andy31415 Nov 1, 2022
323fa59
Restyle
andy31415 Nov 1, 2022
f41e225
Fix binding table test to compile
andy31415 Nov 1, 2022
ce282f6
One more compile fix for tests
andy31415 Nov 1, 2022
c0df905
Merge branch 'master' into fix_storage_key_allocator_mutability
andy31415 Nov 3, 2022
4dad702
ran `rg '\WStorageKey\W' | grep -v third_party/ | cut -f1 -d: | uniq …
andy31415 Nov 3, 2022
908dee4
Restyle
andy31415 Nov 3, 2022
b6ea150
Also update StorageKey at the beginning of the line
andy31415 Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also update StorageKey at the beginning of the line
  • Loading branch information
@andy31415
andy31415 committed Nov 3, 2022
commit b6ea1506bdd01da93b43f36bb46fcf2b66bbd684
4 changes: 2 additions & 2 deletions src/protocols/secure_channel/SimpleSessionResumptionStorage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ constexpr TLV::Tag SimpleSessionResumptionStorage::kResumptionIdTag;
constexpr TLV::Tag SimpleSessionResumptionStorage::kSharedSecretTag;
constexpr TLV::Tag SimpleSessionResumptionStorage::kCATTag;

StorageKey SimpleSessionResumptionStorage::GetStorageKey(const ScopedNodeId & node)
StorageKeyName SimpleSessionResumptionStorage::GetStorageKey(const ScopedNodeId & node)
{
return DefaultStorageKeyAllocator::FabricSession(node.GetFabricIndex(), node.GetNodeId());
}

StorageKey SimpleSessionResumptionStorage::GetStorageKey(ConstResumptionIdView resumptionId)
StorageKeyName SimpleSessionResumptionStorage::GetStorageKey(ConstResumptionIdView resumptionId)
{
char resumptionIdBase64[BASE64_ENCODED_LEN(resumptionId.size()) + 1];
auto len = Base64Encode(resumptionId.data(), resumptionId.size(), resumptionIdBase64);
Expand Down