-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Enable ble configuration in chip-tool for tizen platform #23317
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
jlatusek:tizen-chip-tool-central
Oct 24, 2022
Merged
[Tizen] Enable ble configuration in chip-tool for tizen platform #23317
bzbarsky-apple
merged 1 commit into
project-chip:master
from
jlatusek:tizen-chip-tool-central
Oct 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkq
approved these changes
Oct 24, 2022
PR #23317: Size comparison from b9d32ec to 5708907 Increases (2 builds for k32w, telink)
Decreases (2 builds for telink)
Full report (11 builds for bl702, k32w, mbed, nrfconnect, telink)
|
bzbarsky-apple
approved these changes
Oct 24, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During the compilation of chip-tool for the Tizen platform, the configuration of ble was disabled. Bonding a new device didn't work because of missing setting if the Tizen device is type central or not.
Changes
Add CHIP_DEVICE_LAYER_TARGET_TIZEN to conditional compilation.
Testing
Run chip-lighting-app on one device:
and chip-tool on the Tizen device: