-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick [ESP32] Release BTDM memory rather than just releasing BLE memory. (#23165) #23217
Merged
andy31415
merged 1 commit into
project-chip:v1.0-branch
from
shubhamdp:cherry-pick/23165
Oct 17, 2022
Merged
Cherry-pick [ESP32] Release BTDM memory rather than just releasing BLE memory. (#23165) #23217
andy31415
merged 1 commit into
project-chip:v1.0-branch
from
shubhamdp:cherry-pick/23165
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject-chip#23165) Once we are done using BLE for commissioning we should release all the bluetooth memory. Releasing with mode ESP_BT_MODE_BLE do not release all the memory. Releasing memory with mode ESP_BT_MODE_BLE will give us approx. ~3K of heap onf ESP32 SOC.
dhrishi
approved these changes
Oct 17, 2022
PR #23217: Size comparison from e6e8333 to 89112cc Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, esp32)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick e7e1ca9 (PR: #23165) from master to v1.0-branch.
This will add up ~3K heap after successful commissioning.