Fix EP0 in dynamic bridge app #23179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this conflicts with EP0 Descriptor clusters, we register an override that can't provide EP0 values and it vectors into that
|
Since this is really just about the descriptor cluster, we shouldn't really be over-riding the existing impl in the SDK, since that 'just works' as long as the right cluster metdata tables are provided at endpoint registration time. Talked with @achaulk-goog, he's going to fix up the PR to ensure the descriptor cluster is present in all dynamic endpoints at endpoint registration time in the 'metadata tables', but stop short of actually registering an attribute access interface override. |
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kghost
pullapprove
bot
requested review from
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #23179: Size comparison from ac19e88 to 772b2a3 Decreases (1 build for bl702)
Full report (5 builds for bl702, mbed, nrfconnect)
|
remove constant
|
PR #23179: Size comparison from ac19e88 to f653f3c Decreases (5 builds for bl702, telink)
Full report (13 builds for bl702, k32w, linux, mbed, nrfconnect, telink)
|
andy31415
approved these changes
Oct 14, 2022
|
PR #23179: Size comparison from ac19e88 to baf1b28 Increases (14 builds for bl602, bl702, efr32, esp32, linux, psoc6)
Decreases (11 builds for bl702, efr32, esp32, nrfconnect, psoc6, telink)
Full report (31 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
| @@ -17,12 +17,27 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| #include <app-common/zap-generated/af-structs.h> | |||
| #include <app-common/zap-generated/attribute-id.h> | |||
| #include <app-common/zap-generated/cluster-id.h> | |||
There was a problem hiding this comment.
This is just right. We should not be including code-generated files from common library code.
| DECLARE_DYNAMIC_ATTRIBUTE(ZCL_SERVER_LIST_ATTRIBUTE_ID, ARRAY, kDescriptorAttributeArraySize, 0), /* server list */ | ||
| DECLARE_DYNAMIC_ATTRIBUTE(ZCL_CLIENT_LIST_ATTRIBUTE_ID, ARRAY, kDescriptorAttributeArraySize, 0), /* client list */ | ||
| DECLARE_DYNAMIC_ATTRIBUTE(ZCL_PARTS_LIST_ATTRIBUTE_ID, ARRAY, kDescriptorAttributeArraySize, 0), /* parts list */ | ||
| DECLARE_DYNAMIC_ATTRIBUTE_LIST_END(); |
There was a problem hiding this comment.
There must be a better solution that hand-crafting these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this conflicts with EP0 Descriptor clusters, we register an override that can't provide EP0 values and it vectors into that causing commissioning failures