-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set of fixes to unit-tests code #23071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton and
jepenven-silabs
October 7, 2022 14:27
PR #23071: Size comparison from bf066a2 to 8a4dd2c Increases (8 builds for bl602, bl702, cc13x2_26x2, efr32, nrfconnect, telink)
Decreases (6 builds for cc13x2_26x2, esp32, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 7, 2022
bzbarsky-apple
requested changes
Oct 8, 2022
ATmobica
force-pushed
the
upstream-fixes
branch
from
October 11, 2022 15:12
8a4dd2c
to
92d03e9
Compare
PR #23071: Size comparison from 973bbf5 to 92d03e9 Increases (4 builds for bl602, bl702, efr32, psoc6)
Decreases (4 builds for esp32, nrfconnect, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ATmobica
force-pushed
the
upstream-fixes
branch
3 times, most recently
from
October 13, 2022 12:16
c8139dd
to
345dccf
Compare
PR #23071: Size comparison from 2c9cd92 to 345dccf Increases (11 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (3 builds for cc13x2_26x2, efr32, qpg)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 13, 2022
TestLogBufferAsHex test validates the LogBufferAsHex function which uses ChipLogProgress(). If progress logging is disable this test failed. Execute it only if CHIP_PROGRESS_LOGGING is defined. Signed-off-by: ATmobica <artur.tynecki@mobica.com>
Allow uppercase IPV6 string conversion. Check both cases. Signed-off-by: ATmobica <artur.tynecki@mobica.com>
Fix parse args for embedded non posix long_opt implementation. Disable a parse args unit test for non posix long_opt. Fix duplicate id in option sets in ParseArgs unit test. Signed-off-by: ATmobica <artur.tynecki@mobica.com>
src/app/util/mock/attribute-storage.cpp src/controller/tests/data_model/TestRead.cpp src/lib/support/jsontlv/TlvJson.cpp Signed-off-by: ATmobica <artur.tynecki@mobica.com>
Signed-off-by: ATmobica <artur.tynecki@mobica.com>
Remove leftover debug printf. Drain and service IO repeatedly until condition met. Signed-off-by: ATmobica <artur.tynecki@mobica.com>
Change TestReadChunkingTests to TestEventChunkingTests in TestEventChunkingTests.cpp Signed-off-by: ATmobica <artur.tynecki@mobica.com>
ATmobica
force-pushed
the
upstream-fixes
branch
from
October 14, 2022 09:53
345dccf
to
3c0fdab
Compare
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* [Fix] Execute TestLogBufferAsHex only if CHIP_PROGRESS_LOGGING TestLogBufferAsHex test validates the LogBufferAsHex function which uses ChipLogProgress(). If progress logging is disable this test failed. Execute it only if CHIP_PROGRESS_LOGGING is defined. Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix PeerAddress string conversion test Allow uppercase IPV6 string conversion. Check both cases. Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix ArgParser in support library Fix parse args for embedded non posix long_opt implementation. Disable a parse args unit test for non posix long_opt. Fix duplicate id in option sets in ParseArgs unit test. Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix warnings of incorrect types in printf formatting src/app/util/mock/attribute-storage.cpp src/controller/tests/data_model/TestRead.cpp src/lib/support/jsontlv/TlvJson.cpp Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Add missing assert header include in TestInetCommonPosix Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix TestReadInteraction implementation Remove leftover debug printf. Drain and service IO repeatedly until condition met. Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix controller unit tests Change TestReadChunkingTests to TestEventChunkingTests in TestEventChunkingTests.cpp Signed-off-by: ATmobica <artur.tynecki@mobica.com> Signed-off-by: ATmobica <artur.tynecki@mobica.com>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* [Fix] Execute TestLogBufferAsHex only if CHIP_PROGRESS_LOGGING TestLogBufferAsHex test validates the LogBufferAsHex function which uses ChipLogProgress(). If progress logging is disable this test failed. Execute it only if CHIP_PROGRESS_LOGGING is defined. Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix PeerAddress string conversion test Allow uppercase IPV6 string conversion. Check both cases. Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix ArgParser in support library Fix parse args for embedded non posix long_opt implementation. Disable a parse args unit test for non posix long_opt. Fix duplicate id in option sets in ParseArgs unit test. Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix warnings of incorrect types in printf formatting src/app/util/mock/attribute-storage.cpp src/controller/tests/data_model/TestRead.cpp src/lib/support/jsontlv/TlvJson.cpp Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Add missing assert header include in TestInetCommonPosix Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix TestReadInteraction implementation Remove leftover debug printf. Drain and service IO repeatedly until condition met. Signed-off-by: ATmobica <artur.tynecki@mobica.com> * [Fix] Fix controller unit tests Change TestReadChunkingTests to TestEventChunkingTests in TestEventChunkingTests.cpp Signed-off-by: ATmobica <artur.tynecki@mobica.com> Signed-off-by: ATmobica <artur.tynecki@mobica.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some fixes inside the unit-test code for different modules.
Fixes:
DrainAndServiceIO
toTestReadInteraction
#17528)