Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32] Adds fix for WF200 IPv4 Hard-Fault issue #23058

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[EFR32] Adds fix for WF200 IPv4 Hard-Fault issue #23058

merged 1 commit into from
Oct 13, 2022

Conversation

kurvaSai
Copy link
Contributor

@kurvaSai kurvaSai commented Oct 6, 2022 •
edited
Loading

Description:
Adds a Fix for WF200 IPv4 hard fault issue because there was a pointer reference issue with passing the netif interface between functions.

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022 •
edited
Loading

PR #23058: Size comparison from 2784c8c to 61d47e3

Increases (5 builds for bl602, cc13x2_26x2, telink)
platform target config section 2784c8c 61d47e3 change % change
bl602 lighting-app bl602+rpc (read/write) 1434422 1434430 8 0.0
.text 1100152 1100156 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676775 676783 8 0.0
.text 586856 586864 8 0.0
lock-mtd LP_CC2652R7 (read only) 659207 659215 8 0.0
.text 555776 555784 8 0.0
telink lighting-app tlsr9518adk80d text 571138 571140 2 0.0
ota-requestor-app tlsr9518adk80d text 577322 577324 2 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 2784c8c 61d47e3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174768 174760 -8 -0.0
lock-mtd LP_CC2652R7 (read/write) 185176 185168 -8 -0.0
Full report (19 builds for bl602, cc13x2_26x2, k32w, linux, qpg, telink)
platform target config section 2784c8c 61d47e3 change % change
bl602 lighting-app bl602 (read/write) 1389210 1389210 0 0.0
.bss 90729 90729 0 0.0
.data 9928 9928 0 0.0
.text 1068806 1068806 0 0.0
bl602+rpc (read/write) 1434422 1434430 8 0.0
.bss 98161 98161 0 0.0
.data 10312 10312 0 0.0
.text 1100152 1100156 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676775 676783 8 0.0
(read/write) 174768 174760 -8 -0.0
.bss 81236 81236 0 0.0
.data 3380 3380 0 0.0
.rodata 89607 89607 0 0.0
.text 586856 586864 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641031 641031 0 0.0
(read/write) 158004 158004 0 0.0
.bss 80508 80508 0 0.0
.data 3380 3380 0 0.0
.rodata 78743 78743 0 0.0
.text 561968 561968 0 0.0
lock-ftd LP_CC2652R7 (read only) 675467 675467 0 0.0
(read/write) 173228 173228 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77131 77131 0 0.0
.text 597856 597856 0 0.0
lock-mtd LP_CC2652R7 (read only) 659207 659215 8 0.0
(read/write) 185176 185168 -8 -0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 102951 102951 0 0.0
.text 555776 555784 8 0.0
pump-app LP_CC2652R7 (read only) 687519 687519 0 0.0
(read/write) 161896 161896 0 0.0
.bss 78428 78428 0 0.0
.data 3296 3296 0 0.0
.rodata 90543 90543 0 0.0
.text 596492 596492 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672019 672019 0 0.0
(read/write) 177508 177508 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86099 86099 0 0.0
.text 585440 585440 0 0.0
shell LP_CC2652R7 (read only) 667830 667830 0 0.0
(read/write) 186032 186032 0 0.0
.bss 83556 83556 0 0.0
.data 3376 3376 0 0.0
.rodata 86318 86318 0 0.0
.text 581196 581196 0 0.0
k32w contact k32w0+release (read/write) 665928 665928 0 0.0
.bss 77048 77048 0 0.0
.data 2108 2108 0 0.0
.text 567660 567660 0 0.0
light k32w0+release (read/write) 641588 641588 0 0.0
.bss 74824 74824 0 0.0
.data 2064 2064 0 0.0
.text 561972 561972 0 0.0
lock k32w0+release (read/write) 632916 632916 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552508 552508 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10428900 10428900 0 0.0
(read/write) 706321 706321 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650608 650608 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518004 518004 0 0.0
.text 8255348 8255348 0 0.0
thermostat-no-ble arm64 (read only) 2389420 2389420 0 0.0
(read/write) 143617 143617 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77232 77232 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144244 144244 0 0.0
.text 2002288 2002288 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148256 1148256 0 0.0
.bss 110556 110556 0 0.0
.data 832 832 0 0.0
.text 595356 595356 0 0.0
lock-app qpg6105+debug (read/write) 1113320 1113320 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560416 560416 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 788968 788968 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 552918 552918 0 0.0
lighting-app tlsr9518adk80d (read/write) 811072 811072 0 0.0
bss 73328 73328 0 0.0
noinit 43520 43520 0 0.0
text 571138 571140 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 819016 819016 0 0.0
bss 74236 74236 0 0.0
noinit 43520 43520 0 0.0
text 577322 577324 2 0.0

@kurvaSai kurvaSai changed the title wf200 ipv4 hardfault fix [EFR32] Adds fix for WF200 IPv4 Hard-Fault issue on MG12 & MG24 Oct 13, 2022
@kurvaSai kurvaSai changed the title [EFR32] Adds fix for WF200 IPv4 Hard-Fault issue on MG12 & MG24 [EFR32] Adds fix for WF200 IPv4 Hard-Fault issue Oct 13, 2022
jmartinez-silabs
jmartinez-silabs approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@jmartinez-silabs jmartinez-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always provide a description of the issue and fix im the PR even if it is a one liner change

@jmartinez-silabs jmartinez-silabs merged commit 83d5027 into project-chip:master Oct 13, 2022
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request #223: Cherry-Pick "wf200 ipv4 hardfault fix (project-chi…
651fec7 
…p#23058)" from silabs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/wf200_ipv4_hardfault_fix to silabs_1.0

Squashed commit of the following:

commit 80e20f0d06ce90c4ddbc0b10d71be72b5792d7e2
Author: kurvaSai <111514131+kurvaSai@users.noreply.github.com>
Date:   Thu Oct 13 19:41:41 2022 +0530

    wf200 ipv4 hardfault fix (project-chip#23058)
rerasool added a commit to SiliconLabs/matter that referenced this pull request Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request project-chip#223: Cherry-Pick "wf200 ipv4 hardfault fix (p…
fa432af 
…roject-chip#23058)" from silabs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/wf200_ipv4_hardfault_fix to silabs_1.0

Squashed commit of the following:

commit 80e20f0d06ce90c4ddbc0b10d71be72b5792d7e2
Author: kurvaSai <111514131+kurvaSai@users.noreply.github.com>
Date:   Thu Oct 13 19:41:41 2022 +0530

    wf200 ipv4 hardfault fix (project-chip#23058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kurvaSai @CLAassistant @bzbarsky-apple @jmartinez-silabs