Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop holding on to a PASE DeviceProxy pointer in MTRBaseDevice. #22848

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Stop holding on to a PASE DeviceProxy pointer in MTRBaseDevice. #22848

merged 1 commit into from
Sep 28, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Sep 23, 2022 •
edited
Loading

Issue Being Resolved

Change overview

Hold on to the device id, get session info by device id as needed.

@github-actions
Copy link

github-actions bot commented Sep 23, 2022 •
edited
Loading

PR #22848: Size comparison from a90c6b1 to 2608c95

Increases (9 builds for bl602, bl702, cc13x2_26x2, qpg, telink)
platform target config section a90c6b1 2608c95 change % change
bl602 lighting-app bl602 (read/write) 1383410 1383418 8 0.0
.text 1065040 1065042 2 0.0
bl702 lighting-app bl702 .debug_info 37898954 37898955 1 0.0
.text 956846 956848 2 0.0
bl702+rpc .debug_info 41805551 41805552 1 0.0
.text 1030548 1030550 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174964 174972 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640811 640819 8 0.0
.text 561744 561752 8 0.0
qpg lock-app qpg6105+debug (read/write) 1116236 1116244 8 0.0
.text 563336 563344 8 0.0
telink light-switch-app tlsr9518adk80d text 574592 574594 2 0.0
lighting-app tlsr9518adk80d text 592814 592816 2 0.0
ota-requestor-app tlsr9518adk80d text 598994 598996 2 0.0
Decreases (5 builds for cc13x2_26x2, esp32, nrfconnect, psoc6)
platform target config section a90c6b1 2608c95 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676571 676563 -8 -0.0
.text 586648 586640 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1222950 1222948 -2 -0.0
(read/write) 1788126 1788118 -8 -0.0
.flash.rodata 257696 257688 -8 -0.0
.flash.text 1222950 1222948 -2 -0.0
m5stack (read/write) 564020 564012 -8 -0.0
.flash.rodata 314752 314744 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815320 815316 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26558453 26558452 -1 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section a90c6b1 2608c95 change % change
bl602 lighting-app bl602 (read/write) 1383410 1383418 8 0.0
.bss 89537 89537 0 0.0
.data 9808 9808 0 0.0
.text 1065040 1065042 2 0.0
bl602+rpc (read/write) 1428630 1428630 0 0.0
.bss 96969 96969 0 0.0
.data 10192 10192 0 0.0
.text 1096390 1096390 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188203 1188203 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67078 67078 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506921 1506921 0 0.0
.debug_aranges 133080 133080 0 0.0
.debug_frame 486372 486372 0 0.0
.debug_info 37898954 37898955 1 0.0
.debug_line 5252836 5252836 0 0.0
.debug_loc 3364481 3364481 0 0.0
.debug_ranges 359104 359104 0 0.0
.debug_str 3456018 3456018 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116504 116504 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564828 564828 0 0.0
.symtab 171600 171600 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956846 956848 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284155 1284155 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75126 75126 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644466 1644466 0 0.0
.debug_aranges 140584 140584 0 0.0
.debug_frame 511748 511748 0 0.0
.debug_info 41805551 41805552 1 0.0
.debug_line 5627375 5627375 0 0.0
.debug_loc 3557196 3557196 0 0.0
.debug_ranges 381560 381560 0 0.0
.debug_str 3851918 3851918 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129912 129912 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624001 624001 0 0.0
.symtab 189408 189408 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030548 1030550 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676571 676563 -8 -0.0
(read/write) 174964 174972 8 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89611 89611 0 0.0
.text 586648 586640 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640811 640819 8 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78747 78747 0 0.0
.text 561744 561752 8 0.0
lock-ftd LP_CC2652R7 (read only) 678095 678095 0 0.0
(read/write) 170608 170608 0 0.0
.bss 78484 78484 0 0.0
.data 3304 3304 0 0.0
.rodata 77295 77295 0 0.0
.text 600320 600320 0 0.0
lock-mtd LP_CC2652R7 (read only) 661987 661987 0 0.0
(read/write) 182404 182404 0 0.0
.bss 74172 74172 0 0.0
.data 3304 3304 0 0.0
.rodata 103163 103163 0 0.0
.text 558344 558344 0 0.0
pump-app LP_CC2652R7 (read only) 687419 687419 0 0.0
(read/write) 161988 161988 0 0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90595 90595 0 0.0
.text 596340 596340 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671919 671919 0 0.0
(read/write) 177600 177600 0 0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86151 86151 0 0.0
.text 585288 585288 0 0.0
shell LP_CC2652R7 (read only) 667622 667622 0 0.0
(read/write) 186224 186224 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86326 86326 0 0.0
.text 580980 580980 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587290 587290 0 0.0
.app_xip_area 463948 463948 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594354 594354 0 0.0
.app_xip_area 465684 465684 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543362 543362 0 0.0
.app_xip_area 425044 425044 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110600 1110600 0 0.0
.bss 136532 136532 0 0.0
.data 2072 2072 0 0.0
.text 971976 971976 0 0.0
BRD4161A+rpc (read/write) 973740 973740 0 0.0
.bss 151044 151044 0 0.0
.data 2252 2252 0 0.0
.text 820424 820424 0 0.0
BRD4161A+rs911x (read/write) 1003872 1003872 0 0.0
.bss 169368 169368 0 0.0
.data 2064 2064 0 0.0
.text 832420 832420 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151396 1151396 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 997056 997056 0 0.0
window-app BRD4161A (read/write) 1102656 1102656 0 0.0
.bss 137980 137980 0 0.0
.data 2096 2096 0 0.0
.text 962560 962560 0 0.0
esp32 all-clusters-app c3devkit (read only) 1222950 1222948 -2 -0.0
(read/write) 1788126 1788118 -8 -0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257696 257688 -8 -0.0
.flash.text 1222950 1222948 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233043 1233043 0 0.0
(read/write) 564020 564012 -8 -0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314752 314744 -8 -0.0
.flash.text 1227659 1227659 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 649924 649924 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574416 574416 0 0.0
lock k32w0+release (read/write) 706912 706912 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630948 630948 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10422220 10422220 0 0.0
(read/write) 706257 706257 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 517372 517372 0 0.0
.text 8250868 8250868 0 0.0
thermostat-no-ble arm64 (read only) 2387524 2387524 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143708 143708 0 0.0
.text 2001520 2001520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455712 2455712 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418356 1418356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182939 1182939 0 0.0
bss 144433 144433 0 0.0
rodata 144268 144268 0 0.0
text 815320 815316 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161611 1161611 0 0.0
bss 143660 143660 0 0.0
rodata 135844 135844 0 0.0
text 803212 803212 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841968 841968 0 0.0
(read/write) 1744420 1744420 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229470 1229470 0 0.0
.debug_aranges 111816 111816 0 0.0
.debug_frame 373328 373328 0 0.0
.debug_info 26821671 26821671 0 0.0
.debug_line 3668877 3668877 0 0.0
.debug_loc 3582874 3582874 0 0.0
.debug_ranges 338928 338928 0 0.0
.debug_str 3439783 3439783 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569480 569480 0 0.0
.symtab 421040 421040 0 0.0
.text 1544656 1544656 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 842704 842704 0 0.0
(read/write) 1687028 1687028 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221269 1221269 0 0.0
.debug_aranges 111288 111288 0 0.0
.debug_frame 376408 376408 0 0.0
.debug_info 26558453 26558452 -1 -0.0
.debug_line 3689593 3689593 0 0.0
.debug_loc 3570511 3570511 0 0.0
.debug_ranges 337544 337544 0 0.0
.debug_str 3428796 3428796 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533569 533569 0 0.0
.symtab 407472 407472 0 0.0
.text 1488000 1488000 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850896 850896 0 0.0
(read/write) 1605556 1605556 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055325 1055325 0 0.0
.debug_aranges 103496 103496 0 0.0
.debug_frame 346736 346736 0 0.0
.debug_info 22022634 22022634 0 0.0
.debug_line 3259513 3259513 0 0.0
.debug_loc 3268575 3268575 0 0.0
.debug_ranges 302872 302872 0 0.0
.debug_str 3234328 3234328 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469946 469946 0 0.0
.symtab 375920 375920 0 0.0
.text 1414720 1414720 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845864 845864 0 0.0
(read/write) 1643436 1643436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062744 1062744 0 0.0
.debug_aranges 104168 104168 0 0.0
.debug_frame 349560 349560 0 0.0
.debug_info 22402001 22402001 0 0.0
.debug_line 3268227 3268227 0 0.0
.debug_loc 3308418 3308418 0 0.0
.debug_ranges 306216 306216 0 0.0
.debug_str 3261783 3261783 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476186 476186 0 0.0
.symtab 379152 379152 0 0.0
.text 1447568 1447568 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1146352 1146352 0 0.0
.bss 110544 110544 0 0.0
.data 1028 1028 0 0.0
.text 593448 593448 0 0.0
lock-app qpg6105+debug (read/write) 1116236 1116244 8 0.0
.bss 106376 106376 0 0.0
.data 1032 1032 0 0.0
.text 563336 563344 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 814580 814580 0 0.0
bss 72172 72172 0 0.0
noinit 43488 43488 0 0.0
text 574592 574594 2 0.0
lighting-app tlsr9518adk80d (read/write) 836692 836692 0 0.0
bss 73028 73028 0 0.0
noinit 43488 43488 0 0.0
text 592814 592816 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 844644 844644 0 0.0
bss 73936 73936 0 0.0
noinit 43488 43488 0 0.0
text 598994 598996 2 0.0

@andy31415 andy31415 merged commit f72807b into project-chip:master Sep 28, 2022
sharad-patil24 pushed a commit to sharad-patil24/connectedhomeip that referenced this pull request Sep 30, 2022
@bzbarsky-apple @sharad-patil24
Stop holding on to a PASE DeviceProxy pointer in MTRBaseDevice. (proj…
0124a18 
…ect-chip#22848)

Fixes project-chip#22846
@bzbarsky-apple bzbarsky-apple deleted the dont-store-pase-device branch October 3, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@andy31415 andy31415 Awaiting requested review from andy31415

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Platform] Stop holding on to a PASE DeviceProxy in MTRBasedevice
3 participants
@bzbarsky-apple @andy31415 @jtung-apple