-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZAP] Do not use assertSameTestType in examples/chip-tool/templates/t… #22770
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ZAP_SlowWith_assertSameTestType
Sep 20, 2022
Merged
[ZAP] Do not use assertSameTestType in examples/chip-tool/templates/t… #22770
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ZAP_SlowWith_assertSameTestType
Sep 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests/partials/checks/maybeCheckExpectedConstraints.zapt as it make the generation extremely slow
andy31415
approved these changes
Sep 20, 2022
tcarmelveilleux
approved these changes
Sep 20, 2022
bzbarsky-apple
approved these changes
Sep 20, 2022
PR #22770: Size comparison from 847f450 to de8165f Increases (1 build for telink)
Decreases (3 builds for bl602, telink)
Full report (18 builds for bl602, bl702, cc13x2_26x2, k32w, qpg, telink)
|
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Sep 26, 2022
…ests/partials/checks/maybeCheckExpectedConstraints.zapt as it make the generation extremely slow (project-chip#22770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ests/partials/checks/maybeCheckExpectedConstraints.zapt as it make the generation extremely slow
Issue Being Resolved
The culprit on the CI seems to the following run which takes something like
2316s
..../scripts/tools/zap/generate.py src/controller/data_model/controller-clusters.zap -t examples/chip-tool/templates/tests/templates.json -o zzz_generated/chip-tool/zap-generated
On my laptop the generation running the same script goes from
329s
to22s
withoutassertSameTestType
Change overview
assertSameTestType
which is just convenience but make the generation process super slow...