Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZAP] Do not use assertSameTestType in examples/chip-tool/templates/t… #22770

Merged

Conversation

vivien-apple
Copy link
Contributor

…ests/partials/checks/maybeCheckExpectedConstraints.zapt as it make the generation extremely slow

Issue Being Resolved

The culprit on the CI seems to the following run which takes something like 2316s...
./scripts/tools/zap/generate.py src/controller/data_model/controller-clusters.zap -t examples/chip-tool/templates/tests/templates.json -o zzz_generated/chip-tool/zap-generated

On my laptop the generation running the same script goes from 329s to 22s without assertSameTestType

Change overview

  • Remove assertSameTestType which is just convenience but make the generation process super slow...

…ests/partials/checks/maybeCheckExpectedConstraints.zapt as it make the generation extremely slow
@github-actions
Copy link

github-actions bot commented Sep 20, 2022

PR #22770: Size comparison from 847f450 to de8165f

Increases (1 build for telink)
platform target config section 847f450 de8165f change % change
telink ota-requestor-app tlsr9518adk80d (read/write) 844524 844532 8 0.0
text 598968 598970 2 0.0
Decreases (3 builds for bl602, telink)
platform target config section 847f450 de8165f change % change
bl602 lighting-app bl602 (read/write) 1383310 1383302 -8 -0.0
.text 1064954 1064952 -2 -0.0
bl602+rpc .text 1096302 1096298 -4 -0.0
telink lighting-app tlsr9518adk80d (read/write) 836424 836416 -8 -0.0
text 592726 592724 -2 -0.0
Full report (18 builds for bl602, bl702, cc13x2_26x2, k32w, qpg, telink)
platform target config section 847f450 de8165f change % change
bl602 lighting-app bl602 (read/write) 1383310 1383302 -8 -0.0
.bss 89537 89537 0 0.0
.data 9816 9816 0 0.0
.text 1064954 1064952 -2 -0.0
bl602+rpc (read/write) 1428506 1428506 0 0.0
.bss 96969 96969 0 0.0
.data 10200 10200 0 0.0
.text 1096302 1096298 -4 -0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188179 1188179 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67078 67078 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506715 1506715 0 0.0
.debug_aranges 133088 133088 0 0.0
.debug_frame 486412 486412 0 0.0
.debug_info 37896040 37896040 0 0.0
.debug_line 5252141 5252141 0 0.0
.debug_loc 3362527 3362527 0 0.0
.debug_ranges 359760 359760 0 0.0
.debug_str 3455801 3455801 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116488 116488 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 956820 956820 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284107 1284107 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75126 75126 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644294 1644294 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 511788 511788 0 0.0
.debug_info 41802659 41802659 0 0.0
.debug_line 5626680 5626680 0 0.0
.debug_loc 3555234 3555234 0 0.0
.debug_ranges 382216 382216 0 0.0
.debug_str 3851768 3851768 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030522 1030522 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676595 676595 0 0.0
(read/write) 174940 174940 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89603 89603 0 0.0
.text 586680 586680 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640843 640843 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78739 78739 0 0.0
.text 561784 561784 0 0.0
lock-ftd LP_CC2652R7 (read only) 678127 678127 0 0.0
(read/write) 170576 170576 0 0.0
.bss 78484 78484 0 0.0
.data 3304 3304 0 0.0
.rodata 77287 77287 0 0.0
.text 600360 600360 0 0.0
lock-mtd LP_CC2652R7 (read only) 661947 661947 0 0.0
(read/write) 182444 182444 0 0.0
.bss 74172 74172 0 0.0
.data 3304 3304 0 0.0
.rodata 103123 103123 0 0.0
.text 558344 558344 0 0.0
pump-app LP_CC2652R7 (read only) 687283 687283 0 0.0
(read/write) 162124 162124 0 0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90507 90507 0 0.0
.text 596292 596292 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671791 671791 0 0.0
(read/write) 177728 177728 0 0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86063 86063 0 0.0
.text 585248 585248 0 0.0
shell LP_CC2652R7 (read only) 667622 667622 0 0.0
(read/write) 186224 186224 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86318 86318 0 0.0
.text 580988 580988 0 0.0
k32w light k32w0+release (read/write) 649900 649900 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574392 574392 0 0.0
lock k32w0+release (read/write) 706856 706856 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630892 630892 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1146320 1146320 0 0.0
.bss 110544 110544 0 0.0
.data 1028 1028 0 0.0
.text 593416 593416 0 0.0
lock-app qpg6105+debug (read/write) 1116220 1116220 0 0.0
.bss 106376 106376 0 0.0
.data 1032 1032 0 0.0
.text 563320 563320 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 814468 814468 0 0.0
bss 72172 72172 0 0.0
noinit 43488 43488 0 0.0
text 574566 574566 0 0.0
lighting-app tlsr9518adk80d (read/write) 836424 836416 -8 -0.0
bss 73028 73028 0 0.0
noinit 43488 43488 0 0.0
text 592726 592724 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 844524 844532 8 0.0
bss 73936 73936 0 0.0
noinit 43488 43488 0 0.0
text 598968 598970 2 0.0

@vivien-apple vivien-apple merged commit 3aa138f into project-chip:master Sep 20, 2022
andy31415 pushed a commit to andy31415/connectedhomeip that referenced this pull request Sep 26, 2022
…ests/partials/checks/maybeCheckExpectedConstraints.zapt as it make the generation extremely slow (project-chip#22770)
andy31415 added a commit that referenced this pull request Sep 26, 2022
…ests/partials/checks/maybeCheckExpectedConstraints.zapt as it make the generation extremely slow (#22770) (#22873)

Co-authored-by: Vivien Nicolas <vnicolas@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants