[EFR32] Implement the CommisionableData Provider #22705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jtung-apple,
kghost,
lazarkov and
LuDuda
…ommissionable data to a efr32 device
…back to use TEST_SETUP_VALUES if credentials are not found in nvm3. Add a Readme for the provider script.
… deviceInstanceInfoProvider, augment FactoryDataProvider and add checks
jmartinez-silabs
force-pushed
the
cmsnr_DataProvider
branch
from
4b06e08 to
161fd7f
Compare
|
PR #22705: Size comparison from 7455a55 to 161fd7f Increases (13 builds for bl602, bl702, linux, mbed, nrfconnect, qpg, telink)
Decreases (2 builds for bl702)
Full report (14 builds for bl602, bl702, linux, mbed, nrfconnect, qpg, telink)
|
|
PR #22705: Size comparison from 7455a55 to 615a156 Increases (9 builds for bl702, linux, mbed, nrfconnect, telink)
Decreases (2 builds for bl702)
Full report (10 builds for bl702, linux, mbed, nrfconnect, telink)
|
|
PR #22705: Size comparison from 7455a55 to 007b240 Increases (29 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, cc13x2_26x2, esp32, psoc6)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #22705: Size comparison from 7455a55 to 84d48e9 Increases (34 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (15 builds for bl702, cc13x2_26x2, efr32, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Oct 6, 2022
|
PR #22705: Size comparison from 7455a55 to 22c0d8b Increases (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (15 builds for bl702, cc13x2_26x2, efr32, psoc6)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
added a commit
to jmartinez-silabs/connectedhomeip
that referenced
this pull request
Oct 7, 2022
* WIP * WIP Add the Commisionable Data provide to the ligthing-app * Fix reading potential garbage bytes. Create python script to inject commissionable data to a efr32 device * Add EFR32CommissinableDataProvider to all silabs examples. Add a fallback to use TEST_SETUP_VALUES if credentials are not found in nvm3. Add a Readme for the provider script. * Fix typo and add a subscript in the readme.md * Create a class and remove the use of global variables. Fix other comments * fix merge conflict, run restyle * Remove Passcode storing, Instead store qrcode bitset payload. Support deviceInstanceInfoProvider, augment FactoryDataProvider and add checks * Add commissioning flow and rendez-vous flag args to the factoryDataProvider script * fix build issue * Enable EFR32DeviceDataProvider for the wifi platform examples also * address last few comments
andy31415
pushed a commit
that referenced
this pull request
Oct 7, 2022
#23072) * [EFR32] Implement the CommisionableData Provider (#22705) * WIP * WIP Add the Commisionable Data provide to the ligthing-app * Fix reading potential garbage bytes. Create python script to inject commissionable data to a efr32 device * Add EFR32CommissinableDataProvider to all silabs examples. Add a fallback to use TEST_SETUP_VALUES if credentials are not found in nvm3. Add a Readme for the provider script. * Fix typo and add a subscript in the readme.md * Create a class and remove the use of global variables. Fix other comments * fix merge conflict, run restyle * Remove Passcode storing, Instead store qrcode bitset payload. Support deviceInstanceInfoProvider, augment FactoryDataProvider and add checks * Add commissioning flow and rendez-vous flag args to the factoryDataProvider script * fix build issue * Enable EFR32DeviceDataProvider for the wifi platform examples also * address last few comments * Fix build, efr32_board isn't renamed to silabs_board in v1.0 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
EFR32DeviceDataProviderCHIP_USE_TRANSITIONAL_COMMISSIONABLE_DATA_PROVIDERCHIP_DEVICE_CONFIG_USE_TEST_XXXXvalues if the commissionable data isn't in nvm3 (keep test setup alive)How it was tested
Commission the device without having any commissionable data to the device (Using test setup values)
Provide the device with a new set of commissionable data to the device with the new script FactoryDataProvider.py.
Validate the QR Code and Ble advertising present the new values
Commission the device with the new passcode that matches the new spake2p values.
Confirm the Build of a few examples but CI can validate the others.