[Darwin] Update templates to preserve acronyms (e.g ACL) in APIs #22665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
|
PR #22665: Size comparison from 1e66f4b to 2475ae8 Increases (4 builds for cc13x2_26x2, cyw30739, esp32, psoc6)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Sep 15, 2022
vivien-apple
force-pushed
the
Darwin_KeepAcronymsInAPIs
branch
from
8eb7b02
to
465e257
Compare
vivien-apple
force-pushed
the
Darwin_KeepAcronymsInAPIs
branch
from
465e257
to
5ee5b57
Compare
|
PR #22665: Size comparison from 003fc60 to 9620c97 Increases (6 builds for bl702, esp32, psoc6, qpg, telink)
Decreases (4 builds for esp32, nrfconnect, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…m restyle as we seems to have colliding versions
vivien-apple
force-pushed
the
Darwin_KeepAcronymsInAPIs
branch
from
9620c97
to
da2a9c4
Compare
andy31415
approved these changes
Sep 16, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ject-chip#22665) * Update ZAP repo * [darwin] Add cluster and commands description from XML into MTRBaseClusters.zapt * [Darwin] Update template to preserve acronyms (e.g ACL) in APIs * Update constants name in TemperatureSensorViewController.m * Ota -> OTA in src/darwin/Framework/CHIPTests/MTRTestOTAProvider.m * Exclude src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h from restyle as we seems to have colliding versions * Update generated code
bzbarsky-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 29, 2022
This is a re-landing of PR project-chip#22665 but with backwards compat preserved and some of the comment-only changes removed to ease review; those will re-land in a separate PR. * Update ZAP repo * [Darwin] Update template to preserve acronyms (e.g ACL) in APIs * Ota -> OTA in src/darwin/Framework/CHIPTests/MTRTestOTAProvider.m * Update generated code The header changes not accompanied by backwards-compat shims are OK for the following reasons: * The changes to the argument types in MTROTAProviderDelegate.h are in MTR_NEWLY_AVAILABLE APIs. * MTROTAProviderDelegateBridge.h is not public API. * In MTRBaseClusters.h readAttributeAclWithParams, writeAttributeAclWithValue, subscribeAttributeAclWithParams, readAttributeAclWithClusterStateCache get renamed only in MTR_NEWLY_AVAILABLE APIs. * In MTRBaseClusters.h MTRBaseClusterOtaSoftwareUpdateProvider gets renamed to MTRBaseClusterOTASoftwareUpdateProvider. This is OK because all the selectors on it are MTR_NEWLY_AVAILABLE and a shim is provided for the (Deprecated) extension. * In MTRBaseClusters.h MTROtaSoftwareUpdateProviderCluster* structs in arguments get renamed to MTROTASoftwareUpdateProviderCluster* only in MTR_NEWLY_AVAILABLE APIs. * In MTRBaseClusters.h MTRBaseClusterOtaSoftwareUpdateRequestor gets renamed to MTRBaseClusterOTASoftwareUpdateRequestor. This is OK because all the selectors on it are MTR_NEWLY_AVAILABLE and a shim is provided for the (Deprecated) extension. * In MTRBaseClusters.h MTROtaSoftwareUpdateRequestorCluster* structs in arguments get renamed to MTROTASoftwareUpdateRequestorCluster* only in MTR_NEWLY_AVAILABLE APIs. * In MTRBaseClusters.h *AttributePir* bits get renamed only in MTR_NEWLY_AVAILABLE APIs. * In MTRBaseClusters.h MTRBaseClusterWakeOnLan gets renamed to MTRBaseClusterWakeOnLAN and needs a shim. This is OK because all the selectors on it are MTR_NEWLY_AVAILABLE and a shim is provided for the (Deprecated) extension. * MTRBaseClusters_internal.h is not public API. * MTRCallbackBridge_internal.h is not public API. * In MTRClusterConstants.h all the name changes are to MTR_NEWLY_AVAILABLE constants. * In MTRClusters.h renaming MTRClusterOtaSoftwareUpdateProvider to MTRClusterOTASoftwareUpdateProvider is OK because a shim is provided. * In MTRClusters.h renaming MTRClusterOtaSoftwareUpdateRequestor to MTRClusterOTASoftwareUpdateRequestor is OK because a shim is provided. * In MTRClusters.h renaming MTRClusterWakeOnLan to MTRClusterWakeOnLAN is OK because a shim is provided. * In MTRClusters.h, all the attributes that had their names change get shims. * MTRClusters_internal.h is not public API.
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 30, 2022
…3800) This is a re-landing of PR #22665 but with backwards compat preserved and some of the comment-only changes removed to ease review; those will re-land in a separate PR. * Update ZAP repo * [Darwin] Update template to preserve acronyms (e.g ACL) in APIs * Ota -> OTA in src/darwin/Framework/CHIPTests/MTRTestOTAProvider.m * Update generated code The header changes not accompanied by backwards-compat shims are OK for the following reasons: * The changes to the argument types in MTROTAProviderDelegate.h are in MTR_NEWLY_AVAILABLE APIs. * MTROTAProviderDelegateBridge.h is not public API. * In MTRBaseClusters.h readAttributeAclWithParams, writeAttributeAclWithValue, subscribeAttributeAclWithParams, readAttributeAclWithClusterStateCache get renamed only in MTR_NEWLY_AVAILABLE APIs. * In MTRBaseClusters.h MTRBaseClusterOtaSoftwareUpdateProvider gets renamed to MTRBaseClusterOTASoftwareUpdateProvider. This is OK because all the selectors on it are MTR_NEWLY_AVAILABLE and a shim is provided for the (Deprecated) extension. * In MTRBaseClusters.h MTROtaSoftwareUpdateProviderCluster* structs in arguments get renamed to MTROTASoftwareUpdateProviderCluster* only in MTR_NEWLY_AVAILABLE APIs. * In MTRBaseClusters.h MTRBaseClusterOtaSoftwareUpdateRequestor gets renamed to MTRBaseClusterOTASoftwareUpdateRequestor. This is OK because all the selectors on it are MTR_NEWLY_AVAILABLE and a shim is provided for the (Deprecated) extension. * In MTRBaseClusters.h MTROtaSoftwareUpdateRequestorCluster* structs in arguments get renamed to MTROTASoftwareUpdateRequestorCluster* only in MTR_NEWLY_AVAILABLE APIs. * In MTRBaseClusters.h *AttributePir* bits get renamed only in MTR_NEWLY_AVAILABLE APIs. * In MTRBaseClusters.h MTRBaseClusterWakeOnLan gets renamed to MTRBaseClusterWakeOnLAN and needs a shim. This is OK because all the selectors on it are MTR_NEWLY_AVAILABLE and a shim is provided for the (Deprecated) extension. * MTRBaseClusters_internal.h is not public API. * MTRCallbackBridge_internal.h is not public API. * In MTRClusterConstants.h all the name changes are to MTR_NEWLY_AVAILABLE constants. * In MTRClusters.h renaming MTRClusterOtaSoftwareUpdateProvider to MTRClusterOTASoftwareUpdateProvider is OK because a shim is provided. * In MTRClusters.h renaming MTRClusterOtaSoftwareUpdateRequestor to MTRClusterOTASoftwareUpdateRequestor is OK because a shim is provided. * In MTRClusters.h renaming MTRClusterWakeOnLan to MTRClusterWakeOnLAN is OK because a shim is provided. * In MTRClusters.h, all the attributes that had their names change get shims. * MTRClusters_internal.h is not public API. Co-authored-by: Vivien Nicolas <vnicolas@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
This PR fixes part 2 and 3 from #22545 and it relies on a zap update (notably project-chip/zap#726)
Change overview
asUpperCamelCasein order to not convert acronyms such asACLtoAcl.