Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timer cancellation to be reliable in LayerImplSelect. #22375

Merged
merged 7 commits into from
Sep 5, 2022
Merged

Fix timer cancellation to be reliable in LayerImplSelect. #22375

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6ec196
Duplicate src/system/tests/TestSystemScheduleLambda.cpp history in sr…
bzbarsky-apple Sep 2, 2022
d4dc542
Fix timer cancellation to be reliable in LayerImplSelect.
bzbarsky-apple Sep 2, 2022
464d654
Add a unit test that timer cancelling works even for currently "in pr…
andy31415 Sep 2, 2022
f1b0cae
Address review comments.
bzbarsky-apple Sep 2, 2022
b117f66
Fix shadowing problem.
bzbarsky-apple Sep 2, 2022
214afe6
Turn off TestSystemScheduleWork on esp32 QEMU for now.
bzbarsky-apple Sep 3, 2022
1a864c7
Turn off TestSystemScheduleWork on the fake platform too.
bzbarsky-apple Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Turn off TestSystemScheduleWork on esp32 QEMU for now.
  • Loading branch information
@bzbarsky-apple
bzbarsky-apple committed Sep 3, 2022
commit 214afe65092fc20e25bf2b204fcb61d5bf8c2d6a
5 changes: 4 additions & 1 deletion src/system/tests/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,15 @@ chip_test_suite("tests") {
"TestSystemErrorStr.cpp",
"TestSystemPacketBuffer.cpp",
"TestSystemScheduleLambda.cpp",
"TestSystemScheduleWork.cpp",
"TestSystemTimer.cpp",
"TestSystemWakeEvent.cpp",
"TestTimeSource.cpp",
]

if (chip_device_platform != "esp32") {
test_sources += [ "TestSystemScheduleWork.cpp" ]
}

cflags = [ "-Wconversion" ]

public_deps = [
Expand Down