-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Fixed handling lock/unlock door lock commands #22359
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
kkasperczyk-no:door_lock_fix
Sep 2, 2022
Merged
[nrfconnect] Fixed handling lock/unlock door lock commands #22359
bzbarsky-apple
merged 1 commit into
project-chip:master
from
kkasperczyk-no:door_lock_fix
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago setting lock state attribute was removed from the door lock cluster code, so basically now it doesn't work in nrfconnect example, as application was relying on the cluster code. Added handling attribute state in the application.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
September 2, 2022 08:44
pullapprove
bot
requested review from
msandstedt,
mspang,
rgoliver,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
September 2, 2022 08:44
Damian-Nordic
approved these changes
Sep 2, 2022
PR #22359: Size comparison from e56afce to d8c73e5 Increases (11 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (2 builds for cc13x2_26x2, psoc6)
Full report (53 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Sep 2, 2022
LuDuda
approved these changes
Sep 2, 2022
bzbarsky-apple
approved these changes
Sep 2, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…hip#22359) Some time ago setting lock state attribute was removed from the door lock cluster code, so basically now it doesn't work in nrfconnect example, as application was relying on the cluster code. Added handling attribute state in the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some time ago setting lock state attribute was removed from the door lock cluster code, so basically now it doesn't work in
nrfconnect example, as application was relying on the cluster code.
Change overview
Added handling attribute state in the application.
Testing
Did manual testing to prove the fix works.