-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
second/later chunked report don't need honor minInterval #22139
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_chunked_report_min_interval
Aug 29, 2022
Merged
second/later chunked report don't need honor minInterval #22139
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_chunked_report_min_interval
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16e8169
to
43580da
Compare
PR #22139: Size comparison from b4776ad to 43580da Increases (27 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, cyw30739)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
andy31415
approved these changes
Aug 25, 2022
woody-apple
approved these changes
Aug 25, 2022
43580da
to
7601ca6
Compare
PR #22139: Size comparison from 5c2334a to 7601ca6 Increases (36 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, cyw30739)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
7601ca6
to
7b521ca
Compare
PR #22139: Size comparison from c990d26 to 7b521ca Increases (28 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, cyw30739)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
7b521ca
to
693a609
Compare
PR #22139: Size comparison from 48a4797 to 693a609 Increases (39 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, cyw30739)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
bzbarsky-apple
approved these changes
Aug 27, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#22132
Change overview
After sending the first report, we would run RefreshSubscribeSyncTimer in handler, where would not hold on report and honor minInterval if this is chunked report.
Testing
we establish subscription with chunked report, then set dirty for large attribute, and wait for 2 seconds minInterval, chunked report would be generated, without this fix, we only can receive the first chunked report when drive service's IO, with the fix, we would receive all chunked report without waiting.
Also fix the chunked report timeout tests for missing chunked report and missing status report.