Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infineon PSoC6] Fix for Door lock and Software Diagnostics Cluster #22082

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

praveenCY
Copy link
Contributor

Problem

Fix for DRLK2.2 , DRLK-2.3 and DRLK-2.5
Fix for ThreadMetrics read in Software Diagnostics Cluster

Change overview

Update LockManager to support Lock/Unlock state properly based on Pin configuration
Add Support for ThreadMetrics in Software Diagnostics Cluster
Updated POOL Buffer to 48 to fix Packet Empty intermittent error

Testing

Manually tested DRLK2.2 , DRLK-2.3 and DRLK-2.5 using Chip-tool
Verified thread metrics read using chip-tool
Heap usage/free verified after pool buffer increase

@github-actions
Copy link

github-actions bot commented Aug 22, 2022

PR #22082: Size comparison from f68b948 to d5fe1c8

Increases above 0.2%:

platform target config section f68b948 d5fe1c8 change % change
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1700996 1740644 39648 2.3
.bss 149688 188568 38880 26.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1644204 1683852 39648 2.4
.bss 148952 187832 38880 26.1
light cy8ckit_062s2_43012 (read/write) 1561436 1601084 39648 2.5
.bss 140816 179696 38880 27.6
lock cy8ckit_062s2_43012 (read/write) 1598724 1638828 40104 2.5
.bss 145296 184712 39416 27.1
Increases (5 builds for psoc6, telink)
platform target config section f68b948 d5fe1c8 change % change
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1700996 1740644 39648 2.3
.bss 149688 188568 38880 26.0
.debug_abbrev 1217459 1217491 32 0.0
.debug_aranges 111528 111544 16 0.0
.debug_frame 372352 372424 72 0.0
.debug_info 26643195 26645022 1827 0.0
.debug_line 3646641 3647292 651 0.0
.debug_loc 3562039 3562699 660 0.0
.debug_ranges 336576 336744 168 0.0
.debug_str 3393852 3394244 392 0.0
.strtab 569346 569658 312 0.1
.symtab 420416 420736 320 0.1
.text 1540264 1541032 768 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1644204 1683852 39648 2.4
.bss 148952 187832 38880 26.1
.debug_abbrev 1209298 1209330 32 0.0
.debug_aranges 111000 111016 16 0.0
.debug_frame 375432 375504 72 0.0
.debug_info 26379890 26381717 1827 0.0
.debug_line 3667045 3667696 651 0.0
.debug_loc 3549676 3550336 660 0.0
.debug_ranges 335192 335360 168 0.1
.debug_str 3382841 3383233 392 0.0
.strtab 533820 534132 312 0.1
.symtab 407008 407328 320 0.1
.text 1484208 1484976 768 0.1
light cy8ckit_062s2_43012 (read/write) 1561436 1601084 39648 2.5
.bss 140816 179696 38880 27.6
.debug_abbrev 1043971 1044003 32 0.0
.debug_aranges 103168 103184 16 0.0
.debug_frame 345676 345748 72 0.0
.debug_info 21844447 21846274 1827 0.0
.debug_line 3238223 3238874 651 0.0
.debug_loc 3249207 3249867 660 0.0
.debug_ranges 301032 301200 168 0.1
.debug_str 3188935 3189327 392 0.0
.strtab 467101 467413 312 0.1
.symtab 374064 374384 320 0.1
.text 1409784 1410552 768 0.1
lock cy8ckit_062s2_43012 (read/write) 1598724 1638828 40104 2.5
.bss 145296 184712 39416 27.1
.debug_abbrev 1051147 1051442 295 0.0
.debug_aranges 103840 103856 16 0.0
.debug_frame 348500 348576 76 0.0
.debug_info 22199615 22227899 28284 0.1
.debug_line 3246909 3247891 982 0.0
.debug_loc 3289327 3289972 645 0.0
.debug_ranges 304448 304616 168 0.1
.debug_str 3216366 3216810 444 0.0
.strtab 473342 473654 312 0.1
.symtab 377248 377568 320 0.1
.text 1442576 1443264 688 0.0
telink lighting-app tlsr9518adk80d text 589410 589412 2 0.0
Decreases (7 builds for cyw30739, nrfconnect, psoc6, telink)
platform target config section f68b948 d5fe1c8 change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 592490 592482 -8 -0.0
.app_xip_area 464372 464364 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803088 803084 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 842120 -38880 -4.4
.heap 881000 842120 -38880 -4.4
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 842856 -38880 -4.4
.heap 881736 842856 -38880 -4.4
light cy8ckit_062s2_43012 (read only) 890080 851200 -38880 -4.4
.heap 890080 851200 -38880 -4.4
lock cy8ckit_062s2_43012 (read only) 885584 846168 -39416 -4.5
.heap 885584 846168 -39416 -4.5
telink light-switch-app tlsr9518adk80d text 571322 571318 -4 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section f68b948 d5fe1c8 change % change
bl602 lighting-app bl602 (read/write) 1383874 1383874 0 0.0
.bss 120258 120258 0 0.0
.data 4480 4480 0 0.0
.text 1051056 1051056 0 0.0
bl602+rpc (read/write) 1429378 1429378 0 0.0
.bss 127698 127698 0 0.0
.data 4600 4600 0 0.0
.text 1082812 1082812 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 673035 673035 0 0.0
(read/write) 178460 178460 0 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583884 583884 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637755 637755 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559452 559452 0 0.0
lock-ftd LP_CC2652R7 (read only) 674103 674103 0 0.0
(read/write) 167592 167592 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596952 596952 0 0.0
lock-mtd LP_CC2652R7 (read only) 656839 656839 0 0.0
(read/write) 180544 180544 0 0.0
.bss 67164 67164 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554600 554600 0 0.0
pump-app LP_CC2652R7 (read only) 684775 684775 0 0.0
(read/write) 157728 157728 0 0.0
.bss 71516 71516 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594332 594332 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669267 669267 0 0.0
(read/write) 173356 173356 0 0.0
.bss 71636 71636 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583272 583272 0 0.0
shell LP_CC2652R7 (read only) 665718 665718 0 0.0
(read/write) 181296 181296 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579620 579620 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586690 586690 0 0.0
.app_xip_area 463356 463356 0 0.0
.bss 65768 65768 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592490 592482 -8 -0.0
.app_xip_area 464372 464364 -8 -0.0
.bss 70552 70552 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599610 599610 0 0.0
.app_xip_area 476996 476996 0 0.0
.bss 65080 65080 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1104732 1104732 0 0.0
.bss 133572 133572 0 0.0
.data 2072 2072 0 0.0
.text 969068 969068 0 0.0
BRD4161A+rpc (read/write) 967916 967916 0 0.0
.bss 147572 147572 0 0.0
.data 2252 2252 0 0.0
.text 818068 818068 0 0.0
BRD4161A+rs911x (read/write) 998016 998016 0 0.0
.bss 166992 166992 0 0.0
.data 2056 2056 0 0.0
.text 828948 828948 0 0.0
lock-app BRD4161A+wf200 (read/write) 1147380 1147380 0 0.0
.bss 150168 150168 0 0.0
.data 2064 2064 0 0.0
.text 995128 995128 0 0.0
window-app BRD4161A (read/write) 1096060 1096060 0 0.0
.bss 135012 135012 0 0.0
.data 2096 2096 0 0.0
.text 958932 958932 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031270 1031270 0 0.0
(read/write) 1489610 1489610 0 0.0
.dram0.bss 71136 71136 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218440 218440 0 0.0
.flash.text 1031270 1031270 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084387 1084387 0 0.0
(read/write) 491544 491544 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1079003 1079003 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646676 646676 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571480 571480 0 0.0
lock k32w0+release (read/write) 704220 704220 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628552 628552 0 0.0
linux all-clusters-app debug (read only) 3038505 3038505 0 0.0
(read/write) 156024 156024 0 0.0
.bss 61920 61920 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274667 274667 0 0.0
.text 2584690 2584690 0 0.0
all-clusters-minimal-app debug (read only) 2874369 2874369 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274859 274859 0 0.0
.text 2423138 2423138 0 0.0
bridge-app debug+rpc (read only) 2373017 2373017 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203496 203496 0 0.0
.text 2006898 2006898 0 0.0
chip-tool debug (read only) 1087697 1087697 0 0.0
(read/write) 651328 651328 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 616312 616312 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 562901 562901 0 0.0
.text 8807348 8807348 0 0.0
chip-tool-ipv6only arm64 (read only) 10259132 10259132 0 0.0
(read/write) 699137 699137 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643824 643824 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493564 493564 0 0.0
.text 8127428 8127428 0 0.0
lighting-app debug+rpc (read only) 2597033 2597033 0 0.0
(read/write) 130176 130176 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72360 72360 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220304 220304 0 0.0
.text 2206018 2206018 0 0.0
lock-app debug (read only) 2580945 2580945 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237360 237360 0 0.0
.text 2176930 2176930 0 0.0
ota-provider-app debug (read only) 2358105 2358105 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209336 209336 0 0.0
.text 1985298 1985298 0 0.0
ota-requestor-app debug (read only) 2523385 2523385 0 0.0
(read/write) 127320 127320 0 0.0
.bss 50336 50336 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68728 68728 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216160 216160 0 0.0
.text 2134658 2134658 0 0.0
shell debug (read only) 2606809 2606809 0 0.0
(read/write) 142144 142144 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234770 234770 0 0.0
.text 2213618 2213618 0 0.0
thermostat-no-ble arm64 (read only) 2357300 2357300 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140620 140620 0 0.0
.text 1978960 1978960 0 0.0
tv-app debug (read only) 3181625 3181625 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259016 259016 0 0.0
.text 2732866 2732866 0 0.0
tv-casting-app debug (read only) 5502177 5502177 0 0.0
(read/write) 160464 160464 0 0.0
.bss 51480 51480 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344209 344209 0 0.0
.text 4886354 4886354 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180619 1180619 0 0.0
bss 143737 143737 0 0.0
rodata 143356 143356 0 0.0
text 814680 814680 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159815 1159815 0 0.0
bss 142964 142964 0 0.0
rodata 134944 134944 0 0.0
text 803088 803084 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 842120 -38880 -4.4
(read/write) 1700996 1740644 39648 2.3
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 188568 38880 26.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217459 1217491 32 0.0
.debug_aranges 111528 111544 16 0.0
.debug_frame 372352 372424 72 0.0
.debug_info 26643195 26645022 1827 0.0
.debug_line 3646641 3647292 651 0.0
.debug_loc 3562039 3562699 660 0.0
.debug_ranges 336576 336744 168 0.0
.debug_str 3393852 3394244 392 0.0
.heap 881000 842120 -38880 -4.4
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569346 569658 312 0.1
.symtab 420416 420736 320 0.1
.text 1540264 1541032 768 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 842856 -38880 -4.4
(read/write) 1644204 1683852 39648 2.4
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 187832 38880 26.1
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209298 1209330 32 0.0
.debug_aranges 111000 111016 16 0.0
.debug_frame 375432 375504 72 0.0
.debug_info 26379890 26381717 1827 0.0
.debug_line 3667045 3667696 651 0.0
.debug_loc 3549676 3550336 660 0.0
.debug_ranges 335192 335360 168 0.1
.debug_str 3382841 3383233 392 0.0
.heap 881736 842856 -38880 -4.4
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533820 534132 312 0.1
.symtab 407008 407328 320 0.1
.text 1484208 1484976 768 0.1
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 851200 -38880 -4.4
(read/write) 1561436 1601084 39648 2.5
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 179696 38880 27.6
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1043971 1044003 32 0.0
.debug_aranges 103168 103184 16 0.0
.debug_frame 345676 345748 72 0.0
.debug_info 21844447 21846274 1827 0.0
.debug_line 3238223 3238874 651 0.0
.debug_loc 3249207 3249867 660 0.0
.debug_ranges 301032 301200 168 0.1
.debug_str 3188935 3189327 392 0.0
.heap 890080 851200 -38880 -4.4
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467101 467413 312 0.1
.symtab 374064 374384 320 0.1
.text 1409784 1410552 768 0.1
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 846168 -39416 -4.5
(read/write) 1598724 1638828 40104 2.5
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 184712 39416 27.1
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051147 1051442 295 0.0
.debug_aranges 103840 103856 16 0.0
.debug_frame 348500 348576 76 0.0
.debug_info 22199615 22227899 28284 0.1
.debug_line 3246909 3247891 982 0.0
.debug_loc 3289327 3289972 645 0.0
.debug_ranges 304448 304616 168 0.1
.debug_str 3216366 3216810 444 0.0
.heap 885584 846168 -39416 -4.5
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473342 473654 312 0.1
.symtab 377248 377568 320 0.1
.text 1442576 1443264 688 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808744 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571322 571318 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 830680 830680 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589410 589412 2 0.0

@ifyall
Copy link

ifyall commented Aug 24, 2022

I am the platform owner for the Infineon PSoC 6 platform and I approve this request.

@woody-apple woody-apple enabled auto-merge (squash) August 25, 2022 17:20
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes

@woody-apple woody-apple merged commit b0e5559 into project-chip:master Aug 25, 2022
woody-apple added a commit that referenced this pull request Aug 26, 2022
#22169)

Co-authored-by: Praveen Chandran <PraveenBabu.Chandran@infineon.com>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants