-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infineon PSoC6] Fix for Door lock and Software Diagnostics Cluster #22082
Merged
woody-apple
merged 1 commit into
project-chip:master
from
praveenCY:topic/pucn_drlkfixes
Aug 25, 2022
Merged
[Infineon PSoC6] Fix for Door lock and Software Diagnostics Cluster #22082
woody-apple
merged 1 commit into
project-chip:master
from
praveenCY:topic/pucn_drlkfixes
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenCY
force-pushed
the
topic/pucn_drlkfixes
branch
from
August 22, 2022 19:37
64fd36b
to
d5fe1c8
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
August 22, 2022 19:37
pullapprove
bot
requested review from
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
August 22, 2022 19:37
PR #22082: Size comparison from f68b948 to d5fe1c8 Increases above 0.2%:
Increases (5 builds for psoc6, telink)
Decreases (7 builds for cyw30739, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
I am the platform owner for the Infineon PSoC 6 platform and I approve this request. |
woody-apple
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes
woody-apple
added a commit
that referenced
this pull request
Aug 26, 2022
#22169) Co-authored-by: Praveen Chandran <PraveenBabu.Chandran@infineon.com>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix for DRLK2.2 , DRLK-2.3 and DRLK-2.5
Fix for ThreadMetrics read in Software Diagnostics Cluster
Change overview
Update LockManager to support Lock/Unlock state properly based on Pin configuration
Add Support for ThreadMetrics in Software Diagnostics Cluster
Updated POOL Buffer to 48 to fix Packet Empty intermittent error
Testing
Manually tested DRLK2.2 , DRLK-2.3 and DRLK-2.5 using Chip-tool
Verified thread metrics read using chip-tool
Heap usage/free verified after pool buffer increase