[EFR32] Provide a way to build matter examples using a openthread library #21836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
efr32
examples
github
inet
platform
scripts
test driver
workflows
labels
|
PR #21836: Size comparison from 1845133 to 3c24975 Increases (5 builds for cc13x2_26x2, efr32, esp32)
Decreases (6 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
force-pushed
the
thread_cert_lib
branch
from
3c24975
to
f8db6b4
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton and
jepenven-silabs
…orms. Add new ot support to all efr32 examples
…r ot-efr32 (temporary)
…be set. Change efr32 build system with those changes
jmartinez-silabs
force-pushed
the
thread_cert_lib
branch
from
a9fc5a3
to
a957c5b
Compare
jmartinez-silabs
force-pushed
the
thread_cert_lib
branch
from
a957c5b
to
0d180e9
Compare
|
PR #21836: Size comparison from 6322b8d to 0d180e9 Increases (10 builds for cc13x2_26x2, efr32, k32w, nrfconnect, telink)
Decreases (3 builds for cc13x2_26x2, cyw30739, nrfconnect)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
pushed a commit
that referenced
this pull request
Aug 16, 2022
…rary (#21836) * WIP build with ot-lib * WIP compile from lib or source * Fix and cleanup build system * Fix efr32 path to internal thread source without breaking other platforms. Add new ot support to all efr32 examples * restyle * add recursive submodule update for efr to pull the openthread repo for ot-efr32 (temporary) * fix for wifi builds * Fix assert with ot lib * Use plaform dmp lib * Update ot-efr32 hash for new libs * Addresse comment by correcting how and where a openthread_target can be set. Change efr32 build system with those changes * restyle * some cleanup * more cleanup * Fix wifi build
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Aug 29, 2022
…read library (project-chip#21836)" This reverts commit 7816a69.
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…rary (project-chip#21836) * WIP build with ot-lib * WIP compile from lib or source * Fix and cleanup build system * Fix efr32 path to internal thread source without breaking other platforms. Add new ot support to all efr32 examples * restyle * add recursive submodule update for efr to pull the openthread repo for ot-efr32 (temporary) * fix for wifi builds * Fix assert with ot lib * Use plaform dmp lib * Update ot-efr32 hash for new libs * Addresse comment by correcting how and where a openthread_target can be set. Change efr32 build system with those changes * restyle * some cleanup * more cleanup * Fix wifi build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, EFR32 thread examples are building openthread from sources of openthread and ot-efr32 submodules. Those paths are set.
Change overview
This PR provides a way to either keep building open thread from source or pre-build open thread libraries (aka certified/certifiables libs)
The structure created here can be used by other platforms and also doesn't break/change the current/usual usage
This is the first step and it still uses the ot-efr32 submodule in both cases but it will evolve to use libs from Silabs SDK soon.
How it works:
A new build argument, located in third_party/openthread/BUILD.gn
chip_openthread_target-> Points to your new openthread target source set e.jchip_openthread_target = [ "${efr32_sdk_build_root}:ot-efr32-cert" ].Default = ""New gn group(
openthread_device_deps) in third_party/openthread/BUILD.gn. This is used to set the right public dependencies to thread.If
chip_openthread_targetis left empty, use the current dependencies from the sources. (either${openthread_root}:libopenthread-ftdor${openthread_root}:libopenthread-mtd")else set the public dependency your defined lib/source set located at
chip_openthread_targetThe rest of the changes are EFR32 platform specific to make the build work with either option.
Testing
Standard lighting app build tested with chip-tool.
Build with silabs thread lib using
./scripts/examples/gn_efr32_example.sh examples/lighting-app/efr32/ out/lighting_app BRD4166A --use_ot_lib
And tested with chip-tool
(Current lib is quite large and you might need to disable some feature so the image fits in the flash of some boards enable_openthread_cli=false chip_build_libshell=false )