Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infineon] Label Cluster support for Infineon P6 example apps #21726

Merged

Conversation

praveenCY
Copy link
Contributor

Problem

Label Cluster, localizationconfiguration Cluster not working as expected for Infineon P6 example apps

Change overview

Set DeviceInfoProvider Info properly during example Init to fix label and localization Cluster read/write

Testing

Manually verified label and Localization Cluster with the changes and it works.

TC-ULABEL-* TC-LCFG-* Test cases verified

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

PR #21726: Size comparison from c3cc4a2 to d5aeb88

Increases above 0.2%:

platform target config section c3cc4a2 d5aeb88 change % change
p6 all-clusters-app default .data 2648 2656 8 0.3
all-clusters-minimal-app default .data 2648 2656 8 0.3
light-app default .data 2440 2448 8 0.3
lock-app default .data 2456 2464 8 0.3
Increases (8 builds for bl602, k32w, p6, telink)
platform target config section c3cc4a2 d5aeb88 change % change
bl602 lighting-app bl602 .text 1047896 1047900 4 0.0
k32w lock k32w0+release (read/write) 700748 700764 16 0.0
.text 625784 625800 16 0.0
p6 all-clusters-app default (read/write) 1690828 1693428 2600 0.2
.data 2648 2656 8 0.3
.text 1530624 1533216 2592 0.2
all-clusters-minimal-app default (read/write) 1635020 1637636 2616 0.2
.data 2648 2656 8 0.3
.text 1475536 1478144 2608 0.2
light-app default (read/write) 1553740 1556324 2584 0.2
.data 2440 2448 8 0.3
.text 1402576 1405152 2576 0.2
lock-app default (read/write) 1591028 1593612 2584 0.2
.data 2456 2464 8 0.3
.text 1435368 1437944 2576 0.2
telink light-switch-app tlsr9518adk80d text 569662 569664 2 0.0
lighting-app tlsr9518adk80d text 587638 587640 2 0.0
Decreases (5 builds for esp32, p6)
platform target config section c3cc4a2 d5aeb88 change % change
esp32 all-clusters-app c3devkit (read only) 1025874 1025870 -4 -0.0
.flash.text 1025874 1025870 -4 -0.0
p6 all-clusters-app default (read only) 881528 881520 -8 -0.0
all-clusters-minimal-app default (read only) 882248 882240 -8 -0.0
light-app default (read only) 890568 890560 -8 -0.0
lock-app default (read only) 886072 886064 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c3cc4a2 d5aeb88 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379714 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047896 1047900 4 0.0
bl602+rpc (read/write) 1424970 1424970 0 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079400 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670775 0 0.0
(read/write) 180608 180608 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 581988 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636311 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558260 0 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672619 0 0.0
(read/write) 168948 168948 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595728 0 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655171 0 0.0
(read/write) 182084 182084 0 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553336 0 0.0
pump-app LP_CC2652R7 (read only) 682855 682855 0 0.0
(read/write) 159520 159520 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89295 0 0.0
.text 593076 593076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667319 0 0.0
(read/write) 175192 175192 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84839 0 0.0
.text 582000 582000 0 0.0
shell LP_CC2652R7 (read only) 663450 663450 0 0.0
(read/write) 183452 183452 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577716 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584390 0 0.0
.app_xip_area 461192 461192 0 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590310 0 0.0
.app_xip_area 462328 462328 0 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589378 0 0.0
.app_xip_area 466996 466996 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096068 0 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961132 961132 0 0.0
BRD4161A+rpc (read/write) 1150332 1150332 0 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998500 998500 0 0.0
BRD4161A+rs911x (read/write) 985356 985356 0 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821096 821096 0 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136024 0 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989116 989116 0 0.0
window-app BRD4161A (read/write) 1087808 1087808 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951400 951400 0 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025870 -4 -0.0
(read/write) 1487282 1487282 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216912 216912 0 0.0
.flash.text 1025874 1025870 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079171 1079171 0 0.0
(read/write) 489288 489288 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247308 247308 0 0.0
.flash.text 1073787 1073787 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643372 643372 0 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 568888 0 0.0
lock k32w0+release (read/write) 700748 700764 16 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625784 625800 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9880188 9880188 0 0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466252 466252 0 0.0
.text 7786644 7786644 0 0.0
thermostat-no-ble arm64 (read only) 2349772 2349772 0 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139668 0 0.0
.text 1972592 1972592 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452504 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415148 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177763 0 0.0
bss 143222 143222 0 0.0
rodata 142756 142756 0 0.0
text 812932 812932 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157819 0 0.0
bss 142460 142460 0 0.0
rodata 134452 134452 0 0.0
text 802084 802084 0 0.0
p6 all-clusters-app default (read only) 881528 881520 -8 -0.0
(read/write) 1690828 1693428 2600 0.2
.bss 149168 149168 0 0.0
.data 2648 2656 8 0.3
.text 1530624 1533216 2592 0.2
all-clusters-minimal-app default (read only) 882248 882240 -8 -0.0
(read/write) 1635020 1637636 2616 0.2
.bss 148448 148448 0 0.0
.data 2648 2656 8 0.3
.text 1475536 1478144 2608 0.2
light-app default (read only) 890568 890560 -8 -0.0
(read/write) 1553740 1556324 2584 0.2
.bss 140336 140336 0 0.0
.data 2440 2448 8 0.3
.text 1402576 1405152 2576 0.2
lock-app default (read only) 886072 886064 -8 -0.0
(read/write) 1591028 1593612 2584 0.2
.bss 144816 144816 0 0.0
.data 2456 2464 8 0.3
.text 1435368 1437944 2576 0.2
telink light-switch-app tlsr9518adk80d (read/write) 805912 805912 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569662 569664 2 0.0
lighting-app tlsr9518adk80d (read/write) 827720 827720 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587638 587640 2 0.0

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, I guess, but the fact that we're adding broken code to pass SVE is just broken. ;)

@woody-apple woody-apple enabled auto-merge (squash) August 9, 2022 14:55
@woody-apple woody-apple merged commit 5801963 into project-chip:master Aug 9, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants