Add Java callbacks for NOC Generation #21522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kpschoedel
chrisdecenzo
changed the title
src/controller/java/src/chip/devicecontroller/ChipDeviceController.java
Outdated
Show resolved
Hide resolved
src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.cpp
Outdated
Show resolved
Hide resolved
g-coppock
reviewed
Aug 3, 2022
sharadb-amazon
approved these changes
Aug 3, 2022
src/controller/java/src/chip/devicecontroller/ControllerParams.java
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Aug 3, 2022
* Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
woody-apple
approved these changes
Aug 4, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Draft: Add Java callbacks for NOC Generation * address feedback * address feedback * add missing fields for complete attestation validation * address comments, use adminSubject and ipk from earlier setup if not provided in setNOCChain * address comments * address comments * address comments * address comments * address comments * address comments * Restyle Draft: Add Java callbacks for NOC Generation (project-chip#21523) * Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing