Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat PICS as case-insensitive in YAML. #21450

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Treat PICS as case-insensitive in YAML. #21450

merged 1 commit into from
Jul 30, 2022

Conversation

woody-apple
Copy link
Contributor

Fixes #21425

Problem

People have a hard time spelling PICS right wrt case.

Change overview

Treat PICS as case-insensitive in YAML tests.

Testing

Checked that if I use a case-mismatched PICS value it gets treated correctly.

@woody-apple woody-apple enabled auto-merge (squash) July 29, 2022 22:46
@github-actions
Copy link

github-actions bot commented Jul 30, 2022 •
edited
Loading

PR #21450: Size comparison from 9be374f to a00612b

Increases (5 builds for bl602, cc13x2_26x2, esp32, linux)
platform target config section 9be374f a00612b change % change
bl602 lighting-app bl602+rpc .text 1083824 1083828 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182580 182588 8 0.0
esp32 all-clusters-app c3devkit (read only) 1023418 1023420 2 0.0
.flash.text 1023418 1023420 2 0.0
linux chip-tool debug (read only) 10419073 10419681 608 0.0
.text 8438372 8438980 608 0.0
chip-tool-ipv6only arm64 (read only) 9831892 9832308 416 0.0
.text 7788500 7788916 416 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 9be374f a00612b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668771 668763 -8 -0.0
.text 580172 580164 -8 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9be374f a00612b change % change
bl602 lighting-app bl602 (read/write) 1382018 1382018 0 0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052132 1052132 0 0.0
bl602+rpc (read/write) 1427450 1427450 0 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1083824 1083828 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668771 668763 -8 -0.0
(read/write) 182580 182588 8 0.0
.bss 74244 74244 0 0.0
.data 3372 3372 0 0.0
.rodata 88283 88283 0 0.0
.text 580172 580164 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634387 634387 0 0.0
(read/write) 157828 157828 0 0.0
.bss 73540 73540 0 0.0
.data 3372 3372 0 0.0
.rodata 77507 77507 0 0.0
.text 556556 556556 0 0.0
lock-ftd LP_CC2652R7 (read only) 671647 671647 0 0.0
(read/write) 169896 169896 0 0.0
.bss 71324 71324 0 0.0
.data 3296 3296 0 0.0
.rodata 76351 76351 0 0.0
.text 594816 594816 0 0.0
lock-mtd LP_CC2652R7 (read only) 653819 653819 0 0.0
(read/write) 183412 183412 0 0.0
.bss 67012 67012 0 0.0
.data 3296 3296 0 0.0
.rodata 101011 101011 0 0.0
.text 552328 552328 0 0.0
pump-app LP_CC2652R7 (read only) 680839 680839 0 0.0
(read/write) 161528 161528 0 0.0
.bss 71380 71380 0 0.0
.data 3296 3296 0 0.0
.rodata 88919 88919 0 0.0
.text 591436 591436 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666415 666415 0 0.0
(read/write) 176088 176088 0 0.0
.bss 71516 71516 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581192 581192 0 0.0
shell LP_CC2652R7 (read only) 661478 661478 0 0.0
(read/write) 185392 185392 0 0.0
.bss 76564 76564 0 0.0
.data 3376 3376 0 0.0
.rodata 85262 85262 0 0.0
.text 575900 575900 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583542 583542 0 0.0
.app_xip_area 460496 460496 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589294 589294 0 0.0
.app_xip_area 461520 461520 0 0.0
.bss 70360 70360 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589242 589242 0 0.0
.app_xip_area 467012 467012 0 0.0
.bss 64872 64872 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088688 1088688 0 0.0
.bss 133268 133268 0 0.0
.data 2064 2064 0 0.0
.text 953336 953336 0 0.0
BRD4161A+rpc (read/write) 1143044 1143044 0 0.0
.bss 149948 149948 0 0.0
.data 2276 2276 0 0.0
.text 990800 990800 0 0.0
BRD4161A+rs911x (read/write) 973984 973984 0 0.0
.bss 161744 161744 0 0.0
.data 2048 2048 0 0.0
.text 810172 810172 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128752 1128752 0 0.0
.bss 144376 144376 0 0.0
.data 2056 2056 0 0.0
.text 982300 982300 0 0.0
window-app BRD4161A (read/write) 1081988 1081988 0 0.0
.bss 134740 134740 0 0.0
.data 2092 2092 0 0.0
.text 945132 945132 0 0.0
esp32 all-clusters-app c3devkit (read only) 1023418 1023420 2 0.0
(read/write) 1486482 1486482 0 0.0
.dram0.bss 70304 70304 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216144 216144 0 0.0
.flash.text 1023418 1023420 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076819 1076819 0 0.0
(read/write) 488520 488520 0 0.0
.dram0.bss 75816 75816 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246564 246564 0 0.0
.flash.text 1071435 1071435 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643128 643128 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 568636 568636 0 0.0
lock k32w0+release (read/write) 700128 700128 0 0.0
.bss 70160 70160 0 0.0
.data 2052 2052 0 0.0
.text 625188 625188 0 0.0
linux all-clusters-app debug (read only) 2993609 2993609 0 0.0
(read/write) 155680 155680 0 0.0
.bss 61920 61920 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85352 85352 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 269355 269355 0 0.0
.text 2545490 2545490 0 0.0
all-clusters-minimal-app debug (read only) 2836633 2836633 0 0.0
(read/write) 147384 147384 0 0.0
.bss 61120 61120 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77944 77944 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 269515 269515 0 0.0
.text 2390962 2390962 0 0.0
bridge-app debug+rpc (read only) 2355617 2355617 0 0.0
(read/write) 127576 127576 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 201736 201736 0 0.0
.text 1990898 1990898 0 0.0
chip-tool debug (read only) 10419073 10419681 608 0.0
(read/write) 628376 628376 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 593744 593744 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 535509 535509 0 0.0
.text 8438372 8438980 608 0.0
chip-tool-ipv6only arm64 (read only) 9831892 9832308 416 0.0
(read/write) 675905 675905 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 621248 621248 0 0.0
.dynamic 560 560 0 0.0
.got 13528 13528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467636 467636 0 0.0
.text 7788500 7788916 416 0.0
lighting-app debug+rpc (read only) 2577881 2577881 0 0.0
(read/write) 130256 130256 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 217328 217328 0 0.0
.text 2189506 2189506 0 0.0
lock-app debug (read only) 2542001 2542001 0 0.0
(read/write) 125272 125272 0 0.0
.bss 48192 48192 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69432 69432 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 232304 232304 0 0.0
.text 2143426 2143426 0 0.0
ota-provider-app debug (read only) 2346329 2346329 0 0.0
(read/write) 119040 119040 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207896 0 0.0
.text 1974578 1974578 0 0.0
ota-requestor-app debug (read only) 2467225 2467225 0 0.0
(read/write) 126432 126432 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 211424 211424 0 0.0
.text 2083330 2083330 0 0.0
shell debug (read only) 2576897 2576897 0 0.0
(read/write) 141832 141832 0 0.0
.bss 57768 57768 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 231442 231442 0 0.0
.text 2187250 2187250 0 0.0
thermostat-no-ble arm64 (read only) 2345324 2345324 0 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75976 75976 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139124 139124 0 0.0
.text 1968688 1968688 0 0.0
tv-app debug (read only) 3131937 3131937 0 0.0
(read/write) 257512 257512 0 0.0
.bss 167288 167288 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78960 78960 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 254760 254760 0 0.0
.text 2687938 2687938 0 0.0
tv-casting-app debug (read only) 5384457 5384457 0 0.0
(read/write) 158720 158720 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 338801 338801 0 0.0
.text 4778386 4778386 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2451200 2451200 0 0.0
.bss 214524 214524 0 0.0
.data 5872 5872 0 0.0
.text 1413844 1413844 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178071 1178071 0 0.0
bss 143128 143128 0 0.0
rodata 142752 142752 0 0.0
text 813240 813240 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1158055 1158055 0 0.0
bss 142364 142364 0 0.0
rodata 134280 134280 0 0.0
text 802484 802484 0 0.0
p6 all-clusters-app default (read only) 881552 881552 0 0.0
(read/write) 1687756 1687756 0 0.0
.bss 149144 149144 0 0.0
.data 2648 2648 0 0.0
.text 1527576 1527576 0 0.0
all-clusters-minimal-app default (read only) 882272 882272 0 0.0
(read/write) 1631868 1631868 0 0.0
.bss 148424 148424 0 0.0
.data 2648 2648 0 0.0
.text 1472408 1472408 0 0.0
light-app default (read only) 890576 890576 0 0.0
(read/write) 1553052 1553052 0 0.0
.bss 140328 140328 0 0.0
.data 2440 2440 0 0.0
.text 1401896 1401896 0 0.0
lock-app default (read only) 886104 886104 0 0.0
(read/write) 1590468 1590468 0 0.0
.bss 144784 144784 0 0.0
.data 2456 2456 0 0.0
.text 1434840 1434840 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 800240 800240 0 0.0
bss 70804 70804 0 0.0
noinit 40416 40416 0 0.0
text 567668 567668 0 0.0
lighting-app tlsr9518adk80d (read/write) 820648 820648 0 0.0
bss 71648 71648 0 0.0
noinit 40416 40416 0 0.0
text 584528 584528 0 0.0

@woody-apple woody-apple merged commit f2ee166 into sve Jul 30, 2022
@woody-apple woody-apple deleted the cherry-pick-561eaea8973fe8f44f9fa4678de93a24b0050ac5 branch July 30, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @bzbarsky-apple