Establish CASE on re-subscription #21310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for re-establishing CASE on re-subscription if a
CHIP_ERROR_TIMEOUT
was encountered as a default policy implementation, with the application having the ability to over-ride that if needed.Fixes #16202
This works out-of-the-box if you call
SendAutoResubscribeRequest
.This deletes the function-callback approach in
ReadPrepareParams::mResubscribePolicy
and uses instead the re-named,ReadClient::Callback::OnResubscriptionNeeded
callback to effect the right re-subscription policy.That callback now pivots from being just an informational callback to one that places the onus on the application (if it over-rides the default impl) to schedule the ensuing re-subscription by calling back into
ReadClient::ScheduleResubscription
.Helper methods are provided to help applications pick and select elements of the default re-sub implementation as they desire.
Other notables:
Testing
TestSubscribeAttributeTimeout
inTestRead.cpp
that validates re-subscription sans CASE.TestResubscription
in the Python test suite that validates re-subscription with CASE.