-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lambda return type inference #20457
Merged
woody-apple
merged 1 commit into
project-chip:master
from
mrjerryjohns:lambda-return-type-inference
Jul 7, 2022
Merged
Fix lambda return type inference #20457
woody-apple
merged 1 commit into
project-chip:master
from
mrjerryjohns:lambda-return-type-inference
Jul 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some compilers (some ARM-based Linux compilers) have difficulty inferring the return type of lambdas that don't explicitly state their return type. This causes issues when passing lambdas as arguments into functions that expect a specific function signature. This fixes this specific instance in CASEServer that has this problem.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang and
rgoliver
July 7, 2022 19:19
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
July 7, 2022 19:19
We should merge this into SVE since it's blocking compilation on ARM Linux platforms. |
tcarmelveilleux
approved these changes
Jul 7, 2022
isiu-apple
approved these changes
Jul 7, 2022
SVE: need to be able to compile in SVE branch for as many targets as possible |
msandstedt
approved these changes
Jul 7, 2022
PR #20457: Size comparison from 4f7d5cf to 522fd0d Increases (6 builds for cc13x2_26x2, cyw30739, efr32, esp32, mbed)
Decreases (4 builds for cc13x2_26x2, nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
Some compilers (some ARM-based Linux compilers) have difficulty inferring the return type of lambdas that don't explicitly state their return type. This causes issues when passing lambdas as arguments into functions that expect a specific function signature. This fixes this specific instance in CASEServer that has this problem.
woody-apple
added a commit
that referenced
this pull request
Jul 7, 2022
Some compilers (some ARM-based Linux compilers) have difficulty inferring the return type of lambdas that don't explicitly state their return type. This causes issues when passing lambdas as arguments into functions that expect a specific function signature. This fixes this specific instance in CASEServer that has this problem. Co-authored-by: Jerry Johns <johnsj@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers (some ARM-based Linux compilers) have difficulty inferring the return type of lambdas that don't explicitly state their return type. This causes issues when passing lambdas as arguments into
functions that expect a specific function signature.
This fixes this specific instance in CASEServer that has this problem: