Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not build linux-tests for fake platform with clang. Disable such tests in general in cloudbuild. #20373

Merged
merged 8 commits into from
Jul 6, 2022
Merged

Do not build linux-tests for fake platform with clang. Disable such tests in general in cloudbuild. #20373

merged 8 commits into from
Jul 6, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Target fake-x64-tests-clang does not compile because the target toolchain is actually GCC.

This results in:

gcc: error: unrecognized command line option ‘-Wheader-hygiene’
gcc: error: unrecognized command line option ‘-Wformat-type-confusion’

Change overview

Remove the clang fake test target, make sure we do not get this error again by checking argument compatibility.

Testing

validated build variant does not show anymore. Unit tests.

@boring-cyborg boring-cyborg bot added the scripts label Jul 6, 2022
@restyled-io restyled-io bot mentioned this pull request Jul 6, 2022
Closed
@andy31415 andy31415 changed the title Do not fake clang Do not build linux-tests for fake platform with clang. Disable such tests in general in cloudbuild. Jul 6, 2022
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Jul 6, 2022
@andy31415
Copy link
Contributor Author

Restyler just seems to force me to create a massive delta :(

@andy31415
Copy link
Contributor Author

Hotfix because this fixes cloudbuild and the CI builds we currently have do not validate this build variant.

I have tested compilation (or rather lack of it) locally.

@github-actions
Copy link

github-actions bot commented Jul 6, 2022 •
edited
Loading

PR #20373: Size comparison from 64b179a to 31b3564

Increases (3 builds for cc13x2_26x2, esp32)
platform target config section 64b179a 31b3564 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 164512 164520 8 0.0
shell LP_CC2652R7 (read/write) 188784 188792 8 0.0
esp32 all-clusters-app c3devkit (read only) 1019366 1019368 2 0.0
.flash.text 1019366 1019368 2 0.0
Decreases (5 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section 64b179a 31b3564 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 617759 617751 -8 -0.0
.text 541184 541176 -8 -0.0
pump-app LP_CC2652R7 (read only) 677703 677695 -8 -0.0
.text 588788 588780 -8 -0.0
shell LP_CC2652R7 (read only) 657942 657934 -8 -0.0
.text 572780 572772 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 800360 800356 -4 -0.0
telink light-switch-app tlsr9518adk80d text 565132 565130 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 64b179a 31b3564 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665443 0 0.0
(read/write) 185780 185780 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577060 577060 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631443 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553812 0 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668343 0 0.0
(read/write) 173024 173024 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591656 591656 0 0.0
lock-mtd LP_CC2652R7 (read only) 617759 617751 -8 -0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541184 541176 -8 -0.0
pump-app LP_CC2652R7 (read only) 677703 677695 -8 -0.0
(read/write) 164512 164520 8 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588780 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663527 0 0.0
(read/write) 178808 178808 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578752 0 0.0
shell LP_CC2652R7 (read only) 657942 657934 -8 -0.0
(read/write) 188784 188792 8 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572780 572772 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579134 0 0.0
.app_xip_area 457904 457904 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 584862 584862 0 0.0
.app_xip_area 458896 458896 0 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582206 0 0.0
.app_xip_area 461824 461824 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080652 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945588 0 0.0
BRD4161A+rpc (read only) 983040 983040 0 0.0
(read/write) 151948 151948 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983032 0 0.0
BRD4161A+rs911x (read/write) 946756 946756 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803920 803920 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127288 1127288 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 981020 981020 0 0.0
window-app BRD4161A (read/write) 1074436 1074436 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 937868 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019366 1019368 2 0.0
(read/write) 1485050 1485050 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 214936 0 0.0
.flash.text 1019366 1019368 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073243 1073243 0 0.0
(read/write) 487136 487136 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245396 0 0.0
.flash.text 1067859 1067859 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684788 684788 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607004 607004 0 0.0
linux all-clusters-app debug (read only) 2955825 2955825 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263133 263133 0 0.0
.text 2515506 2515506 0 0.0
all-clusters-minimal-app debug (read only) 2809969 2809969 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264829 264829 0 0.0
.text 2370130 2370130 0 0.0
bridge-app debug+rpc (read only) 2312809 2312809 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1953122 1953122 0 0.0
chip-tool debug (read only) 10217685 10217685 0 0.0
(read/write) 611112 611112 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579328 579328 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 510885 510885 0 0.0
.text 8297349 8297349 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9939972 9939972 0 0.0
(read/write) 675889 675889 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614864 614864 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473508 473508 0 0.0
.text 7926164 7926164 0 0.0
lighting-app debug+rpc (read only) 2548345 2548345 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2164738 2164738 0 0.0
lock-app debug (read only) 2510881 2510881 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228232 228232 0 0.0
.text 2117506 2117506 0 0.0
ota-provider-app debug (read only) 2319617 2319617 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1953426 1953426 0 0.0
ota-requestor-app debug (read only) 2436753 2436753 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207200 207200 0 0.0
.text 2058402 2058402 0 0.0
shell debug (read only) 2546153 2546153 0 0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227250 227250 0 0.0
.text 2161826 2161826 0 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
tv-app debug (read only) 3099761 3099761 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2662930 2662930 0 0.0
tv-casting-app debug (read only) 5562865 5562865 0 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343209 343209 0 0.0
.text 4941794 4941794 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447400 2447400 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410044 1410044 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1173807 0 0.0
bss 142900 142900 0 0.0
rodata 141376 141376 0 0.0
text 810640 810640 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154691 0 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800356 -4 -0.0
p6 all-clusters-app default (read/write) 2563088 2563088 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521352 1521352 0 0.0
all-clusters-minimal-app default (read/write) 2508952 2508952 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467216 1467216 0 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2465672 2465672 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1423936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796636 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565132 565130 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581456 581456 0 0.0

@andy31415 andy31415 merged commit c2dd36b into project-chip:master Jul 6, 2022
andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Jul 7, 2022
@andy31415
Do not build linux-tests for fake platform with clang. Disable such t…
2e5a052 
…ests in general in cloudbuild. (project-chip#20373)

* Do not build fake-tests-clang

The compiler platform for fake-tests is //build/toolchain/fake:fake_x64_gcc
which is NOT a clang toolchain.

* Add a comment about why the board check is done

* Fix unit tests

* Do not build tests (not even the clang version) for all build in cloudbuild

* Do not build tests (not even the clang version) for all build in cloudbuild

* Restyle

* Revert "Restyle"

This reverts commit 8bd2f67.
@andy31415 andy31415 mentioned this pull request Jul 7, 2022
Merged
andy31415 added a commit that referenced this pull request Jul 7, 2022
@andy31415
Do not build linux-tests for fake platform with clang. Disable such t…
cb33c86 
…ests in general in cloudbuild. (#20373) (#20424)

* Do not build fake-tests-clang

The compiler platform for fake-tests is //build/toolchain/fake:fake_x64_gcc
which is NOT a clang toolchain.

* Add a comment about why the board check is done

* Fix unit tests

* Do not build tests (not even the clang version) for all build in cloudbuild

* Do not build tests (not even the clang version) for all build in cloudbuild

* Restyle

* Revert "Restyle"

This reverts commit 8bd2f67.
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Jul 18, 2022
@andy31415 @jmartinez-silabs
Do not build linux-tests for fake platform with clang. Disable such t…
687cc9d 
…ests in general in cloudbuild. (project-chip#20373) (project-chip#20424)

* Do not build fake-tests-clang

The compiler platform for fake-tests is //build/toolchain/fake:fake_x64_gcc
which is NOT a clang toolchain.

* Add a comment about why the board check is done

* Fix unit tests

* Do not build tests (not even the clang version) for all build in cloudbuild

* Do not build tests (not even the clang version) for all build in cloudbuild

* Restyle

* Revert "Restyle"

This reverts commit 8bd2f67.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
hotfix urgent fix needed, can bypass review integrations review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy31415