-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using no CIPD pigweed configuration when activating #20105
Merged
woody-apple
merged 2 commits into
project-chip:master
from
agners:improve-no-cipd-setup-try2
Jul 1, 2022
Merged
Allow using no CIPD pigweed configuration when activating #20105
woody-apple
merged 2 commits into
project-chip:master
from
agners:improve-no-cipd-setup-try2
Jul 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to specify custom pigweed configuration file via PW_CONFIG_FILE, e.g. PW_CONFIG_FILE=scripts/environment_no_cipd.json source scripts/bootstrap.sh This allows to use a custom pigweed config for scripts/activate.sh as well.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
June 29, 2022 08:45
pullapprove
bot
requested review from
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
June 29, 2022 08:45
PR #20105: Size comparison from 81c7f2a to 7e4eba3 Decreases (2 builds for telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jun 29, 2022
woody-apple
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently there is a no CIPD bootstrap script symlinked at
scripts/no_cipd_bootstrap.sh
. However, there is noscripts/activate.sh
equivalent (which is useful in CI e.g. when cloning manually usingscripts/checkout_submodules.py
beforehand).Change overview
Instead of using a separate script allow to pass the Pigweed bootstrap configuration file via environment variable.
Testing
Locally by building with: