Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fake platform argument to running fake tests, exclude TestFailsaf… #20091

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Add fake platform argument to running fake tests, exclude TestFailsaf… #20091

merged 2 commits into from
Jun 29, 2022

Conversation

andy31415
Copy link
Contributor

…eContext from fake platform (no timer impl)

Problem

TestFailsafeContext crashes.

Change overview

Fixes #20089

Testing

Ran tests locally

@restyled-io restyled-io bot mentioned this pull request Jun 29, 2022
Closed
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Jun 29, 2022
@andy31415
Copy link
Contributor Author

This would take 1hr to pass CI and ToT is broken. Will hotfix this in without waiting for CI.

To do this I checked:

  • PR is small/clear
  • ran x64 tests and fake tests locally on my machine, tests pass (used to fail before this PR)

@andy31415 andy31415 merged commit 5d24721 into project-chip:master Jun 29, 2022
@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited
Loading

PR #20091: Size comparison from b9068aa to c6b4a97

Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b9068aa c6b4a97 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665019 665019 0 0.0
(read/write) 187980 187980 0 0.0
.bss 75892 75892 0 0.0
.data 3356 3356 0 0.0
.rodata 88091 88091 0 0.0
.text 576612 576612 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653779 653779 0 0.0
(read/write) 198516 198516 0 0.0
.bss 75188 75188 0 0.0
.data 3356 3356 0 0.0
.rodata 91571 91571 0 0.0
.text 561892 561892 0 0.0
lock-ftd LP_CC2652R7 (read only) 667567 667567 0 0.0
(read/write) 175576 175576 0 0.0
.bss 72924 72924 0 0.0
.data 3280 3280 0 0.0
.rodata 76183 76183 0 0.0
.text 590904 590904 0 0.0
lock-mtd LP_CC2652R7 (read only) 616991 616991 0 0.0
(read/write) 146040 146040 0 0.0
.bss 68644 68644 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540432 540432 0 0.0
pump-app LP_CC2652R7 (read only) 677055 677055 0 0.0
(read/write) 166936 166936 0 0.0
.bss 73004 73004 0 0.0
.data 3280 3280 0 0.0
.rodata 88423 88423 0 0.0
.text 588148 588148 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662863 662863 0 0.0
(read/write) 181248 181248 0 0.0
.bss 73124 73124 0 0.0
.data 3276 3276 0 0.0
.rodata 84263 84263 0 0.0
.text 578120 578120 0 0.0
shell LP_CC2652R7 (read only) 657454 657454 0 0.0
(read/write) 191048 191048 0 0.0
.bss 78196 78196 0 0.0
.data 3360 3360 0 0.0
.rodata 84830 84830 0 0.0
.text 572308 572308 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580262 580262 0 0.0
.app_xip_area 457264 457264 0 0.0
.bss 65960 65960 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 581838 581838 0 0.0
.app_xip_area 458648 458648 0 0.0
.bss 66152 66152 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583326 583326 0 0.0
.app_xip_area 461176 461176 0 0.0
.bss 65168 65168 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081356 1081356 0 0.0
.bss 134772 134772 0 0.0
.data 2048 2048 0 0.0
.text 944516 944516 0 0.0
BRD4161A+rpc (read/write) 1135596 1135596 0 0.0
.bss 151452 151452 0 0.0
.data 2260 2260 0 0.0
.text 981864 981864 0 0.0
BRD4161A+rs911x (read/write) 943812 943812 0 0.0
.bss 140488 140488 0 0.0
.data 2048 2048 0 0.0
.text 801256 801256 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121112 1121112 0 0.0
.bss 140920 140920 0 0.0
.data 2060 2060 0 0.0
.text 978112 978112 0 0.0
window-app BRD4161A (read/write) 1066636 1066636 0 0.0
.bss 134852 134852 0 0.0
.data 2076 2076 0 0.0
.text 929684 929684 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018314 1018314 0 0.0
(read/write) 1486658 1486658 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 14592 14592 0 0.0
.flash.rodata 214784 214784 0 0.0
.flash.text 1018314 1018314 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072423 1072423 0 0.0
(read/write) 488760 488760 0 0.0
.dram0.bss 77376 77376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067039 1067039 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659600 659600 0 0.0
.bss 71292 71292 0 0.0
.data 1992 1992 0 0.0
.text 580516 580516 0 0.0
lock k32w061+release (read/write) 686076 686076 0 0.0
.bss 71756 71756 0 0.0
.data 2004 2004 0 0.0
.text 606516 606516 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9907764 9907764 0 0.0
(read/write) 675633 675633 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614616 614616 0 0.0
.dynamic 528 528 0 0.0
.got 13440 13440 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472548 0 0.0
.text 7895636 7895636 0 0.0
thermostat-no-ble arm64 (read only) 2590372 2590372 0 0.0
(read/write) 158865 158865 0 0.0
.bss 65857 65857 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83208 83208 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2185456 2185456 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2446528 2446528 0 0.0
.bss 215716 215716 0 0.0
.data 5872 5872 0 0.0
.text 1409172 1409172 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174559 1174559 0 0.0
bss 144660 144660 0 0.0
rodata 141344 141344 0 0.0
text 809632 809632 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155427 1155427 0 0.0
bss 143896 143896 0 0.0
rodata 133276 133276 0 0.0
text 799332 799332 0 0.0
p6 all-clusters-app default (read/write) 2562192 2562192 0 0.0
.bss 150896 150896 0 0.0
.data 2776 2776 0 0.0
.text 1520456 1520456 0 0.0
all-clusters-minimal-app default (read/write) 2508056 2508056 0 0.0
.bss 150176 150176 0 0.0
.data 2776 2776 0 0.0
.text 1466320 1466320 0 0.0
light-app default (read/write) 2438560 2438560 0 0.0
.bss 142232 142232 0 0.0
.data 2592 2592 0 0.0
.text 1396824 1396824 0 0.0
lock-app default (read/write) 2464864 2464864 0 0.0
.bss 142080 142080 0 0.0
.data 2600 2600 0 0.0
.text 1423128 1423128 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797888 797888 0 0.0
bss 72336 72336 0 0.0
noinit 40416 40416 0 0.0
text 564636 564636 0 0.0
lighting-app tlsr9518adk80d (read/write) 817756 817756 0 0.0
bss 73180 73180 0 0.0
noinit 40416 40416 0 0.0
text 580996 580996 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

Assignees
No one assigned
Labels
app hotfix urgent fix needed, can bypass review scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestFailsafeContext crashes when running fake platform tests (host tests are ok)
2 participants
@andy31415 @tcarmelveilleux