Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docker] Add git-lfs install to chip-build image #19905

Merged
merged 4 commits into from
Jun 23, 2022
Merged

[Docker] Add git-lfs install to chip-build image #19905

merged 4 commits into from
Jun 23, 2022

Conversation

mkardous-silabs
Copy link
Contributor

@mkardous-silabs mkardous-silabs commented Jun 23, 2022 •
edited
Loading

Problem

  • To accelerate GSDK update merge, temporary code was added to dockerfile
  • git-lfs is needed with the gsdk update

Change overview

  • Move git-lfs install to main chip-build docker file

Testing

  • CI build / run

@mkardous-silabs mkardous-silabs marked this pull request as ready for review June 23, 2022 16:28
@mkardous-silabs mkardous-silabs changed the title [EFR32] Clean up dockerfiles [Docker] Add git-lfs install to chip-build image Jun 23, 2022
@andy31415 andy31415 merged commit 452be38 into project-chip:master Jun 23, 2022
@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

PR #19905: Size comparison from 1381c8e to 2ac6000

Increases (3 builds for cc13x2_26x2, cyw30739, telink)
platform target config section 1381c8e 2ac6000 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 659215 659223 8 0.0
.text 575112 575120 8 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 590002 590010 8 0.0
.app_xip_area 459940 459948 8 0.0
telink light-switch-app tlsr9518adk80d text 561082 561084 2 0.0
Decreases (4 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section 1381c8e 2ac6000 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 649351 649343 -8 -0.0
.text 558408 558400 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 183976 183968 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203187 1203171 -16 -0.0
text 824232 824228 -4 -0.0
telink lighting-app tlsr9518adk80d text 577544 577542 -2 -0.0
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1381c8e 2ac6000 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660451 660451 0 0.0
(read/write) 191620 191620 0 0.0
.bss 74964 74964 0 0.0
.data 3356 3356 0 0.0
.rodata 87011 87011 0 0.0
.text 573128 573128 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649351 649343 -8 -0.0
(read/write) 158524 158524 0 0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 90623 90623 0 0.0
.text 558408 558400 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 692099 692099 0 0.0
(read/write) 150084 150084 0 0.0
.bss 71964 71964 0 0.0
.data 3280 3280 0 0.0
.rodata 99467 99467 0 0.0
.text 592148 592148 0 0.0
lock-mtd LP_CC2652R7 (read only) 641515 641515 0 0.0
(read/write) 145096 145096 0 0.0
.bss 67700 67700 0 0.0
.data 3280 3280 0 0.0
.rodata 99355 99355 0 0.0
.text 541668 541668 0 0.0
pump-app LP_CC2652R7 (read only) 673343 673343 0 0.0
(read/write) 169736 169736 0 0.0
.bss 72092 72092 0 0.0
.data 3280 3280 0 0.0
.rodata 87783 87783 0 0.0
.text 585076 585076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659215 659223 8 0.0
(read/write) 183976 183968 -8 -0.0
.bss 72204 72204 0 0.0
.data 3276 3276 0 0.0
.rodata 83623 83623 0 0.0
.text 575112 575120 8 0.0
shell LP_CC2652R7 (read only) 690290 690290 0 0.0
(read/write) 157284 157284 0 0.0
.bss 77268 77268 0 0.0
.data 3360 3360 0 0.0
.rodata 109866 109866 0 0.0
.text 580112 580112 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 592626 592626 0 0.0
.app_xip_area 462740 462740 0 0.0
.bss 72848 72848 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590002 590010 8 0.0
.app_xip_area 459940 459948 8 0.0
.bss 73024 73024 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595142 595142 0 0.0
.app_xip_area 466128 466128 0 0.0
.bss 72032 72032 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1071784 1071784 0 0.0
.bss 133716 133716 0 0.0
.data 2048 2048 0 0.0
.text 936000 936000 0 0.0
BRD4161A+rpc (read/write) 1125852 1125852 0 0.0
.bss 150404 150404 0 0.0
.data 2260 2260 0 0.0
.text 973164 973164 0 0.0
BRD4161A+rs911x (read/write) 936456 936456 0 0.0
.bss 140088 140088 0 0.0
.data 2048 2048 0 0.0
.text 794300 794300 0 0.0
lock-app BRD4161A+wf200 (read/write) 1112148 1112148 0 0.0
.bss 140504 140504 0 0.0
.data 2056 2056 0 0.0
.text 969568 969568 0 0.0
window-app BRD4161A (read/write) 1057036 1057036 0 0.0
.bss 133788 133788 0 0.0
.data 2076 2076 0 0.0
.text 921152 921152 0 0.0
k32w light k32w061+release (read/write) 662204 662204 0 0.0
.bss 70396 70396 0 0.0
.data 1992 1992 0 0.0
.text 584016 584016 0 0.0
lock k32w061+release (read/write) 724200 724200 0 0.0
.bss 70844 70844 0 0.0
.data 2000 2000 0 0.0
.text 645556 645556 0 0.0
linux all-clusters-app debug (read only) 2939145 2939145 0 0.0
(read/write) 177136 177136 0 0.0
.bss 84192 84192 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84696 84696 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261661 261661 0 0.0
.text 2500994 2500994 0 0.0
all-clusters-minimal-app debug (read only) 2792921 2792921 0 0.0
(read/write) 169040 169040 0 0.0
.bss 83520 83520 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77336 77336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263261 263261 0 0.0
.text 2355346 2355346 0 0.0
bridge-app debug+rpc (read only) 2296905 2296905 0 0.0
(read/write) 147936 147936 0 0.0
.bss 71616 71616 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196448 196448 0 0.0
.text 1939202 1939202 0 0.0
chip-tool debug (read only) 10165629 10165629 0 0.0
(read/write) 610600 610600 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578792 578792 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508629 508629 0 0.0
.text 8249013 8249013 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9902644 0 0.0
(read/write) 675265 675265 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614184 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471492 471492 0 0.0
.text 7892292 7892292 0 0.0
lighting-app debug+rpc (read only) 2533673 2533673 0 0.0
(read/write) 151928 151928 0 0.0
.bss 72064 72064 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71912 71912 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212200 212200 0 0.0
.text 2151634 2151634 0 0.0
lock-app debug (read only) 2466977 2466977 0 0.0
(read/write) 146672 146672 0 0.0
.bss 70496 70496 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68632 68632 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225928 225928 0 0.0
.text 2076610 2076610 0 0.0
ota-provider-app debug (read only) 2304817 2304817 0 0.0
(read/write) 140776 140776 0 0.0
.bss 70176 70176 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202104 202104 0 0.0
.text 1940418 1940418 0 0.0
ota-requestor-app debug (read only) 2421921 2421921 0 0.0
(read/write) 147648 147648 0 0.0
.bss 72544 72544 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 67048 67048 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205984 205984 0 0.0
.text 2045266 2045266 0 0.0
shell debug (read only) 2612633 2612633 0 0.0
(read/write) 196120 196120 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77832 77832 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231698 231698 0 0.0
.text 2221154 2221154 0 0.0
thermostat-no-ble arm64 (read only) 2579044 2579044 0 0.0
(read/write) 180673 180673 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 82952 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175104 0 0.0
tv-app debug (read only) 3079665 3079665 0 0.0
(read/write) 277864 277864 0 0.0
.bss 187720 187720 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247808 247808 0 0.0
.text 2644946 2644946 0 0.0
tv-casting-app debug (read only) 5542289 5542289 0 0.0
(read/write) 184144 184144 0 0.0
.bss 72872 72872 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102592 102592 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341737 341737 0 0.0
.text 4924274 4924274 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439536 0 0.0
.bss 214692 214692 0 0.0
.data 5864 5864 0 0.0
.text 1402180 1402180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203187 1203171 -16 -0.0
bss 143646 143646 0 0.0
rodata 156388 156388 0 0.0
text 824232 824228 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1150535 1150535 0 0.0
bss 142882 142882 0 0.0
rodata 132720 132720 0 0.0
text 796024 796024 0 0.0
p6 all-clusters-app default (read/write) 2555952 2555952 0 0.0
.bss 149872 149872 0 0.0
.data 2776 2776 0 0.0
.text 1514216 1514216 0 0.0
all-clusters-minimal-app default (read/write) 2501800 2501800 0 0.0
.bss 149152 149152 0 0.0
.data 2776 2776 0 0.0
.text 1460064 1460064 0 0.0
light-app default (read/write) 2432552 2432552 0 0.0
.bss 141232 141232 0 0.0
.data 2592 2592 0 0.0
.text 1390816 1390816 0 0.0
lock-app default (read/write) 2453280 2453280 0 0.0
.bss 141056 141056 0 0.0
.data 2600 2600 0 0.0
.text 1411544 1411544 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 793000 793000 0 0.0
bss 71924 71924 0 0.0
noinit 40416 40416 0 0.0
text 561082 561084 2 0.0
lighting-app tlsr9518adk80d (read/write) 812704 812704 0 0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 577544 577542 -2 -0.0

@mkardous-silabs mkardous-silabs deleted the fix/dockerfile branch June 23, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
fast track github integrations review - pending workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkardous-silabs @andy31415 @woody-apple