Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "No command" logging during group command dispatch. #19625

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

We were logging the endpoint id and claiming it's the command id.

Problem

See above.

Change overview

Log the right thing.

Testing

Sent group command, looked at the logs.

We were logging the endpoint id and claiming it's the command id.
@github-actions
Copy link

github-actions bot commented Jun 15, 2022

PR #19625: Size comparison from dcec35a to 1b7d408

Increases (10 builds for cyw30739, efr32, esp32, linux, nrfconnect, telink)
platform target config section dcec35a 1b7d408 change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 608086 608094 8 0.0
.app_xip_area 464632 464640 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614098 614106 8 0.0
.app_xip_area 471708 471716 8 0.0
efr32 lighting-app BRD4161A+rs911x (read only) 795648 795664 16 0.0
.text 795640 795656 16 0.0
esp32 all-clusters-app c3devkit (read only) 1010584 1010586 2 0.0
.flash.text 1010584 1010586 2 0.0
m5stack (read only) 1064883 1064891 8 0.0
.flash.text 1059499 1059507 8 0.0
linux thermostat-no-ble arm64 (read only) 2558132 2558148 16 0.0
.text 2157760 2157776 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 820812 820816 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 793128 793132 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786732 786740 8 0.0
text 557630 557638 8 0.0
lighting-app tlsr9518adk80d (read/write) 806712 806728 16 0.0
text 574320 574332 12 0.0
Decreases (2 builds for linux)
platform target config section dcec35a 1b7d408 change % change
linux all-clusters-app debug (read only) 2915897 2915881 -16 -0.0
.text 2482290 2482274 -16 -0.0
ota-provider-app debug (read only) 2281969 2281953 -16 -0.0
.text 1922082 1922066 -16 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section dcec35a 1b7d408 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657643 657643 0 0.0
(read/write) 193172 193172 0 0.0
.bss 73708 73708 0 0.0
.data 3380 3380 0 0.0
.rodata 86883 86883 0 0.0
.text 570448 570448 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646159 646159 0 0.0
(read/write) 157260 157260 0 0.0
.bss 72988 72988 0 0.0
.data 3356 3356 0 0.0
.rodata 90159 90159 0 0.0
.text 555680 555680 0 0.0
lock-ftd LP_CC2652R7 (read only) 688495 688495 0 0.0
(read/write) 152424 152424 0 0.0
.bss 70700 70700 0 0.0
.data 3280 3280 0 0.0
.rodata 98911 98911 0 0.0
.text 589100 589100 0 0.0
lock-mtd LP_CC2652R7 (read only) 637903 637903 0 0.0
(read/write) 143832 143832 0 0.0
.bss 66436 66436 0 0.0
.data 3280 3280 0 0.0
.rodata 98791 98791 0 0.0
.text 538620 538620 0 0.0
pump-app LP_CC2652R7 (read only) 669719 669719 0 0.0
(read/write) 172088 172088 0 0.0
.bss 70820 70820 0 0.0
.data 3316 3316 0 0.0
.rodata 87007 87007 0 0.0
.text 582228 582228 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660443 660443 0 0.0
(read/write) 181492 181492 0 0.0
.bss 70948 70948 0 0.0
.data 3276 3276 0 0.0
.rodata 84931 84931 0 0.0
.text 575028 575028 0 0.0
shell LP_CC2652R7 (read only) 686986 686986 0 0.0
(read/write) 159324 159324 0 0.0
.bss 76004 76004 0 0.0
.data 3384 3384 0 0.0
.rodata 109410 109410 0 0.0
.text 577264 577264 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610994 610994 0 0.0
.app_xip_area 467684 467684 0 0.0
.bss 86232 86232 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608086 608094 8 0.0
.app_xip_area 464632 464640 8 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614098 614106 8 0.0
.app_xip_area 471708 471716 8 0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920548 920548 0 0.0
(read/write) 132396 132396 0 0.0
.bss 130280 130280 0 0.0
.data 2116 2116 0 0.0
.text 920540 920540 0 0.0
BRD4161A+rpc (read only) 956204 956204 0 0.0
(read/write) 149272 149272 0 0.0
.bss 146952 146952 0 0.0
.data 2320 2320 0 0.0
.text 956196 956196 0 0.0
BRD4161A+rs911x (read only) 795648 795664 16 0.0
(read/write) 128676 128676 0 0.0
.bss 126548 126548 0 0.0
.data 2124 2124 0 0.0
.text 795640 795656 16 0.0
lock-app BRD4161A+wf200 (read only) 963560 963560 0 0.0
(read/write) 129012 129012 0 0.0
.bss 126924 126924 0 0.0
.data 2088 2088 0 0.0
.text 963552 963552 0 0.0
window-app BRD4161A (read only) 905420 905420 0 0.0
(read/write) 132460 132460 0 0.0
.bss 130352 130352 0 0.0
.data 2108 2108 0 0.0
.text 905412 905412 0 0.0
esp32 all-clusters-app c3devkit (read only) 1010584 1010586 2 0.0
(read/write) 1482626 1482626 0 0.0
.dram0.bss 69344 69344 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 213200 213200 0 0.0
.flash.text 1010584 1010586 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1064883 1064891 8 0.0
(read/write) 484744 484744 0 0.0
.dram0.bss 74864 74864 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 243708 243708 0 0.0
.flash.text 1059499 1059507 8 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657192 657192 0 0.0
.bss 68708 68708 0 0.0
.data 2028 2028 0 0.0
.text 580656 580656 0 0.0
lock k32w061+release (read/write) 718848 718848 0 0.0
.bss 69140 69140 0 0.0
.data 2000 2000 0 0.0
.text 641908 641908 0 0.0
linux all-clusters-app debug (read only) 2915897 2915881 -16 -0.0
(read/write) 188168 188168 0 0.0
.bss 95648 95648 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 84264 84264 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 258173 258173 0 0.0
.text 2482290 2482274 -16 -0.0
all-clusters-minimal-app debug (read only) 2769729 2769729 0 0.0
(read/write) 180008 180008 0 0.0
.bss 94944 94944 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 76904 76904 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 259613 259613 0 0.0
.text 2336930 2336930 0 0.0
bridge-app debug+rpc (read only) 2250129 2250129 0 0.0
(read/write) 157848 157848 0 0.0
.bss 81920 81920 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 66312 66312 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 192960 192960 0 0.0
.text 1897042 1897042 0 0.0
chip-tool debug (read only) 9940773 9940773 0 0.0
(read/write) 581632 581632 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 549896 549896 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 501973 501973 0 0.0
.text 8098565 8098565 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9690140 9690140 0 0.0
(read/write) 646001 646001 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 585264 585264 0 0.0
.dynamic 528 528 0 0.0
.got 13152 13152 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466252 466252 0 0.0
.text 7753748 7753748 0 0.0
lighting-app debug+rpc (read only) 2505569 2505569 0 0.0
(read/write) 162960 162960 0 0.0
.bss 83520 83520 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 71464 71464 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 208840 208840 0 0.0
.text 2127986 2127986 0 0.0
lock-app debug (read only) 2444033 2444033 0 0.0
(read/write) 157520 157520 0 0.0
.bss 81888 81888 0 0.0
.data 1648 1648 0 0.0
.data.rel.ro 68152 68152 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 222632 222632 0 0.0
.text 2058130 2058130 0 0.0
ota-provider-app debug (read only) 2281969 2281953 -16 -0.0
(read/write) 151656 151656 0 0.0
.bss 81568 81568 0 0.0
.data 1880 1880 0 0.0
.data.rel.ro 62424 62424 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 198744 198744 0 0.0
.text 1922082 1922066 -16 -0.0
ota-requestor-app debug (read only) 2397713 2397713 0 0.0
(read/write) 158432 158432 0 0.0
.bss 83872 83872 0 0.0
.data 2168 2168 0 0.0
.data.rel.ro 66536 66536 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 202464 202464 0 0.0
.text 2025874 2025874 0 0.0
shell debug (read only) 2593257 2593257 0 0.0
(read/write) 218992 218992 0 0.0
.bss 134440 134440 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 77512 77512 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229074 229074 0 0.0
.text 2205170 2205170 0 0.0
thermostat-no-ble arm64 (read only) 2558132 2558148 16 0.0
(read/write) 191441 191441 0 0.0
.bss 99361 99361 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 82344 82344 0 0.0
.dynamic 528 528 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162692 162692 0 0.0
.text 2157760 2157776 16 0.0
tv-app debug (read only) 3053449 3053449 0 0.0
(read/write) 288960 288960 0 0.0
.bss 199144 199144 0 0.0
.data 4784 4784 0 0.0
.data.rel.ro 78592 78592 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 244448 244448 0 0.0
.text 2623074 2623074 0 0.0
tv-casting-app debug (read only) 5536049 5536049 0 0.0
(read/write) 199472 199472 0 0.0
.bss 87976 87976 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 102760 102760 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339753 339753 0 0.0
.text 4920834 4920834 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434912 2434912 0 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1397556 1397556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196643 1196643 0 0.0
bss 141554 141554 0 0.0
rodata 155420 155420 0 0.0
text 820812 820816 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144691 1144691 0 0.0
bss 140794 140794 0 0.0
rodata 131948 131948 0 0.0
text 793128 793132 4 0.0
p6 all-clusters-app default (read/write) 2549952 2549952 0 0.0
.bss 143344 143344 0 0.0
.data 2800 2800 0 0.0
.text 1508216 1508216 0 0.0
all-clusters-minimal-app default (read/write) 2495896 2495896 0 0.0
.bss 142608 142608 0 0.0
.data 2776 2776 0 0.0
.text 1454160 1454160 0 0.0
light-app default (read/write) 2426776 2426776 0 0.0
.bss 134688 134688 0 0.0
.data 2624 2624 0 0.0
.text 1385040 1385040 0 0.0
lock-app default (read/write) 2447192 2447192 0 0.0
.bss 134512 134512 0 0.0
.data 2600 2600 0 0.0
.text 1405456 1405456 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786732 786740 8 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557630 557638 8 0.0
lighting-app tlsr9518adk80d (read/write) 806712 806728 16 0.0
bss 70088 70088 0 0.0
noinit 40416 40416 0 0.0
text 574320 574332 12 0.0

@andy31415 andy31415 merged commit be878d3 into project-chip:master Jun 15, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-group-command-logging branch June 15, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants