Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Added handling Identify TriggerEffect command #19522

Merged
merged 1 commit into from
Jun 13, 2022
Merged

[nrfconnect] Added handling Identify TriggerEffect command #19522

merged 1 commit into from
Jun 13, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

All-clusters-app for nrfconnect doesn't support handling TriggerEffect command, despite it is enabled in the .zap
configuration.

Change overview

Added method that handles TriggerEffect callback.

Testing

Tested manually following the procedure from: #19419.

Fixes: #19419

@kkasperczyk-no
[nrfconnect] Added handling Identify TriggerEffect command
82517ee 
All-clusters-app for nrfconnect doesn't support handling
TriggerEffect command, despite it is enabled in the .zap
configuration.

Added method that handles TriggerEffect callback.
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

PR #19522: Size comparison from c1e1d01 to 82517ee

Increases (5 builds for efr32, esp32, nrfconnect, telink)
platform target config section c1e1d01 82517ee change % change
efr32 lock-app BRD4161A+wf200 (read only) 962652 962668 16 0.0
.text 962644 962660 16 0.0
esp32 all-clusters-app c3devkit (read only) 1010982 1010984 2 0.0
.flash.text 1010982 1010984 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195771 1196343 572 0.0
bss 141591 141619 28 0.0
rodata 155316 155616 300 0.2
text 819892 820156 264 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786716 786724 8 0.0
text 556632 556636 4 0.0
lighting-app tlsr9518adk80d text 573346 573350 4 0.0
Decreases (2 builds for cyw30739, nrfconnect)
platform target config section c1e1d01 82517ee change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606578 606570 -8 -0.0
.app_xip_area 465076 465068 -8 -0.0
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp text 669696 669692 -4 -0.0
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c1e1d01 82517ee change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656343 656343 0 0.0
(read/write) 194544 194544 0 0.0
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 86527 86527 0 0.0
.text 569504 569504 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 644835 0 0.0
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554480 554480 0 0.0
lock-ftd LP_CC2652R7 (read only) 687707 687707 0 0.0
(read/write) 154252 154252 0 0.0
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588364 588364 0 0.0
lock-mtd LP_CC2652R7 (read only) 637115 637115 0 0.0
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 537884 0 0.0
pump-app LP_CC2652R7 (read only) 669083 669083 0 0.0
(read/write) 173788 173788 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581620 581620 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659655 659655 0 0.0
(read/write) 183320 183320 0 0.0
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574292 0 0.0
shell LP_CC2652R7 (read only) 686470 686470 0 0.0
(read/write) 159912 159912 0 0.0
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 109598 109598 0 0.0
.text 576560 576560 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606578 606570 -8 -0.0
.app_xip_area 465076 465068 -8 -0.0
.bss 84432 84432 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603678 603678 0 0.0
.app_xip_area 462032 462032 0 0.0
.bss 84608 84608 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 611382 0 0.0
.app_xip_area 470808 470808 0 0.0
.bss 83616 83616 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919248 919248 0 0.0
(read/write) 133432 133432 0 0.0
.bss 131320 131320 0 0.0
.data 2112 2112 0 0.0
.text 919240 919240 0 0.0
BRD4161A+rpc (read only) 953412 953412 0 0.0
(read/write) 150124 150124 0 0.0
.bss 147808 147808 0 0.0
.data 2316 2316 0 0.0
.text 953404 953404 0 0.0
BRD4161A+rs911x (read only) 794364 794364 0 0.0
(read/write) 129716 129716 0 0.0
.bss 127596 127596 0 0.0
.data 2120 2120 0 0.0
.text 794356 794356 0 0.0
lock-app BRD4161A+wf200 (read only) 962652 962668 16 0.0
(read/write) 130060 130060 0 0.0
.bss 127972 127972 0 0.0
.data 2088 2088 0 0.0
.text 962644 962660 16 0.0
window-app BRD4161A (read only) 904304 904304 0 0.0
(read/write) 133512 133512 0 0.0
.bss 131400 131400 0 0.0
.data 2108 2108 0 0.0
.text 904296 904296 0 0.0
esp32 all-clusters-app c3devkit (read only) 1010982 1010984 2 0.0
(read/write) 1482794 1482794 0 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213240 213240 0 0.0
.flash.text 1010982 1010984 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065439 1065439 0 0.0
(read/write) 484896 484896 0 0.0
.dram0.bss 74936 74936 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243740 243740 0 0.0
.flash.text 1060055 1060055 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657264 657264 0 0.0
.bss 69748 69748 0 0.0
.data 2028 2028 0 0.0
.text 579688 579688 0 0.0
lock k32w061+release (read/write) 718860 718860 0 0.0
.bss 70180 70180 0 0.0
.data 2000 2000 0 0.0
.text 640880 640880 0 0.0
linux all-clusters-app debug (read only) 2918857 2918857 0 0.0
(read/write) 188560 188560 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84520 84520 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258205 258205 0 0.0
.text 2485026 2485026 0 0.0
all-clusters-minimal-app debug (read only) 2769193 2769193 0 0.0
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258621 258621 0 0.0
.text 2337458 2337458 0 0.0
bridge-app debug+rpc (read only) 2247553 2247553 0 0.0
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191040 191040 0 0.0
.text 1896530 1896530 0 0.0
chip-tool debug (read only) 9815973 9815973 0 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506805 506805 0 0.0
.text 7868549 7868549 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9563860 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468788 468788 0 0.0
.text 7518980 7518980 0 0.0
lighting-app debug+rpc (read only) 2497497 2497497 0 0.0
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207144 207144 0 0.0
.text 2122162 2122162 0 0.0
lock-app debug (read only) 2443465 2443465 0 0.0
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221192 221192 0 0.0
.text 2059074 2059074 0 0.0
ota-provider-app debug (read only) 2281729 2281729 0 0.0
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197336 197336 0 0.0
.text 1923202 1923202 0 0.0
ota-requestor-app debug (read only) 2329289 2329289 0 0.0
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199520 199520 0 0.0
.text 1964738 1964738 0 0.0
shell debug (read only) 2599937 2599937 0 0.0
(read/write) 219416 219416 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229778 229778 0 0.0
.text 2210866 2210866 0 0.0
thermostat-no-ble arm64 (read only) 2557916 2557916 0 0.0
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161332 161332 0 0.0
.text 2158912 2158912 0 0.0
tv-app debug (read only) 3050873 3050873 0 0.0
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242720 242720 0 0.0
.text 2622370 2622370 0 0.0
tv-casting-app debug (read only) 5349977 5349977 0 0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342368 342368 0 0.0
.text 4656338 4656338 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2432808 0 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1395452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195771 1196343 572 0.0
bss 141591 141619 28 0.0
rodata 155316 155616 300 0.2
text 819892 820156 264 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1143531 0 0.0
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 791972 791972 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156987 1156987 0 0.0
bss 144165 144165 0 0.0
rodata 122356 122356 0 0.0
text 811544 811544 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1125051 1125051 0 0.0
bss 144406 144406 0 0.0
rodata 113948 113948 0 0.0
text 787316 787316 0 0.0
nrf52840dongle_nrf52840 (read/write) 1064023 1064023 0 0.0
bss 151396 151396 0 0.0
rodata 91504 91504 0 0.0
text 740064 740064 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1060646 1060646 0 0.0
bss 140536 140536 0 0.0
rodata 114764 114764 0 0.0
text 724276 724276 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1108763 1108763 0 0.0
bss 134093 134093 0 0.0
rodata 138956 138956 0 0.0
text 756908 756908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1012690 1012690 0 0.0
bss 130496 130496 0 0.0
rodata 131424 131424 0 0.0
text 669696 669692 -4 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1069971 1069971 0 0.0
bss 134076 134076 0 0.0
rodata 115724 115724 0 0.0
text 741284 741284 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062555 1062555 0 0.0
bss 133853 133853 0 0.0
rodata 114596 114596 0 0.0
text 735272 735272 0 0.0
p6 all-clusters-app default (read/write) 2549328 2549328 0 0.0
.bss 143416 143416 0 0.0
.data 2832 2832 0 0.0
.text 1507592 1507592 0 0.0
all-clusters-minimal-app default (read/write) 2494128 2494128 0 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452392 1452392 0 0.0
light-app default (read/write) 2425576 2425576 0 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383840 1383840 0 0.0
lock-app default (read/write) 2445968 2445968 0 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404232 1404232 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786716 786724 8 0.0
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556632 556636 4 0.0
lighting-app tlsr9518adk80d (read/write) 806728 806728 0 0.0
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573346 573350 4 0.0

@andy31415 andy31415 merged commit 2032dfc into project-chip:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@andy31415 andy31415 Awaiting requested review from andy31415

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre SVE Testing: TC-I-3.2 step 4 giving 0x85 error for all-clusters-app on nrfconnect
3 participants
@kkasperczyk-no @andy31415 @Damian-Nordic