Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the logic in ExchangeContext::OnSessionReleased. #19383

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Clarify the logic in ExchangeContext::OnSessionReleased. #19383

merged 2 commits into from
Jun 10, 2022

Commits on Jun 9, 2022

  1. Clarify the logic in ExchangeContext::OnSessionReleased. 

    It was not clear who was responsible for releasing various refcounts.
Improve the code and documentation to make it clearer what's going on,
and to avoid the two calls into DoClose in the "waiting for response"
case.

Addresses a problem that was mentioned in
project-chip#19359
    @bzbarsky-apple
    bzbarsky-apple committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4f268f3 View commit details
    Browse the repository at this point in the history

  2. Clarify comments

    @bzbarsky-apple
    bzbarsky-apple committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    1aa81d7 View commit details
    Browse the repository at this point in the history