Determine build tools & args based on yocto sdk env setup script #19369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaqiangZhu-nxp
force-pushed
the
imx_support_multi_SDK_0609
branch
from
7abeaab
to
71391bc
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #19369: Size comparison from e81917b to 71391bc Increases (1 build for cc13x2_26x2)
Decreases (2 builds for esp32, nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
FaqiangZhu-nxp
force-pushed
the
imx_support_multi_SDK_0609
branch
from
71391bc
to
0cc9127
Compare
|
PR #19369: Size comparison from 47a51ce to 0cc9127 Increases (2 builds for telink)
Decreases (2 builds for cyw30739, esp32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 9, 2022
andy31415
reviewed
Jun 9, 2022
FaqiangZhu-nxp
force-pushed
the
imx_support_multi_SDK_0609
branch
from
0cc9127
to
cabf369
Compare
|
PR #19369: Size comparison from c1e1d01 to cabf369 Increases (2 builds for telink)
Decreases (1 build for cyw30739)
Full report (23 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
FaqiangZhu-nxp
force-pushed
the
imx_support_multi_SDK_0609
branch
from
cabf369
to
fc71d50
Compare
|
PR #19369: Size comparison from c1e1d01 to fc71d50 Increases (2 builds for telink)
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
FaqiangZhu-nxp
force-pushed
the
imx_support_multi_SDK_0609
branch
from
fc71d50
to
17eb38b
Compare
|
PR #19369: Size comparison from c1e1d01 to 17eb38b Increases (3 builds for efr32, esp32, telink)
Decreases (1 build for nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
FaqiangZhu-nxp
force-pushed
the
imx_support_multi_SDK_0609
branch
from
17eb38b
to
c95a7be
Compare
|
PR #19369: Size comparison from 075dd3e to c95a7be Decreases (1 build for k32w)
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
FaqiangZhu-nxp
force-pushed
the
imx_support_multi_SDK_0609
branch
2 times, most recently
from
38b750a
to
d15553f
Compare
|
PR #19369: Size comparison from 075dd3e to d15553f Increases (3 builds for cyw30739, telink)
Decreases (1 build for cc13x2_26x2)
Full report (28 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
|
|
Hi, @andy31415 , based on your comments, I made some modification. Now a problem is encountered during CI test: in the "scripts/build/test.py", I set the env IMX_SDK_ROOT with a value of "IMX_SDK_ROOT", this is not a valid path, the env setup script cannot be found, and the envs should be found in env setup script cannot be found, exceptions are thrown and the tests fails. What should I do with this condition? |
Previously, the yocto SDK for i.MX 8M devices of version 5.10-hardknott
is the only one to be supported, the build tools and arguments are
hard-coded.
Now to support different versions of SDKs for different devices, read
from the SDK env setup script to get info about build tools and
arguments.
env PKG_CONFIG_PATH is removed because with the gn arg sysroot correctly
set the package config path info can be retrieved automatically in the
build system.
For debug build, to eliminate warnings, optimize_debug is set.
With this patch applied, example commands to build the binaries are:
export IMX_SDK_ROOT=/opt/fsl-imx-xwayland/5.15-kirkstone
source scripts/activate.sh
./scripts/build/build_examples.py --target imx-all-clusters-app build
./scripts/build/build_examples.py --target \
imx-all-clusters-app-release build
./scripts/examples/imxlinux_example.sh \
examples/all-clusters-app/linux \
examples/all-clusters-app/linux/out/aarch64
./scripts/examples/imxlinux_example.sh \
examples/all-clusters-app/linux \
examples/all-clusters-app/linux/out/aarch64 debug
if the value of shell env IMX_SDK_ROOT is "IMX_SDK_ROOT", then it is in
CI test, use the default value from 5.10 5.10-hardknott to pass the
test.
Change-Id: I3e2a30f56a95bb13cbf43855c8edeeb9e63469eb
Signed-off-by: faqiang.zhu <faqiang.zhu@nxp.com>
Restyled by shellharden
Restyled by shfmt
Restyled by autopep8
FaqiangZhu-nxp
force-pushed
the
imx_support_multi_SDK_0609
branch
from
d15553f
to
07c46bc
Compare
|
PR #19369: Size comparison from 09f3e4a to 07c46bc Increases (1 build for cyw30739)
Decreases (2 builds for telink)
Full report (28 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the yocto SDK for i.MX 8M devices of version 5.10-hardknott
is the only one to be supported, the build tools and arguments are
hard-coded.
Now to support different versions of SDKs for different devices, read
from the SDK env setup script to get info about build tools and
arguments.
env PKG_CONFIG_PATH is removed because with the gn arg sysroot correctly
set the package config path info can be retrieved automatically in the
build system.
For debug build, to eliminate warnings, optimize_debug is set.
With this patch applied, example commands to build the binaries are:
export IMX_SDK_ROOT=/opt/fsl-imx-xwayland/5.15-kirkstone
source scripts/activate.sh
./scripts/build/build_examples.py --target imx-all-clusters-app build
./scripts/build/build_examples.py --target imx-all-clusters-app-release build
./scripts/examples/imxlinux_example.sh examples/all-clusters-app/linux examples/all-clusters-app/linux/out/aarch64
./scripts/examples/imxlinux_example.sh examples/all-clusters-app/linux examples/all-clusters-app/linux/out/aarch64 debug