Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure session ref count: Address left over comment for #17599 #19299

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Secure session ref count: Address left over comment for #17599 #19299

merged 1 commit into from
Jun 8, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Jun 8, 2022

Problem

There are some comment from @bzbarsky-apple after #17599 being merged. Mainly about comments

Change overview

Update code and comment regarding suggestions

Testing

Passed unit-tests

@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #19299: Size comparison from fbce051 to 29ba55c

Increases (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fbce051 29ba55c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690303 690359 56 0.0
.rodata 112311 112343 32 0.0
.text 577680 577704 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640919 640975 56 0.0
.rodata 89351 89383 32 0.0
.text 551248 551272 24 0.0
lock-ftd LP_CC2652R7 (read only) 683815 683879 64 0.0
.rodata 98167 98207 40 0.0
.text 585164 585188 24 0.0
lock-mtd LP_CC2652R7 (read only) 633231 633295 64 0.0
.rodata 98055 98095 40 0.0
.text 534684 534708 24 0.0
pump-app LP_CC2652R7 (read only) 665267 665323 56 0.0
.rodata 86347 86387 40 0.0
.text 578436 578452 16 0.0
pump-controller-app LP_CC2652R7 (read only) 655843 655907 64 0.0
.rodata 84235 84275 40 0.0
.text 571124 571148 24 0.0
shell LP_CC2652R7 (read only) 682582 682638 56 0.0
.rodata 108910 108942 32 0.0
.text 573360 573384 24 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599366 599430 64 0.0
.app_xip_area 459292 459356 64 0.0
efr32 lighting-app BRD4161A (read only) 915256 915304 48 0.0
.text 915248 915296 48 0.0
BRD4161A+rpc (read only) 949476 949524 48 0.0
.text 949468 949516 48 0.0
BRD4161A+rs911x (read only) 790540 790588 48 0.0
.text 790532 790580 48 0.0
lock-app BRD4161A+wf200 (read only) 958716 958780 64 0.0
.text 958708 958772 64 0.0
window-app BRD4161A (read only) 900328 900376 48 0.0
.text 900320 900368 48 0.0
esp32 all-clusters-app c3devkit (read only) 1008060 1008080 20 0.0
(read/write) 1481914 1481954 40 0.0
.flash.rodata 212568 212608 40 0.0
.flash.text 1008060 1008080 20 0.0
m5stack (read only) 1062859 1062863 4 0.0
(read/write) 484048 484080 32 0.0
.flash.rodata 243076 243108 32 0.0
.flash.text 1057475 1057479 4 0.0
k32w light k32w061+release (read/write) 653944 653976 32 0.0
.text 576088 576120 32 0.0
lock k32w061+release (read/write) 715036 715100 64 0.0
.text 636768 636832 64 0.0
linux all-clusters-app debug (read only) 2893417 2893513 96 0.0
.rodata 255549 255613 64 0.0
.text 2463346 2463378 32 0.0
all-clusters-minimal-app debug (read only) 2754929 2754993 64 0.0
.rodata 256861 256893 32 0.0
.text 2325554 2325586 32 0.0
bridge-app debug+rpc (read only) 2198961 2199025 64 0.0
.rodata 187904 187936 32 0.0
.text 1852146 1852178 32 0.0
chip-tool debug (read only) 9737285 9737381 96 0.0
.rodata 505405 505469 64 0.0
.text 7829877 7829909 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9475052 64 0.0
.rodata 467548 467596 48 0.0
.text 7470420 7470436 16 0.0
lighting-app debug+rpc (read only) 2483377 2483441 64 0.0
.rodata 205480 205512 32 0.0
.text 2110306 2110338 32 0.0
lock-app debug (read only) 2429329 2429377 48 0.0
.rodata 219496 219528 32 0.0
.text 2047234 2047250 16 0.0
ota-provider-app debug (read only) 2204761 2204841 80 0.0
.rodata 192024 192088 64 0.0
.text 1853058 1853074 16 0.0
ota-requestor-app debug (read only) 2266409 2266473 64 0.0
.rodata 195392 195424 32 0.0
.text 1907282 1907314 32 0.0
shell debug (read only) 2585089 2585137 48 0.0
.rodata 228146 228178 32 0.0
.text 2198322 2198338 16 0.0
thermostat-no-ble arm64 (read only) 2544956 2545004 48 0.0
.rodata 160196 160228 32 0.0
.text 2147776 2147792 16 0.0
tv-app debug (read only) 3031449 3031497 48 0.0
.rodata 240736 240768 32 0.0
.text 2605650 2605666 16 0.0
tv-casting-app debug (read only) 5335041 5335137 96 0.0
.rodata 340576 340640 64 0.0
.text 4643986 4644018 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2429848 2429944 96 0.0
.text 1392492 1392588 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192179 1192231 52 0.0
rodata 154628 154664 36 0.0
text 817264 817284 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139891 1139943 52 0.0
rodata 131124 131160 36 0.0
text 789312 789332 20 0.0
p6 all-clusters-app default (read/write) 2544880 2544928 48 0.0
.text 1503144 1503192 48 0.0
all-clusters-minimal-app default (read/write) 2489744 2489800 56 0.0
.text 1448008 1448064 56 0.0
light-app default (read/write) 2421656 2421704 48 0.0
.text 1379920 1379968 48 0.0
lock-app default (read/write) 2441992 2442040 48 0.0
.text 1400256 1400304 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781940 781992 52 0.0
text 552812 552830 18 0.0
lighting-app tlsr9518adk80d (read/write) 801952 802004 52 0.0
text 569532 569550 18 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section fbce051 29ba55c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161552 161496 -56 -0.0
lock-ftd LP_CC2652R7 (read/write) 159104 159040 -64 -0.0
pump-app LP_CC2652R7 (read/write) 178564 178508 -56 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188092 188028 -64 -0.0
shell LP_CC2652R7 (read/write) 164768 164712 -56 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fbce051 29ba55c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690303 690359 56 0.0
(read/write) 161552 161496 -56 -0.0
.bss 74748 74748 0 0.0
.data 3392 3392 0 0.0
.rodata 112311 112343 32 0.0
.text 577680 577704 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640919 640975 56 0.0
(read/write) 158220 158220 0 0.0
.bss 73972 73972 0 0.0
.data 3332 3332 0 0.0
.rodata 89351 89383 32 0.0
.text 551248 551272 24 0.0
lock-ftd LP_CC2652R7 (read only) 683815 683879 64 0.0
(read/write) 159104 159040 -64 -0.0
.bss 72700 72700 0 0.0
.data 3256 3256 0 0.0
.rodata 98167 98207 40 0.0
.text 585164 585188 24 0.0
lock-mtd LP_CC2652R7 (read only) 633231 633295 64 0.0
(read/write) 145808 145808 0 0.0
.bss 68436 68436 0 0.0
.data 3256 3256 0 0.0
.rodata 98055 98095 40 0.0
.text 534684 534708 24 0.0
pump-app LP_CC2652R7 (read only) 665267 665323 56 0.0
(read/write) 178564 178508 -56 -0.0
.bss 72844 72844 0 0.0
.data 3292 3292 0 0.0
.rodata 86347 86387 40 0.0
.text 578436 578452 16 0.0
pump-controller-app LP_CC2652R7 (read only) 655843 655907 64 0.0
(read/write) 188092 188028 -64 -0.0
.bss 72948 72948 0 0.0
.data 3252 3252 0 0.0
.rodata 84235 84275 40 0.0
.text 571124 571148 24 0.0
shell LP_CC2652R7 (read only) 682582 682638 56 0.0
(read/write) 164768 164712 -56 -0.0
.bss 77044 77044 0 0.0
.data 3396 3396 0 0.0
.rodata 108910 108942 32 0.0
.text 573360 573384 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602546 602546 0 0.0
.app_xip_area 461492 461492 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599630 599630 0 0.0
.app_xip_area 458440 458440 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599366 599430 64 0.0
.app_xip_area 459292 459356 64 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915256 915304 48 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2088 2088 0 0.0
.text 915248 915296 48 0.0
BRD4161A+rpc (read only) 949476 949524 48 0.0
(read/write) 149956 149956 0 0.0
.bss 147664 147664 0 0.0
.data 2292 2292 0 0.0
.text 949468 949516 48 0.0
BRD4161A+rs911x (read only) 790540 790588 48 0.0
(read/write) 129548 129548 0 0.0
.bss 127452 127452 0 0.0
.data 2096 2096 0 0.0
.text 790532 790580 48 0.0
lock-app BRD4161A+wf200 (read only) 958716 958780 64 0.0
(read/write) 128340 128340 0 0.0
.bss 126276 126276 0 0.0
.data 2064 2064 0 0.0
.text 958708 958772 64 0.0
window-app BRD4161A (read only) 900328 900376 48 0.0
(read/write) 133352 133352 0 0.0
.bss 131264 131264 0 0.0
.data 2084 2084 0 0.0
.text 900320 900368 48 0.0
esp32 all-clusters-app c3devkit (read only) 1008060 1008080 20 0.0
(read/write) 1481914 1481954 40 0.0
.dram0.bss 69256 69256 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212568 212608 40 0.0
.flash.text 1008060 1008080 20 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062859 1062863 4 0.0
(read/write) 484048 484080 32 0.0
.dram0.bss 74776 74776 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243076 243108 32 0.0
.flash.text 1057475 1057479 4 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653944 653976 32 0.0
.bss 70052 70052 0 0.0
.data 2004 2004 0 0.0
.text 576088 576120 32 0.0
lock k32w061+release (read/write) 715036 715100 64 0.0
.bss 70492 70492 0 0.0
.data 1976 1976 0 0.0
.text 636768 636832 64 0.0
linux all-clusters-app debug (read only) 2893417 2893513 96 0.0
(read/write) 180056 180056 0 0.0
.bss 87872 87872 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255549 255613 64 0.0
.text 2463346 2463378 32 0.0
all-clusters-minimal-app debug (read only) 2754929 2754993 64 0.0
(read/write) 171672 171672 0 0.0
.bss 87040 87040 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256861 256893 32 0.0
.text 2325554 2325586 32 0.0
bridge-app debug+rpc (read only) 2198961 2199025 64 0.0
(read/write) 149560 149560 0 0.0
.bss 74528 74528 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187904 187936 32 0.0
.text 1852146 1852178 32 0.0
chip-tool debug (read only) 9737285 9737381 96 0.0
(read/write) 608064 608064 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575240 575240 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505405 505469 64 0.0
.text 7829877 7829909 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9475052 64 0.0
(read/write) 674321 674321 0 0.0
.bss 43729 43729 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610696 610696 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467548 467596 48 0.0
.text 7470420 7470436 16 0.0
lighting-app debug+rpc (read only) 2483377 2483441 64 0.0
(read/write) 155168 155168 0 0.0
.bss 76352 76352 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205480 205512 32 0.0
.text 2110306 2110338 32 0.0
lock-app debug (read only) 2429329 2429377 48 0.0
(read/write) 150304 150304 0 0.0
.bss 75072 75072 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219496 219528 32 0.0
.text 2047234 2047250 16 0.0
ota-provider-app debug (read only) 2204761 2204841 80 0.0
(read/write) 143296 143296 0 0.0
.bss 74528 74528 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 192024 192088 64 0.0
.text 1853058 1853074 16 0.0
ota-requestor-app debug (read only) 2266409 2266473 64 0.0
(read/write) 146344 146344 0 0.0
.bss 75296 75296 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195392 195424 32 0.0
.text 1907282 1907314 32 0.0
shell debug (read only) 2585089 2585137 48 0.0
(read/write) 203232 203232 0 0.0
.bss 118760 118760 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228146 228178 32 0.0
.text 2198322 2198338 16 0.0
thermostat-no-ble arm64 (read only) 2544956 2545004 48 0.0
(read/write) 183153 183153 0 0.0
.bss 91457 91457 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82168 82168 0 0.0
.dynamic 528 528 0 0.0
.got 5000 5000 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160196 160228 32 0.0
.text 2147776 2147792 16 0.0
tv-app debug (read only) 3031449 3031497 48 0.0
(read/write) 281936 281936 0 0.0
.bss 192648 192648 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 240736 240768 32 0.0
.text 2605650 2605666 16 0.0
tv-casting-app debug (read only) 5335041 5335137 96 0.0
(read/write) 224000 224000 0 0.0
.bss 80168 80168 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135168 135168 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340576 340640 64 0.0
.text 4643986 4644018 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429848 2429944 96 0.0
.bss 202724 202724 0 0.0
.data 5872 5872 0 0.0
.text 1392492 1392588 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192179 1192231 52 0.0
bss 141378 141378 0 0.0
rodata 154628 154664 36 0.0
text 817264 817284 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139891 1139943 52 0.0
bss 140595 140595 0 0.0
rodata 131124 131160 36 0.0
text 789312 789332 20 0.0
p6 all-clusters-app default (read/write) 2544880 2544928 48 0.0
.bss 137208 137208 0 0.0
.data 2808 2808 0 0.0
.text 1503144 1503192 48 0.0
all-clusters-minimal-app default (read/write) 2489744 2489800 56 0.0
.bss 136416 136416 0 0.0
.data 2752 2752 0 0.0
.text 1448008 1448064 56 0.0
light-app default (read/write) 2421656 2421704 48 0.0
.bss 129520 129520 0 0.0
.data 2600 2600 0 0.0
.text 1379920 1379968 48 0.0
lock-app default (read/write) 2441992 2442040 48 0.0
.bss 129344 129344 0 0.0
.data 2576 2576 0 0.0
.text 1400256 1400304 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781940 781992 52 0.0
bss 70652 70652 0 0.0
noinit 40416 40416 0 0.0
text 552812 552830 18 0.0
lighting-app tlsr9518adk80d (read/write) 801952 802004 52 0.0
bss 70904 70904 0 0.0
noinit 40416 40416 0 0.0
text 569532 569550 18 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick follow-up!

@bzbarsky-apple bzbarsky-apple merged commit 7d125dc into project-chip:master Jun 8, 2022
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@kghost @mkardous-silabs
Secure session ref count: Address left over comment for project-chip#…
e9820f2 
…17599 (project-chip#19299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @andy31415 @bzbarsky-apple