-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device info provider in more NRF locations, fix null pointer crash for storage info #18847
Conversation
PR #18847: Size comparison from b5a967c to e92d4f4 Increases above 0.2%:
Increases (9 builds for nrfconnect)
Full report (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the same implementation for light-switch and window-covering examples as well? We would like to keep all examples code consistent.
Updated These apps are not included in build_examples.py so compile testing will be done by CI (if at all) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Problem
Need DeviceInfoProvider in more example apps for CSG to validate.
Storage is only available post server init.
Change overview
Fixes initialization order in light app.
Adds DeviceInfoProvider in more apps.
Testing
Compilation testing.
Explicitly tested user label read/write capability using the all-clusters-app.