Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android/tv-casting-app: Fixing commissioning and command delivery #18636

Merged
merged 2 commits into from
May 20, 2022
Merged

Android/tv-casting-app: Fixing commissioning and command delivery #18636

merged 2 commits into from
May 20, 2022

Conversation

sharadb-amazon
Copy link
Contributor

Problem

Android tv-casting-app failed to commission or send Content Launch commands

Change overview

Fixes that would skip starting the chip server a second time and would apply lock before calling the SDK's openBasicCommissioningWindow function

Testing

Built and tested by deploying the app to an Android phone and testing against a tv-app running on Raspberry Pi.

@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited
Loading

PR #18636: Size comparison from fca1b6d to d093b44

Increases (1 build for linux)
platform target config section fca1b6d d093b44 change % change
linux tv-casting-app debug (read only) 5416553 5416585 32 0.0
.text 4717490 4717522 32 0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fca1b6d d093b44 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667211 667211 0 0.0
(read/write) 183468 183468 0 0.0
.bss 73660 73660 0 0.0
.data 3404 3404 0 0.0
.rodata 100051 100051 0 0.0
.text 566932 566932 0 0.0
lock-ftd LP_CC2652R7 (read only) 677215 677215 0 0.0
(read/write) 165440 165440 0 0.0
.bss 72692 72692 0 0.0
.data 3236 3236 0 0.0
.rodata 94831 94831 0 0.0
.text 581900 581900 0 0.0
lock-mtd LP_CC2652R7 (read only) 626039 626039 0 0.0
(read/write) 145524 145524 0 0.0
.bss 68428 68428 0 0.0
.data 3236 3236 0 0.0
.rodata 94719 94719 0 0.0
.text 530828 530828 0 0.0
pump-app LP_CC2652R7 (read only) 659443 659443 0 0.0
(read/write) 184492 184492 0 0.0
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 79347 79347 0 0.0
.text 579616 579616 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653947 653947 0 0.0
(read/write) 189796 189796 0 0.0
.bss 73012 73012 0 0.0
.data 3232 3232 0 0.0
.rodata 83459 83459 0 0.0
.text 570008 570008 0 0.0
shell LP_CC2652R7 (read only) 660278 660278 0 0.0
(read/write) 185960 185960 0 0.0
.bss 76020 76020 0 0.0
.data 3408 3408 0 0.0
.rodata 97006 97006 0 0.0
.text 563048 563048 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 625230 625230 0 0.0
.app_xip_area 528844 528844 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628034 628034 0 0.0
.app_xip_area 533104 533104 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570986 570986 0 0.0
.app_xip_area 466340 466340 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917676 917676 0 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 917668 917668 0 0.0
BRD4161A+rpc (read only) 951848 951848 0 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 951840 951840 0 0.0
BRD4161A+rs911x (read only) 791204 791204 0 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 791196 791196 0 0.0
lock-app BRD4161A+wf200 (read only) 947200 947200 0 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 947192 947192 0 0.0
window-app BRD4161A (read only) 897788 897788 0 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897780 897780 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000948 1000948 0 0.0
(read/write) 1477874 1477874 0 0.0
.dram0.bss 68216 68216 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 209600 209600 0 0.0
.flash.text 1000948 1000948 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1056219 1056219 0 0.0
(read/write) 479868 479868 0 0.0
.dram0.bss 73736 73736 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 239936 239936 0 0.0
.flash.text 1050835 1050835 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682716 682716 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 598772 598772 0 0.0
lock k32w061+release (read/write) 729260 729260 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 644924 644924 0 0.0
linux all-clusters-app debug (read only) 2751209 2751209 0 0.0
(read/write) 175936 175936 0 0.0
.bss 85088 85088 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82616 82616 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 240797 240797 0 0.0
.text 2336146 2336146 0 0.0
bridge-app debug+rpc (read only) 2033633 2033633 0 0.0
(read/write) 147736 147736 0 0.0
.bss 72864 72864 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65352 65352 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169129 169129 0 0.0
.text 1707506 1707506 0 0.0
chip-tool debug (read only) 9305845 9305845 0 0.0
(read/write) 579128 579128 0 0.0
.bss 23936 23936 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 547752 547752 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 480989 480989 0 0.0
.text 7498069 7498069 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9077716 9077716 0 0.0
(read/write) 645249 645249 0 0.0
.bss 42225 42225 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583000 583000 0 0.0
.dynamic 560 560 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 445844 445844 0 0.0
.text 7170020 7170020 0 0.0
lighting-app debug+rpc (read only) 2328113 2328113 0 0.0
(read/write) 153152 153152 0 0.0
.bss 74656 74656 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70696 70696 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188137 188137 0 0.0
.text 1973746 1973746 0 0.0
lock-app debug (read only) 2241561 2241561 0 0.0
(read/write) 147864 147864 0 0.0
.bss 73344 73344 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67256 67256 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198745 198745 0 0.0
.text 1882978 1882978 0 0.0
ota-provider-app debug (read only) 2063553 2063553 0 0.0
(read/write) 140944 140944 0 0.0
.bss 72800 72800 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60568 60568 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179360 179360 0 0.0
.text 1725746 1725746 0 0.0
ota-requestor-app debug (read only) 2092473 2092473 0 0.0
(read/write) 143752 143752 0 0.0
.bss 73472 73472 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62632 62632 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175392 175392 0 0.0
.text 1757170 1757170 0 0.0
shell debug (read only) 2566969 2566969 0 0.0
(read/write) 199800 199800 0 0.0
.bss 115784 115784 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76880 76880 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 221778 221778 0 0.0
.text 2184306 2184306 0 0.0
thermostat-no-ble arm64 (read only) 2354172 2354172 0 0.0
(read/write) 176305 176305 0 0.0
.bss 87617 87617 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79360 79360 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147356 147356 0 0.0
.text 1977952 1977952 0 0.0
tv-app debug (read only) 2854489 2854489 0 0.0
(read/write) 278784 278784 0 0.0
.bss 190776 190776 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 77064 77064 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221169 221169 0 0.0
.text 2451266 2451266 0 0.0
tv-casting-app debug (read only) 5416553 5416585 32 0.0
(read/write) 225024 225024 0 0.0
.bss 78360 78360 0 0.0
.data 2368 2368 0 0.0
.data.rel.ro 138064 138064 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339713 339713 0 0.0
.text 4717490 4717522 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420448 2420448 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1383092 1383092 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180803 1180803 0 0.0
bss 138388 138388 0 0.0
rodata 152780 152780 0 0.0
text 810768 810768 0 0.0
p6 all-clusters-app default (read/write) 2538776 2538776 0 0.0
.bss 136184 136184 0 0.0
.data 2808 2808 0 0.0
.text 1497040 1497040 0 0.0
light-app default (read/write) 2425240 2425240 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1383504 1383504 0 0.0
lock-app default (read/write) 2435928 2435928 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1394192 1394192 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782596 782596 0 0.0
bss 70616 70616 0 0.0
noinit 40416 40416 0 0.0
text 553500 553500 0 0.0
lighting-app tlsr9518adk80d (read/write) 802676 802676 0 0.0
bss 70872 70872 0 0.0
noinit 40416 40416 0 0.0
text 570266 570266 0 0.0

@restyled-io restyled-io bot mentioned this pull request May 20, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR #18636: Size comparison from fd84c37 to 8b00405

Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fd84c37 8b00405 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666483 666483 0 0.0
(read/write) 184204 184204 0 0.0
.bss 73668 73668 0 0.0
.data 3404 3404 0 0.0
.rodata 99611 99611 0 0.0
.text 566644 566644 0 0.0
lock-ftd LP_CC2652R7 (read only) 676315 676315 0 0.0
(read/write) 166340 166340 0 0.0
.bss 72692 72692 0 0.0
.data 3236 3236 0 0.0
.rodata 94379 94379 0 0.0
.text 581452 581452 0 0.0
lock-mtd LP_CC2652R7 (read only) 625139 625139 0 0.0
(read/write) 145524 145524 0 0.0
.bss 68428 68428 0 0.0
.data 3236 3236 0 0.0
.rodata 94267 94267 0 0.0
.text 530380 530380 0 0.0
pump-app LP_CC2652R7 (read only) 659595 659595 0 0.0
(read/write) 184340 184340 0 0.0
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 79371 79371 0 0.0
.text 579744 579744 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654083 654083 0 0.0
(read/write) 189660 189660 0 0.0
.bss 73012 73012 0 0.0
.data 3232 3232 0 0.0
.rodata 83475 83475 0 0.0
.text 570128 570128 0 0.0
shell LP_CC2652R7 (read only) 659562 659562 0 0.0
(read/write) 186684 186684 0 0.0
.bss 76028 76028 0 0.0
.data 3408 3408 0 0.0
.rodata 96578 96578 0 0.0
.text 562760 562760 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624306 624306 0 0.0
.app_xip_area 527920 527920 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627126 627126 0 0.0
.app_xip_area 532196 532196 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571038 571038 0 0.0
.app_xip_area 466392 466392 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916652 916652 0 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 916644 916644 0 0.0
BRD4161A+rpc (read only) 950824 950824 0 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 950816 950816 0 0.0
BRD4161A+rs911x (read only) 790084 790084 0 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 790076 790076 0 0.0
lock-app BRD4161A+wf200 (read only) 946204 946204 0 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 946196 946196 0 0.0
window-app BRD4161A (read only) 897924 897924 0 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897916 897916 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000458 1000458 0 0.0
(read/write) 1477442 1477442 0 0.0
.dram0.bss 68232 68232 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 209136 209136 0 0.0
.flash.text 1000458 1000458 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1055827 1055827 0 0.0
(read/write) 479452 479452 0 0.0
.dram0.bss 73752 73752 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 239504 239504 0 0.0
.flash.text 1050443 1050443 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682204 682204 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 598260 598260 0 0.0
lock k32w061+release (read/write) 728352 728352 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 644016 644016 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9155476 9155476 0 0.0
(read/write) 645297 645297 0 0.0
.bss 42225 42225 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583048 583048 0 0.0
.dynamic 560 560 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 446036 446036 0 0.0
.text 7247540 7247540 0 0.0
thermostat-no-ble arm64 (read only) 2354116 2354116 0 0.0
(read/write) 176321 176321 0 0.0
.bss 87617 87617 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79384 79384 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147332 147332 0 0.0
.text 1977904 1977904 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418432 2418432 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1381076 1381076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180075 1180075 0 0.0
bss 138400 138400 0 0.0
rodata 152340 152340 0 0.0
text 810484 810484 0 0.0
p6 all-clusters-app default (read/write) 2537888 2537888 0 0.0
.bss 136200 136200 0 0.0
.data 2808 2808 0 0.0
.text 1496152 1496152 0 0.0
light-app default (read/write) 2424104 2424104 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1382368 1382368 0 0.0
lock-app default (read/write) 2434792 2434792 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1393056 1393056 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781572 781572 0 0.0
bss 70616 70616 0 0.0
noinit 40416 40416 0 0.0
text 552938 552938 0 0.0
lighting-app tlsr9518adk80d (read/write) 801644 801644 0 0.0
bss 70872 70872 0 0.0
noinit 40416 40416 0 0.0
text 569704 569704 0 0.0

@chrisdecenzo chrisdecenzo merged commit 3e40014 into project-chip:master May 20, 2022
@sharadb-amazon sharadb-amazon mentioned this pull request May 21, 2022
Merged
@sharadb-amazon sharadb-amazon deleted the droid-20220519 branch June 19, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@andy31415 andy31415 andy31415 approved these changes

@Byungjoo-Lee Byungjoo-Lee Byungjoo-Lee approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@lazarkov lazarkov Awaiting requested review from lazarkov

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharadb-amazon @andy31415 @Byungjoo-Lee @chrisdecenzo @bzbarsky-apple