-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android/tv-casting-app: Fixing commissioning and command delivery #18636
Merged
chrisdecenzo
merged 2 commits into
project-chip:master
from
sharadb-amazon:droid-20220519
May 20, 2022
Merged
Android/tv-casting-app: Fixing commissioning and command delivery #18636
chrisdecenzo
merged 2 commits into
project-chip:master
from
sharadb-amazon:droid-20220519
May 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
LuDuda,
mlepage-google and
mrjerryjohns
May 19, 2022 19:27
pullapprove
bot
requested review from
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
May 19, 2022 19:27
andy31415
reviewed
May 19, 2022
examples/tv-casting-app/tv-casting-common/src/CastingServer.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
May 19, 2022
examples/tv-casting-app/android/App/app/src/main/jni/cpp/TvCastingApp-JNI.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
May 19, 2022
examples/tv-casting-app/android/App/app/src/main/jni/cpp/TvCastingApp-JNI.cpp
Outdated
Show resolved
Hide resolved
chrisdecenzo
approved these changes
May 19, 2022
PR #18636: Size comparison from fca1b6d to d093b44 Increases (1 build for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Byungjoo-Lee
approved these changes
May 20, 2022
sharadb-amazon
force-pushed
the
droid-20220519
branch
from
May 20, 2022 02:08
d093b44
to
16691f8
Compare
sharadb-amazon
force-pushed
the
droid-20220519
branch
from
May 20, 2022 02:13
16691f8
to
1819feb
Compare
sharadb-amazon
force-pushed
the
droid-20220519
branch
from
May 20, 2022 02:54
6b0f8e1
to
8b00405
Compare
bzbarsky-apple
approved these changes
May 20, 2022
PR #18636: Size comparison from fd84c37 to 8b00405 Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
May 20, 2022
andy31415
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Android tv-casting-app failed to commission or send Content Launch commands
Change overview
Fixes that would skip starting the chip server a second time and would apply lock before calling the SDK's openBasicCommissioningWindow function
Testing
Built and tested by deploying the app to an Android phone and testing against a tv-app running on Raspberry Pi.