-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[esp32] add configurable external platform include directory #18203
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
gjc13:bugfix/esp32-external-include
May 11, 2022
Merged
[esp32] add configurable external platform include directory #18203
bzbarsky-apple
merged 1 commit into
project-chip:master
from
gjc13:bugfix/esp32-external-include
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
May 9, 2022 11:09
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
May 9, 2022 11:09
PR #18203: Size comparison from 04c85c7 to 5f6839d Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 9, 2022
arkq
approved these changes
May 9, 2022
chshu
reviewed
May 10, 2022
gjc13
force-pushed
the
bugfix/esp32-external-include
branch
from
May 10, 2022 10:12
5f6839d
to
74fd9e1
Compare
PR #18203: Size comparison from 7111fd5 to 74fd9e1 Full report (18 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
This allow the external platform to be included in other components without modifying the include directories.
gjc13
force-pushed
the
bugfix/esp32-external-include
branch
from
May 10, 2022 10:58
74fd9e1
to
dbb374f
Compare
PR #18203: Size comparison from 7111fd5 to dbb374f Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chshu
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ESP32 components depending on CHIP must manually modify their include directories if they are to use the external platform.
Change overview
Add a Kconfig option for users to config the external platform include directory.
Testing