Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output name of qpg_executable OTA #17786

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Apr 26, 2022

Problem

This always builds because it uses the wrong filename:

ninja: Entering directory `out/debug'
ninja explain: output build.ninja older than most recent input ../../third_party/connectedhomeip/third_party/qpg_sdk/qpg_executable.gni (1651007143800012937 vs 1651007267243517127)
[0/1] Regenerating ninja files
ninja explain: output lock_app.out.ota doesn't exist
ninja explain: lock_app.out.ota is dirty
[1/2] ACTION //:lock_app.out.ota(//third_party/connectedhomeip/build/toolchain/arm_gcc:arm_gcc)

Change overview

Fix the filename (and squelch the output).

Testing

(cd ./examples/lock-app/qpg; gn gen out/debug; ninja -C out/debug)

This always builds because it uses the wrong filename:

ninja: Entering directory `out/debug'
ninja explain: output build.ninja older than most recent input ../../third_party/connectedhomeip/third_party/qpg_sdk/qpg_executable.gni (1651007143800012937 vs 1651007267243517127)
[0/1] Regenerating ninja files
ninja explain: output lock_app.out.ota doesn't exist
ninja explain: lock_app.out.ota is dirty
[1/2] ACTION //:lock_app.out.ota(//third_party/connectedhomeip/build/toolchain/arm_gcc:arm_gcc)

Fix the filename (and squelch the output).
@mspang mspang force-pushed the for-chip/qpg-ota branch from 5ca74c3 to 1b25f9e Compare April 26, 2022 21:45
@pullapprove pullapprove bot requested review from kghost and removed request for lzgrablic02 April 26, 2022 21:45
@github-actions
Copy link

github-actions bot commented Apr 26, 2022

PR #17786: Size comparison from 6c54ab8 to 1b25f9e

Full report (15 builds for cc13x2_26x2, efr32, esp32, mbed, nrfconnect, p6)
platform target config section 6c54ab8 1b25f9e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688215 688215 0 0.0
(read/write) 163824 163824 0 0.0
.bss 75020 75020 0 0.0
.data 3396 3396 0 0.0
.rodata 101583 101583 0 0.0
.text 586152 586152 0 0.0
lock-ftd LP_CC2652R7 (read only) 688783 688783 0 0.0
(read/write) 154568 154568 0 0.0
.bss 73388 73388 0 0.0
.data 3220 3220 0 0.0
.rodata 103175 103175 0 0.0
.text 585124 585124 0 0.0
lock-mtd LP_CC2652R7 (read only) 637535 637535 0 0.0
(read/write) 146188 146188 0 0.0
.bss 69108 69108 0 0.0
.data 3220 3220 0 0.0
.rodata 103055 103055 0 0.0
.text 533988 533988 0 0.0
pump-app LP_CC2652R7 (read only) 661635 661635 0 0.0
(read/write) 182916 182916 0 0.0
.bss 73564 73564 0 0.0
.data 3252 3252 0 0.0
.rodata 80371 80371 0 0.0
.text 580784 580784 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654523 654523 0 0.0
(read/write) 189820 189820 0 0.0
.bss 73612 73612 0 0.0
.data 3216 3216 0 0.0
.rodata 83395 83395 0 0.0
.text 570648 570648 0 0.0
efr32 lighting-app BRD4161A (read only) 907612 907612 0 0.0
(read/write) 134908 134908 0 0.0
.bss 132864 132864 0 0.0
.data 2044 2044 0 0.0
.text 907604 907604 0 0.0
BRD4161A+rpc (read only) 942028 942028 0 0.0
(read/write) 151592 151592 0 0.0
.bss 149344 149344 0 0.0
.data 2248 2248 0 0.0
.text 942020 942020 0 0.0
window-app BRD4161A (read only) 844996 844996 0 0.0
(read/write) 132996 132996 0 0.0
.bss 131040 131040 0 0.0
.data 1956 1956 0 0.0
.text 844988 844988 0 0.0
esp32 all-clusters-app c3devkit (read only) 999324 999324 0 0.0
(read/write) 1473618 1473618 0 0.0
.dram0.bss 68176 68176 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206568 206568 0 0.0
.flash.text 999324 999324 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053619 1053619 0 0.0
(read/write) 475616 475616 0 0.0
.dram0.bss 73696 73696 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235916 235916 0 0.0
.flash.text 1048235 1048235 0 0.0
.iram0.text 123107 123107 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411508 2411508 0 0.0
.bss 205660 205660 0 0.0
.data 5848 5848 0 0.0
.text 1374108 1374108 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179243 1179243 0 0.0
bss 141784 141784 0 0.0
rodata 150204 150204 0 0.0
text 808616 808616 0 0.0
p6 all-clusters-app default (read/write) 2526920 2526920 0 0.0
.bss 139040 139040 0 0.0
.data 2784 2784 0 0.0
.text 1485184 1485184 0 0.0
light-app default (read/write) 2418680 2418680 0 0.0
.bss 132520 132520 0 0.0
.data 2584 2584 0 0.0
.text 1376944 1376944 0 0.0
lock-app default (read/write) 2422856 2422856 0 0.0
.bss 132320 132320 0 0.0
.data 2544 2544 0 0.0
.text 1381120 1381120 0 0.0

@Damian-Nordic Damian-Nordic merged commit aa566b0 into project-chip:master Apr 27, 2022
@mspang mspang deleted the for-chip/qpg-ota branch April 27, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants