Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on NRFConnect. #17714

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Looks like that has started using Advertiser_ImplNone.

Problem

NRFConnect using Advertiser_ImplNone, which does not compile.

Change overview

Make it compile.

Testing

No good way to test apart from CI.

Looks like that has started using Advertiser_ImplNone.
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Apr 25, 2022
@andy31415
Copy link
Contributor

Hoftix build breakage fix

@github-actions
Copy link

github-actions bot commented Apr 25, 2022

PR #17714: Size comparison from 1520662 to 394e325

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 1520662 394e325 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692123 692123 0 0.0
(read/write) 159900 159900 0 0.0
.bss 75008 75008 0 0.0
.data 3396 3396 0 0.0
.rodata 105995 105995 0 0.0
.text 585648 585648 0 0.0
lock-ftd LP_CC2652R7 (read only) 678647 678647 0 0.0
(read/write) 164688 164688 0 0.0
.bss 73376 73376 0 0.0
.data 3220 3220 0 0.0
.rodata 98831 98831 0 0.0
.text 579332 579332 0 0.0
lock-mtd LP_CC2652R7 (read only) 627391 627391 0 0.0
(read/write) 146172 146172 0 0.0
.bss 69096 69096 0 0.0
.data 3220 3220 0 0.0
.rodata 98711 98711 0 0.0
.text 528188 528188 0 0.0
pump-app LP_CC2652R7 (read only) 651123 651123 0 0.0
(read/write) 151684 151684 0 0.0
.bss 73552 73552 0 0.0
.data 3252 3252 0 0.0
.rodata 75723 75723 0 0.0
.text 574912 574912 0 0.0
pump-controller-app LP_CC2652R7 (read only) 644175 644175 0 0.0
(read/write) 151440 151440 0 0.0
.bss 73600 73600 0 0.0
.data 3216 3216 0 0.0
.rodata 78839 78839 0 0.0
.text 564848 564848 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 623486 623486 0 0.0
.app_xip_area 526364 526364 0 0.0
.bss 79780 79780 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 618442 618442 0 0.0
.app_xip_area 522792 522792 0 0.0
.bss 78340 78340 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571158 571158 0 0.0
.app_xip_area 465872 465872 0 0.0
.bss 87680 87680 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907616 907616 0 0.0
(read/write) 134912 134912 0 0.0
.bss 132864 132864 0 0.0
.data 2044 2044 0 0.0
.text 907608 907608 0 0.0
BRD4161A+rpc (read only) 942032 942032 0 0.0
(read/write) 151592 151592 0 0.0
.bss 149344 149344 0 0.0
.data 2248 2248 0 0.0
.text 942024 942024 0 0.0
window-app BRD4161A (read only) 845000 845000 0 0.0
(read/write) 133000 133000 0 0.0
.bss 131040 131040 0 0.0
.data 1956 1956 0 0.0
.text 844992 844992 0 0.0
esp32 all-clusters-app c3devkit (read only) 999398 999398 0 0.0
(read/write) 1473658 1473658 0 0.0
.dram0.bss 68176 68176 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206608 206608 0 0.0
.flash.text 999398 999398 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053627 1053627 0 0.0
(read/write) 475656 475656 0 0.0
.dram0.bss 73696 73696 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235956 235956 0 0.0
.flash.text 1048243 1048243 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688740 688740 0 0.0
.bss 81112 81112 0 0.0
.data 2000 2000 0 0.0
.text 599828 599828 0 0.0
lock k32w061+release (read/write) 729632 729632 0 0.0
.bss 81520 81520 0 0.0
.data 1960 1960 0 0.0
.text 640352 640352 0 0.0
linux all-clusters-app debug (read only) 2735009 2735009 0 0.0
(read/write) 172872 172872 0 0.0
.bss 83168 83168 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81640 81640 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 233861 233861 0 0.0
.text 2326306 2326306 0 0.0
bridge-app debug+rpc (read only) 1891009 1891009 0 0.0
(read/write) 120304 120304 0 0.0
.bss 71168 71168 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40392 40392 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 159633 159633 0 0.0
.text 1608594 1608594 0 0.0
chip-tool debug (read only) 10944717 10944717 0 0.0
(read/write) 375792 375792 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 345808 345808 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 547349 547349 0 0.0
.text 9557413 9557413 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10556092 10556092 0 0.0
(read/write) 497697 497697 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393104 393104 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 521228 521228 0 0.0
.text 8917012 8917012 0 0.0
lighting-app debug+rpc (read only) 2326465 2326465 0 0.0
(read/write) 151256 151256 0 0.0
.bss 73216 73216 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70328 70328 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 183729 183729 0 0.0
.text 1976098 1976098 0 0.0
lock-app debug (read only) 2206801 2206801 0 0.0
(read/write) 145640 145640 0 0.0
.bss 71808 71808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66664 66664 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192193 192193 0 0.0
.text 1854610 1854610 0 0.0
ota-provider-app debug (read only) 2059521 2059521 0 0.0
(read/write) 138888 138888 0 0.0
.bss 71232 71232 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60216 60216 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174235 174235 0 0.0
.text 1727778 1727778 0 0.0
ota-requestor-app debug (read only) 2090785 2090785 0 0.0
(read/write) 141696 141696 0 0.0
.bss 71872 71872 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170588 170588 0 0.0
.text 1761202 1761202 0 0.0
shell debug (read only) 2560809 2560809 0 0.0
(read/write) 196840 196840 0 0.0
.bss 113768 113768 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75992 75992 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215570 215570 0 0.0
.text 2183330 2183330 0 0.0
thermostat-no-ble arm64 (read only) 2367884 2367884 0 0.0
(read/write) 174369 174369 0 0.0
.bss 86097 86097 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79008 79008 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145484 145484 0 0.0
.text 1993296 1993296 0 0.0
tv-app debug (read only) 2844569 2844569 0 0.0
(read/write) 276536 276536 0 0.0
.bss 189112 189112 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76568 76568 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216011 216011 0 0.0
.text 2446098 2446098 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411436 2411436 0 0.0
.bss 205660 205660 0 0.0
.data 5848 5848 0 0.0
.text 1374036 1374036 0 0.0
p6 all-clusters-app default (read/write) 2526936 2526936 0 0.0
.bss 139040 139040 0 0.0
.data 2784 2784 0 0.0
.text 1485200 1485200 0 0.0
light-app default (read/write) 2418688 2418688 0 0.0
.bss 132520 132520 0 0.0
.data 2584 2584 0 0.0
.text 1376952 1376952 0 0.0
lock-app default (read/write) 2422864 2422864 0 0.0
.bss 132320 132320 0 0.0
.data 2544 2544 0 0.0
.text 1381128 1381128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807948 807948 0 0.0
bss 75216 75216 0 0.0
noinit 40416 40416 0 0.0
text 571718 571718 0 0.0

@andy31415 andy31415 merged commit 923b996 into project-chip:master Apr 26, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-build branch April 26, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review lib review - pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants