Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] Use BLE notification instead of indication #17692

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Linux BLE peripherals use GATT indications instead of notifications as defined in the spec.

Change overview

Switch to using GATT notifications (without confirmation).
Fixes #17353.

Testing

Verified using chip-tool for Linux that commissioning of a Linux peripheral still works.

Linux BLE peripherals use GATT indications instead of
notifications as defined in the spec.
@github-actions
Copy link

github-actions bot commented Apr 25, 2022

PR #17692: Size comparison from cb6843f to 2bed76f

Decreases (1 build for linux)
platform target config section cb6843f 2bed76f change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10555708 10555580 -128 -0.0
.rodata 521212 521164 -48 -0.0
.text 8916692 8916612 -80 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cb6843f 2bed76f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692119 692119 0 0.0
(read/write) 159968 159968 0 0.0
.bss 75072 75072 0 0.0
.data 3396 3396 0 0.0
.rodata 106015 106015 0 0.0
.text 585624 585624 0 0.0
lock-ftd LP_CC2652R7 (read only) 678635 678635 0 0.0
(read/write) 164756 164756 0 0.0
.bss 73432 73432 0 0.0
.data 3220 3220 0 0.0
.rodata 98851 98851 0 0.0
.text 579300 579300 0 0.0
lock-mtd LP_CC2652R7 (read only) 627379 627379 0 0.0
(read/write) 146228 146228 0 0.0
.bss 69152 69152 0 0.0
.data 3220 3220 0 0.0
.rodata 98731 98731 0 0.0
.text 528156 528156 0 0.0
pump-app LP_CC2652R7 (read only) 651071 651071 0 0.0
(read/write) 151692 151692 0 0.0
.bss 73560 73560 0 0.0
.data 3252 3252 0 0.0
.rodata 75703 75703 0 0.0
.text 574880 574880 0 0.0
pump-controller-app LP_CC2652R7 (read only) 644139 644139 0 0.0
(read/write) 151440 151440 0 0.0
.bss 73600 73600 0 0.0
.data 3216 3216 0 0.0
.rodata 78835 78835 0 0.0
.text 564816 564816 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 623542 623542 0 0.0
.app_xip_area 526356 526356 0 0.0
.bss 79844 79844 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 618498 618498 0 0.0
.app_xip_area 522792 522792 0 0.0
.bss 78396 78396 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571134 571134 0 0.0
.app_xip_area 465840 465840 0 0.0
.bss 87688 87688 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907520 907520 0 0.0
(read/write) 134968 134968 0 0.0
.bss 132920 132920 0 0.0
.data 2044 2044 0 0.0
.text 907512 907512 0 0.0
BRD4161A+rpc (read only) 941936 941936 0 0.0
(read/write) 151648 151648 0 0.0
.bss 149400 149400 0 0.0
.data 2248 2248 0 0.0
.text 941928 941928 0 0.0
window-app BRD4161A (read only) 845008 845008 0 0.0
(read/write) 133056 133056 0 0.0
.bss 131096 131096 0 0.0
.data 1956 1956 0 0.0
.text 845000 845000 0 0.0
esp32 all-clusters-app c3devkit (read only) 999220 999220 0 0.0
(read/write) 1473730 1473730 0 0.0
.dram0.bss 68216 68216 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206632 206632 0 0.0
.flash.text 999220 999220 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053467 1053467 0 0.0
(read/write) 475720 475720 0 0.0
.dram0.bss 73736 73736 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235980 235980 0 0.0
.flash.text 1048083 1048083 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688808 688808 0 0.0
.bss 81168 81168 0 0.0
.data 2000 2000 0 0.0
.text 599840 599840 0 0.0
lock k32w061+release (read/write) 729676 729676 0 0.0
.bss 81576 81576 0 0.0
.data 1960 1960 0 0.0
.text 640340 640340 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10555708 10555580 -128 -0.0
(read/write) 497681 497681 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393088 393088 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 521212 521164 -48 -0.0
.text 8916692 8916612 -80 -0.0
thermostat-no-ble arm64 (read only) 2367532 2367532 0 0.0
(read/write) 174401 174401 0 0.0
.bss 86145 86145 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78992 78992 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145308 145308 0 0.0
.text 1993024 1993024 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411396 2411396 0 0.0
.bss 205716 205716 0 0.0
.data 5848 5848 0 0.0
.text 1373996 1373996 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177531 1177531 0 0.0
bss 141840 141840 0 0.0
rodata 150124 150124 0 0.0
text 806852 806852 0 0.0
p6 all-clusters-app default (read/write) 2526888 2526888 0 0.0
.bss 139096 139096 0 0.0
.data 2784 2784 0 0.0
.text 1485152 1485152 0 0.0
light-app default (read/write) 2418640 2418640 0 0.0
.bss 132576 132576 0 0.0
.data 2584 2584 0 0.0
.text 1376904 1376904 0 0.0
lock-app default (read/write) 2422832 2422832 0 0.0
.bss 132376 132376 0 0.0
.data 2544 2544 0 0.0
.text 1381096 1381096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807984 807984 0 0.0
bss 75272 75272 0 0.0
noinit 40416 40416 0 0.0
text 571680 571680 0 0.0

@andy31415 andy31415 merged commit 6160935 into project-chip:master Apr 26, 2022
@Damian-Nordic Damian-Nordic deleted the linux-notify branch April 26, 2022 13:25
AntonGrey pushed a commit to AntonGrey/connectedhomeip that referenced this pull request Apr 26, 2022
Linux BLE peripherals use GATT indications instead of
notifications as defined in the spec.
Damian-Nordic added a commit to Damian-Nordic/connectedhomeip that referenced this pull request Apr 28, 2022
andy31415 pushed a commit that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ble] C2 on Linux uses indication instead of notify
4 participants