Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in comment in ClusterStateCache. #17467

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

Comment says "attribute" when it means "event".

Change overview

Make it say "event"/

Testing

No behavior changes.

@github-actions
Copy link

github-actions bot commented Apr 18, 2022

PR #17467: Size comparison from 4fc01e1 to 8ad2d2c

Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4fc01e1 8ad2d2c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684583 684583 0 0.0
(read/write) 168600 168600 0 0.0
.bss 76168 76168 0 0.0
.data 3380 3380 0 0.0
.rodata 103367 103367 0 0.0
.text 580736 580736 0 0.0
lock-ftd LP_CC2652R7 (read only) 677495 677495 0 0.0
(read/write) 166632 166632 0 0.0
.bss 74168 74168 0 0.0
.data 3212 3212 0 0.0
.rodata 98847 98847 0 0.0
.text 578164 578164 0 0.0
lock-mtd LP_CC2652R7 (read only) 626239 626239 0 0.0
(read/write) 146956 146956 0 0.0
.bss 69888 69888 0 0.0
.data 3212 3212 0 0.0
.rodata 98727 98727 0 0.0
.text 527020 527020 0 0.0
pump-app LP_CC2652R7 (read only) 649639 649639 0 0.0
(read/write) 152492 152492 0 0.0
.bss 74624 74624 0 0.0
.data 3244 3244 0 0.0
.rodata 75671 75671 0 0.0
.text 573480 573480 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642975 642975 0 0.0
(read/write) 152160 152160 0 0.0
.bss 74328 74328 0 0.0
.data 3208 3208 0 0.0
.rodata 79007 79007 0 0.0
.text 563480 563480 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 619110 619110 0 0.0
.app_xip_area 525868 525868 0 0.0
.bss 75908 75908 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613362 613362 0 0.0
.app_xip_area 521624 521624 0 0.0
.bss 74436 74436 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 566206 566206 0 0.0
.app_xip_area 464856 464856 0 0.0
.bss 83752 83752 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908932 908932 0 0.0
(read/write) 133128 133128 0 0.0
.bss 131088 131088 0 0.0
.data 2040 2040 0 0.0
.text 908924 908924 0 0.0
BRD4161A+rpc (read only) 943308 943308 0 0.0
(read/write) 149812 149812 0 0.0
.bss 147568 147568 0 0.0
.data 2244 2244 0 0.0
.text 943300 943300 0 0.0
window-app BRD4161A (read only) 845292 845292 0 0.0
(read/write) 131116 131116 0 0.0
.bss 129168 129168 0 0.0
.data 1948 1948 0 0.0
.text 845284 845284 0 0.0
esp32 all-clusters-app c3devkit (read only) 980476 980476 0 0.0
(read/write) 1397826 1397826 0 0.0
.dram0.bss 62600 62600 0 0.0
.dram0.data 14412 14412 0 0.0
.flash.rodata 201896 201896 0 0.0
.flash.text 980476 980476 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035975 1035975 0 0.0
(read/write) 465552 465552 0 0.0
.dram0.bss 68112 68112 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231452 231452 0 0.0
.flash.text 1030591 1030591 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684684 684684 0 0.0
.bss 77912 77912 0 0.0
.data 1992 1992 0 0.0
.text 598980 598980 0 0.0
lock k32w061+release (read/write) 725540 725540 0 0.0
.bss 78520 78520 0 0.0
.data 1952 1952 0 0.0
.text 639268 639268 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10430084 10430084 0 0.0
(read/write) 494193 494193 0 0.0
.bss 40865 40865 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 390440 390440 0 0.0
.dynamic 560 560 0 0.0
.got 57904 57904 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 516644 516644 0 0.0
.text 8804420 8804420 0 0.0
thermostat-no-ble arm64 (read only) 2359028 2359028 0 0.0
(read/write) 151137 151137 0 0.0
.bss 62945 62945 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145300 145300 0 0.0
.text 1984736 1984736 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410124 2410124 0 0.0
.bss 185228 185228 0 0.0
.data 5840 5840 0 0.0
.text 1372724 1372724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164515 1164515 0 0.0
bss 136520 136520 0 0.0
rodata 147524 147524 0 0.0
text 801832 801832 0 0.0
p6 all-clusters-app default (read/write) 2516976 2516976 0 0.0
.bss 118624 118624 0 0.0
.data 2768 2768 0 0.0
.text 1475240 1475240 0 0.0
light-app default (read/write) 2416904 2416904 0 0.0
.bss 112104 112104 0 0.0
.data 2576 2576 0 0.0
.text 1375168 1375168 0 0.0
lock-app default (read/write) 2420368 2420368 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1378632 1378632 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801956 801956 0 0.0
bss 69952 69952 0 0.0
noinit 40416 40416 0 0.0
text 570550 570550 0 0.0

@andy31415 andy31415 merged commit 2caccab into project-chip:master Apr 19, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-typo branch April 19, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants