-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we deallocate CASEClient if EstablishSession fails synchronously. #17466
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:clean-up-case-client
Apr 19, 2022
Merged
Ensure we deallocate CASEClient if EstablishSession fails synchronously. #17466
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:clean-up-case-client
Apr 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could end up in a state where we allocated mCASEClient in OperationalDeviceProxy::EstablishConnection and then EstablishSession on the CASEClient would fail and we would be left with a stale pointer. And then later nothing would deallocate the CASEClient and if we had another connection attempt we'd just allocate a new one and leak the old one. The fix is two-fold: 1. Make sure to call CleanupCASEClient (renamed from CloseCASESession) if EstablishSession fails. 2. Make it harder to forget to call CleanupCASEClient in various places by just doing it when we transition out of the Connecting state.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu and
chulspro
April 18, 2022 17:50
pullapprove
bot
requested review from
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
msandstedt and
mspang
April 18, 2022 17:50
pullapprove
bot
requested review from
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
April 18, 2022 17:50
PR #17466: Size comparison from 4fc01e1 to 9cccab9 Increases (4 builds for cc13x2_26x2, esp32, telink)
Decreases (14 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
kghost
approved these changes
Apr 19, 2022
msandstedt
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could end up in a state where we allocated mCASEClient in
OperationalDeviceProxy::EstablishConnection and then EstablishSession
on the CASEClient would fail and we would be left with a stale
pointer. And then later nothing would deallocate the CASEClient and
if we had another connection attempt we'd just allocate a new one and
leak the old one.
The fix is two-fold:
Make sure to call CleanupCASEClient (renamed from CloseCASESession)
if EstablishSession fails.
Make it harder to forget to call CleanupCASEClient in various
places by just doing it when we transition out of the Connecting
state.
Problem
See above.
Change overview
See above.
Testing
Should be no behavior changes except in error cases where EstablishSession sync-fails for some reason.