-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] OTA: Use word-aligned buffer in bootloader storage APIs #17281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new manual scripts * Added Auto generated File
* [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <commits@restyled.io>
boring-cyborg
bot
added
the
documentation
Improvements or additions to documentation
label
Apr 12, 2022
selissia
changed the title
Work In Progress, please ignore
[EFR32] OTA: Use word-aligned buffer in bootloader storage APIs
Apr 12, 2022
PR #17281: Size comparison from 2c15978 to 2714cbe Increases (2 builds for efr32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Apr 12, 2022
andy31415
reviewed
Apr 12, 2022
andy31415
reviewed
Apr 12, 2022
andy31415
reviewed
Apr 12, 2022
andy31415
reviewed
Apr 12, 2022
PR #17281: Size comparison from 2e33dec to f8f961f Increases (2 builds for efr32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Apr 12, 2022
PR #17281: Size comparison from faabdf9 to 86310c3 Increases (2 builds for efr32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Apr 13, 2022
PR #17281: Size comparison from faabdf9 to bbf022d Increases (2 builds for efr32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…ect-chip#17281) * Test added march 8 (project-chip#15957) * Added new manual scripts * Added Auto generated File * [OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981) * Regen to fix CI failures (project-chip#15990) * [ota] Store Default OTA Providers in flash (project-chip#15970) * [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <commits@restyled.io> * Use an intermediate buffer for writing the image to the booloader storage * Use critical section in the bootloader API call * Cleanup log messages, move variables into a class * Remove merge artifacts * Update EFR32 documentation * Fix typo * Restyled by whitespace * Restyled by clang-format * Restyled by prettier-markdown * Rename array size parameter, add aligned attribute * Trivial change to restart the CI (restyle job need to be kicked) * Restyled by clang-format * Update comments Co-authored-by: kowsisoundhar12 <57476670+kowsisoundhar12@users.noreply.github.com> Co-authored-by: Carol Yang <clyang@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EFR32 bootloader storage API must use word-aligned write calls and be wrapped into a critical section.
Change overview
Testing
Tested OTA scenario on EFR32 MG12 and MG24 boards