Changed the lower limit of the deadband to 0 to match the spec #17075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
yunhanw-google,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #17075: Size comparison from bc01144 to 456eb45 Full report (26 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 5, 2022
|
@drempelg - needs zap regeneration |
No, needs the restyle thing... We really need to sort out why the pigweed clang-format locally has started producing different results from the restyle job and from whatever clang-format runs in CI. |
Yeah I started getting hit by that too, annoying. |
|
PR #17075: Size comparison from bc01144 to 646c33a Increases (8 builds for linux)
Decreases (12 builds for cc13x2_26x2, efr32, k32w, linux, nrfconnect, telink)
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
what is going on with those tests? I don't think the failure has anything to do with my changes....does it? Seems like a multi fabric problem? |
Looks like passing now. I believe for darwin the theory is that there is crosstalk between CI instances - VMs are supposed to be isolated however they seem not to be. #17087 attempts to fix this. |
Yeah, noticed it got fixed, at least here. So I just need some approvals then and I can put this to bed. We good now? |
tcarmelveilleux
approved these changes
Apr 6, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…ct-chip#17075) * Changed the lower limit of the deadband to 0 to match the spec * removed the unnessary white space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The dead band hand a lower limit that didn't match the spec. Spec says it should be 0. Fixed
Change overview
modified the xml to reflect it's true limits.
Regenerated all the pre-generated stuff in the repo.
Testing
Tested on our DUT, was able to set the dead band attribute to 0.