-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the lower limit of the deadband to 0 to match the spec #17075
Changed the lower limit of the deadband to 0 to match the spec #17075
Conversation
PR #17075: Size comparison from bc01144 to 456eb45 Full report (26 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this needs restyle run on the generated Commands.h, because local clang-format and restyle disagree on the right style....
@drempelg - needs zap regeneration |
No, needs the restyle thing... We really need to sort out why the pigweed clang-format locally has started producing different results from the restyle job and from whatever clang-format runs in CI. |
Yeah I started getting hit by that too, annoying. |
PR #17075: Size comparison from bc01144 to 646c33a Increases (8 builds for linux)
Decreases (12 builds for cc13x2_26x2, efr32, k32w, linux, nrfconnect, telink)
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
what is going on with those tests? I don't think the failure has anything to do with my changes....does it? Seems like a multi fabric problem? |
Looks like passing now. I believe for darwin the theory is that there is crosstalk between CI instances - VMs are supposed to be isolated however they seem not to be. #17087 attempts to fix this. |
Yeah, noticed it got fixed, at least here. So I just need some approvals then and I can put this to bed. We good now? |
…ct-chip#17075) * Changed the lower limit of the deadband to 0 to match the spec * removed the unnessary white space
Problem
The dead band hand a lower limit that didn't match the spec. Spec says it should be 0. Fixed
Change overview
modified the xml to reflect it's true limits.
Regenerated all the pre-generated stuff in the repo.
Testing
Tested on our DUT, was able to set the dead band attribute to 0.