Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thread] GenericNetworkCommissioningThreadDriver error handling fixes #17006

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[thread] GenericNetworkCommissioningThreadDriver error handling fixes #17006

merged 1 commit into from
Apr 5, 2022

Conversation

Damian-Nordic
Copy link
Contributor

@Damian-Nordic Damian-Nordic commented Apr 4, 2022 •
edited
Loading

Problem

GenericNetworkCommissioningThreadDriver returns wrong error codes in some places or is missing some validations.

Change overview

  1. Return NetworkIdNotFound instead of NetworkNotFound when trying to reference an unknown network.
  2. Validate ReorderNetwork index.
  3. Validate input dataset Init() result.
  4. Reduce some code duplication.
    Fixes Network commissioning server ConnectNetwork/RemoveNetwork cmds return NetworkNotFound instead of NetworkIdNotFound (spec) #16229

Testing

Tested on nRF connect examples that correct error codes are returned.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17006: Size comparison from 3666138 to a09e887

Increases above 0.2%:

platform target config section 3666138 a09e887 change % change
linux bridge-app debug+rpc .data.rel.ro 38320 38448 128 0.3
door-lock-app debug .data.rel.ro 63416 63544 128 0.2
ota-provider-app debug .data.rel.ro 58728 58856 128 0.2
ota-requestor-app debug .data.rel.ro 60936 61064 128 0.2
thermostat-no-ble arm64 .got 4568 4584 16 0.4
Increases (18 builds for cc13x2_26x2, esp32, linux, nrfconnect)
platform target config section 3666138 a09e887 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 183604 183660 56 0.0
.rodata 79683 79723 40 0.1
lock-mtd LP_CC2652R7 .rodata 79563 79603 40 0.1
pump-app LP_CC2652R7 (read/write) 165312 165368 56 0.0
.rodata 81759 81791 32 0.0
pump-controller-app LP_CC2652R7 (read/write) 182824 182904 80 0.0
.rodata 78095 78127 32 0.0
esp32 all-clusters-app c3devkit (read/write) 1460530 1460570 40 0.0
.flash.rodata 197960 198000 40 0.0
m5stack (read/write) 461544 461584 40 0.0
.flash.rodata 226928 226968 40 0.0
linux all-clusters-app debug (read only) 2576609 2577057 448 0.0
(read/write) 144360 144488 128 0.1
.data.rel.ro 79608 79736 128 0.2
.rodata 220549 220613 64 0.0
.text 2188642 2188786 144 0.0
bridge-app debug+rpc (read only) 1787181 1787533 352 0.0
(read/write) 89912 90040 128 0.1
.data.rel.ro 38320 38448 128 0.3
.rodata 146937 147001 64 0.0
.text 1524213 1524261 48 0.0
chip-tool debug (read only) 10436029 10437245 1216 0.0
(read/write) 358552 358680 128 0.0
.data.rel.ro 329272 329400 128 0.0
.rodata 532205 532237 32 0.0
.text 9111349 9112293 944 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10036540 10037884 1344 0.0
(read/write) 478177 478337 160 0.0
.data.rel.ro 376144 376288 144 0.0
.got 56768 56784 16 0.0
.rodata 506524 506604 80 0.0
.text 8465492 8466420 928 0.0
door-lock-app debug (read only) 2057977 2058361 384 0.0
(read/write) 117808 117936 128 0.1
.data.rel.ro 63416 63544 128 0.2
.rodata 184873 184969 96 0.1
.text 1719890 1719938 48 0.0
lighting-app debug+rpc (read only) 2236209 2236593 384 0.0
(read/write) 124800 124928 128 0.1
.data.rel.ro 68488 68616 128 0.2
.rodata 179017 179113 96 0.1
.text 1894514 1894562 48 0.0
ota-provider-app debug (read only) 1995985 1996401 416 0.0
(read/write) 113408 113536 128 0.1
.data.rel.ro 58728 58856 128 0.2
.rodata 170707 170819 112 0.1
.text 1671154 1671218 64 0.0
ota-requestor-app debug (read only) 2024785 2024993 208 0.0
(read/write) 116632 116760 128 0.1
.data.rel.ro 60936 61064 128 0.2
.rodata 166908 166956 48 0.0
shell debug (read only) 2473937 2474417 480 0.0
(read/write) 147888 148016 128 0.1
.data.rel.ro 74136 74264 128 0.2
.rodata 212338 212434 96 0.0
.text 2103666 2103810 144 0.0
thermostat-no-ble arm64 (read only) 2311068 2311676 608 0.0
(read/write) 149057 149249 192 0.1
.data.rel.ro 77488 77656 168 0.2
.got 4568 4584 16 0.4
.rodata 142908 142972 64 0.0
.text 1943040 1943232 192 0.0
tv-app debug (read/write) 249312 249440 128 0.1
.data.rel.ro 74648 74776 128 0.2
.rodata 210635 210699 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 143292 143328 36 0.0
Decreases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3666138 a09e887 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668091 668035 -56 -0.0
.text 587928 587832 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 617211 617155 -56 -0.0
.text 537160 537064 -96 -0.0
pump-app LP_CC2652R7 (read only) 687543 687487 -56 -0.0
.text 605300 605212 -88 -0.0
pump-controller-app LP_CC2652R7 (read only) 669775 669695 -80 -0.0
.text 591196 591084 -112 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610682 610610 -72 -0.0
.app_xip_area 517456 517384 -72 -0.0
lock cyw930739m2evb_01 (read/write) 568202 568146 -56 -0.0
.app_xip_area 476504 476448 -56 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579790 579726 -64 -0.0
.app_xip_area 478460 478396 -64 -0.0
efr32 lighting-app BRD4161A (read only) 916168 916128 -40 -0.0
.text 916160 916120 -40 -0.0
BRD4161A+rpc (read only) 944048 944024 -24 -0.0
.text 944040 944016 -24 -0.0
window-app BRD4161A (read only) 851480 851440 -40 -0.0
.text 851472 851432 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 985940 985618 -322 -0.0
.flash.text 985940 985618 -322 -0.0
m5stack (read only) 1038339 1038235 -104 -0.0
.flash.text 1032955 1032851 -104 -0.0
k32w light k32w061+release (read/write) 707908 707836 -72 -0.0
.text 622296 622224 -72 -0.0
lock k32w061+release (read/write) 707316 707244 -72 -0.0
.text 621680 621608 -72 -0.0
linux ota-requestor-app debug .text 1702098 1702018 -80 -0.0
tv-app debug (read only) 2741337 2740761 -576 -0.0
.text 2352882 2352002 -880 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2360020 2359932 -88 -0.0
.text 1322620 1322532 -88 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148795 1148735 -60 -0.0
text 787612 787512 -100 -0.0
p6 all-clusters-app default (read/write) 2504592 2504488 -104 -0.0
.text 1462856 1462752 -104 -0.0
light-app default (read/write) 2405752 2405648 -104 -0.0
.text 1364016 1363912 -104 -0.0
lock-app default (read/write) 2369384 2369280 -104 -0.0
.text 1327648 1327544 -104 -0.0
telink lighting-app tlsr9518adk80d (read/write) 792340 792068 -272 -0.0
text 562250 561934 -316 -0.1
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3666138 a09e887 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668091 668035 -56 -0.0
(read/write) 183604 183660 56 0.0
.bss 81736 81736 0 0.0
.data 3128 3128 0 0.0
.rodata 79683 79723 40 0.1
.text 587928 587832 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 617211 617155 -56 -0.0
(read/write) 154448 154448 0 0.0
.bss 77464 77464 0 0.0
.data 3128 3128 0 0.0
.rodata 79563 79603 40 0.1
.text 537160 537064 -96 -0.0
pump-app LP_CC2652R7 (read only) 687543 687487 -56 -0.0
(read/write) 165312 165368 56 0.0
.bss 82128 82128 0 0.0
.data 3160 3160 0 0.0
.rodata 81759 81791 32 0.0
.text 605300 605212 -88 -0.0
pump-controller-app LP_CC2652R7 (read only) 669775 669695 -80 -0.0
(read/write) 182824 182904 80 0.0
.bss 81872 81872 0 0.0
.data 3124 3124 0 0.0
.rodata 78095 78127 32 0.0
.text 591196 591084 -112 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610682 610610 -72 -0.0
.app_xip_area 517456 517384 -72 -0.0
.bss 75980 75980 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568202 568146 -56 -0.0
.app_xip_area 476504 476448 -56 -0.0
.bss 74484 74484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579790 579726 -64 -0.0
.app_xip_area 478460 478396 -64 -0.0
.bss 83796 83796 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916168 916128 -40 -0.0
(read/write) 129728 129728 0 0.0
.bss 127768 127768 0 0.0
.data 1956 1956 0 0.0
.text 916160 916120 -40 -0.0
BRD4161A+rpc (read only) 944048 944024 -24 -0.0
(read/write) 145680 145680 0 0.0
.bss 143544 143544 0 0.0
.data 2136 2136 0 0.0
.text 944040 944016 -24 -0.0
window-app BRD4161A (read only) 851480 851440 -40 -0.0
(read/write) 127752 127752 0 0.0
.bss 125912 125912 0 0.0
.data 1836 1836 0 0.0
.text 851472 851432 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 985940 985618 -322 -0.0
(read/write) 1460530 1460570 40 0.0
.dram0.bss 62920 62920 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 197960 198000 40 0.0
.flash.text 985940 985618 -322 -0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038339 1038235 -104 -0.0
(read/write) 461544 461584 40 0.0
.dram0.bss 68448 68448 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226928 226968 40 0.0
.flash.text 1032955 1032851 -104 -0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707908 707836 -72 -0.0
.bss 77944 77944 0 0.0
.data 1868 1868 0 0.0
.text 622296 622224 -72 -0.0
lock k32w061+release (read/write) 707316 707244 -72 -0.0
.bss 77928 77928 0 0.0
.data 1908 1908 0 0.0
.text 621680 621608 -72 -0.0
linux all-clusters-app debug (read only) 2576609 2577057 448 0.0
(read/write) 144360 144488 128 0.1
.bss 57536 57536 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79608 79736 128 0.2
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220549 220613 64 0.0
.text 2188642 2188786 144 0.0
bridge-app debug+rpc (read only) 1787181 1787533 352 0.0
(read/write) 89912 90040 128 0.1
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 38320 38448 128 0.3
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146937 147001 64 0.0
.text 1524213 1524261 48 0.0
chip-tool debug (read only) 10436029 10437245 1216 0.0
(read/write) 358552 358680 128 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 329272 329400 128 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532205 532237 32 0.0
.text 9111349 9112293 944 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10036540 10037884 1344 0.0
(read/write) 478177 478337 160 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376144 376288 144 0.0
.dynamic 560 560 0 0.0
.got 56768 56784 16 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506524 506604 80 0.0
.text 8465492 8466420 928 0.0
door-lock-app debug (read only) 2057977 2058361 384 0.0
(read/write) 117808 117936 128 0.1
.bss 47776 47776 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 63416 63544 128 0.2
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 184873 184969 96 0.1
.text 1719890 1719938 48 0.0
lighting-app debug+rpc (read only) 2236209 2236593 384 0.0
(read/write) 124800 124928 128 0.1
.bss 49120 49120 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 68488 68616 128 0.2
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179017 179113 96 0.1
.text 1894514 1894562 48 0.0
ota-provider-app debug (read only) 1995985 1996401 416 0.0
(read/write) 113408 113536 128 0.1
.bss 47616 47616 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 58728 58856 128 0.2
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170707 170819 112 0.1
.text 1671154 1671218 64 0.0
ota-requestor-app debug (read only) 2024785 2024993 208 0.0
(read/write) 116632 116760 128 0.1
.bss 48608 48608 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 60936 61064 128 0.2
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 166908 166956 48 0.0
.text 1702098 1702018 -80 -0.0
shell debug (read only) 2473937 2474417 480 0.0
(read/write) 147888 148016 128 0.1
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74136 74264 128 0.2
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212338 212434 96 0.0
.text 2103666 2103810 144 0.0
thermostat-no-ble arm64 (read only) 2311068 2311676 608 0.0
(read/write) 149057 149249 192 0.1
.bss 62913 62913 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 77488 77656 168 0.2
.dynamic 560 560 0 0.0
.got 4568 4584 16 0.4
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142908 142972 64 0.0
.text 1943040 1943232 192 0.0
tv-app debug (read only) 2741337 2740761 -576 -0.0
(read/write) 249312 249440 128 0.1
.bss 165200 165200 0 0.0
.data 3296 3296 0 0.0
.data.rel.ro 74648 74776 128 0.2
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210635 210699 64 0.0
.text 2352882 2352002 -880 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360020 2359932 -88 -0.0
.bss 185020 185020 0 0.0
.data 5752 5752 0 0.0
.text 1322620 1322532 -88 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148795 1148735 -60 -0.0
bss 143048 143048 0 0.0
rodata 143292 143328 36 0.0
text 787612 787512 -100 -0.0
p6 all-clusters-app default (read/write) 2504592 2504488 -104 -0.0
.bss 118456 118456 0 0.0
.data 2632 2632 0 0.0
.text 1462856 1462752 -104 -0.0
light-app default (read/write) 2405752 2405648 -104 -0.0
.bss 111912 111912 0 0.0
.data 2488 2488 0 0.0
.text 1364016 1363912 -104 -0.0
lock-app default (read/write) 2369384 2369280 -104 -0.0
.bss 111656 111656 0 0.0
.data 2448 2448 0 0.0
.text 1327648 1327544 -104 -0.0
telink lighting-app tlsr9518adk80d (read/write) 792340 792068 -272 -0.0
bss 70264 70264 0 0.0
noinit 40416 40416 0 0.0
text 562250 561934 -316 -0.1

@woody-apple
Copy link
Contributor

/rebase

@Damian-Nordic @woody-apple
[thread] GenericNetworkCommissioningThreadDriver error handling fixes
1257e81 
1. Return NetworkIdNotFound instead of NetworkNotFound when
   trying to reference an unknown network.
2. Validate ReorderNetwork index.
3. Validate input dataset Init() result.
@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

PR #17006: Size comparison from 4e67392 to 1257e81

Increases (7 builds for cc13x2_26x2, efr32, telink)
platform target config section 4e67392 1257e81 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 181200 181208 8 0.0
pump-app LP_CC2652R7 (read/write) 162896 162904 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 180408 180416 8 0.0
efr32 lighting-app BRD4161A (read only) 919164 919244 80 0.0
.text 919156 919236 80 0.0
BRD4161A+rpc (read only) 947060 947124 64 0.0
.text 947052 947116 64 0.0
window-app BRD4161A (read only) 854380 854444 64 0.0
.text 854372 854436 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 794808 794816 8 0.0
text 564354 564364 10 0.0
Decreases (5 builds for cc13x2_26x2, k32w)
platform target config section 4e67392 1257e81 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670511 670503 -8 -0.0
.text 590056 590048 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 619639 619631 -8 -0.0
.text 539288 539280 -8 -0.0
pump-app LP_CC2652R7 (read only) 689983 689975 -8 -0.0
.text 607436 607428 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 672207 672199 -8 -0.0
.text 593324 593316 -8 -0.0
k32w light k32w061+release (read/write) 710388 710372 -16 -0.0
.text 624732 624716 -16 -0.0
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4e67392 1257e81 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670511 670503 -8 -0.0
(read/write) 181200 181208 8 0.0
.bss 81752 81752 0 0.0
.data 3164 3164 0 0.0
.rodata 79975 79975 0 0.0
.text 590056 590048 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 619639 619631 -8 -0.0
(read/write) 154500 154500 0 0.0
.bss 77480 77480 0 0.0
.data 3164 3164 0 0.0
.rodata 79863 79863 0 0.0
.text 539288 539280 -8 -0.0
pump-app LP_CC2652R7 (read only) 689983 689975 -8 -0.0
(read/write) 162896 162904 8 0.0
.bss 82152 82152 0 0.0
.data 3196 3196 0 0.0
.rodata 82063 82063 0 0.0
.text 607436 607428 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 672207 672199 -8 -0.0
(read/write) 180408 180416 8 0.0
.bss 81888 81888 0 0.0
.data 3160 3160 0 0.0
.rodata 78399 78399 0 0.0
.text 593324 593316 -8 -0.0
efr32 lighting-app BRD4161A (read only) 919164 919244 80 0.0
(read/write) 129784 129784 0 0.0
.bss 127792 127792 0 0.0
.data 1992 1992 0 0.0
.text 919156 919236 80 0.0
BRD4161A+rpc (read only) 947060 947124 64 0.0
(read/write) 145732 145732 0 0.0
.bss 143560 143560 0 0.0
.data 2172 2172 0 0.0
.text 947052 947116 64 0.0
window-app BRD4161A (read only) 854380 854444 64 0.0
(read/write) 127808 127808 0 0.0
.bss 125936 125936 0 0.0
.data 1872 1872 0 0.0
.text 854372 854436 64 0.0
esp32 all-clusters-app c3devkit (read only) 988094 988094 0 0.0
(read/write) 1460842 1460842 0 0.0
.dram0.bss 62944 62944 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198224 198224 0 0.0
.flash.text 988094 988094 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1040455 1040455 0 0.0
(read/write) 461840 461840 0 0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 227168 227168 0 0.0
.flash.text 1035071 1035071 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 710388 710372 -16 -0.0
.bss 77952 77952 0 0.0
.data 1904 1904 0 0.0
.text 624732 624716 -16 -0.0
lock k32w061+release (read/write) 709784 709784 0 0.0
.bss 77952 77952 0 0.0
.data 1944 1944 0 0.0
.text 624088 624088 0 0.0
linux all-clusters-app debug (read only) 2593041 2593041 0 0.0
(read/write) 144776 144776 0 0.0
.bss 57632 57632 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79816 79816 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 221221 221221 0 0.0
.text 2203922 2203922 0 0.0
bridge-app debug+rpc (read only) 1803037 1803037 0 0.0
(read/write) 90232 90232 0 0.0
.bss 44552 44552 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38552 38552 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147481 147481 0 0.0
.text 1539045 1539045 0 0.0
chip-tool debug (read only) 10484645 10484645 0 0.0
(read/write) 367128 367128 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 337848 337848 0 0.0
.dynamic 624 624 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 534349 534349 0 0.0
.text 9131957 9131957 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10083572 10083572 0 0.0
(read/write) 486977 486977 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 384712 384712 0 0.0
.dynamic 560 560 0 0.0
.got 57008 57008 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 508404 508404 0 0.0
.text 8484324 8484324 0 0.0
door-lock-app debug (read only) 2074009 2074009 0 0.0
(read/write) 118224 118224 0 0.0
.bss 47872 47872 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 63640 63640 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185481 185481 0 0.0
.text 1734834 1734834 0 0.0
lighting-app debug+rpc (read only) 2252545 2252545 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49184 49184 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179593 179593 0 0.0
.text 1909794 1909794 0 0.0
ota-provider-app debug (read only) 2011929 2011929 0 0.0
(read/write) 113792 113792 0 0.0
.bss 47712 47712 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 58968 58968 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 171371 171371 0 0.0
.text 1685954 1685954 0 0.0
ota-requestor-app debug (read only) 2041313 2041313 0 0.0
(read/write) 117080 117080 0 0.0
.bss 48704 48704 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61176 61176 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167860 167860 0 0.0
.text 1717170 1717170 0 0.0
shell debug (read only) 2490097 2490097 0 0.0
(read/write) 148240 148240 0 0.0
.bss 67304 67304 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74360 74360 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212946 212946 0 0.0
.text 2118738 2118738 0 0.0
thermostat-no-ble arm64 (read only) 2324428 2324428 0 0.0
(read/write) 149441 149441 0 0.0
.bss 62945 62945 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 560 560 0 0.0
.got 4632 4632 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143308 143308 0 0.0
.text 1955408 1955408 0 0.0
tv-app debug (read only) 2761617 2761617 0 0.0
(read/write) 249888 249888 0 0.0
.bss 165328 165328 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 74976 74976 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 211435 211435 0 0.0
.text 2371474 2371474 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2362700 2362700 0 0.0
.bss 185036 185036 0 0.0
.data 5784 5784 0 0.0
.text 1325300 1325300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151231 1151231 0 0.0
bss 143060 143060 0 0.0
rodata 143592 143592 0 0.0
text 789708 789708 0 0.0
p6 all-clusters-app default (read/write) 2507528 2507528 0 0.0
.bss 118472 118472 0 0.0
.data 2672 2672 0 0.0
.text 1465792 1465792 0 0.0
light-app default (read/write) 2408704 2408704 0 0.0
.bss 111928 111928 0 0.0
.data 2528 2528 0 0.0
.text 1366968 1366968 0 0.0
lock-app default (read/write) 2372352 2372352 0 0.0
.bss 111672 111672 0 0.0
.data 2488 2488 0 0.0
.text 1330616 1330616 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794808 794816 8 0.0
bss 70288 70288 0 0.0
noinit 40416 40416 0 0.0
text 564354 564364 10 0.0

@Damian-Nordic Damian-Nordic merged commit e92157a into project-chip:master Apr 5, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@Damian-Nordic @chencheung
[thread] GenericNetworkCommissioningThreadDriver error handling fixes (…
0dddb32 
…project-chip#17006)

1. Return NetworkIdNotFound instead of NetworkNotFound when
   trying to reference an unknown network.
2. Validate ReorderNetwork index.
3. Validate input dataset Init() result.
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@Damian-Nordic @chencheung
[thread] GenericNetworkCommissioningThreadDriver error handling fixes (…
63da041 
…project-chip#17006)

1. Return NetworkIdNotFound instead of NetworkNotFound when
   trying to reference an unknown network.
2. Validate ReorderNetwork index.
3. Validate input dataset Init() result.
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@Damian-Nordic @andrei-menzopol
[thread] GenericNetworkCommissioningThreadDriver error handling fixes (…
e9ddd2b 
…project-chip#17006)

1. Return NetworkIdNotFound instead of NetworkNotFound when
   trying to reference an unknown network.
2. Validate ReorderNetwork index.
3. Validate input dataset Init() result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
openthread platform review - approved
Projects
None yet
Milestone
No milestone
5 participants
@Damian-Nordic @woody-apple @tcarmelveilleux @saurabhst @bzbarsky-apple