Add SupportsConcurrentConnection flag to SDK
#16899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- General Commissioning cluster recently had the `SupportsConcurrentConnection` attribute added to indicate which mode is going to be supported by the device. This attribute was missing. - Several elements of the GeneralCommissioningCluster were using stale names or older optionality. Fixes project-chip#16898 - This PR adds support for `SupportsConcurrentConnection` attribute - This PR renames `location` to `newRegulatoryConfig` attribute to match spec - Updated all ZAP files to have the mandatory attribute Testing done: - All unit tests pass - All cert tests pass - Added necessary YAML test to prove-out reading the value
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google and
mrjerryjohns
tcarmelveilleux
changed the title
SupportsConcurrentConnection flag to SDK
|
PR #16899: Size comparison from e8c3452 to b2cde81 Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2, esp32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Mar 31, 2022
bzbarsky-apple
approved these changes
Apr 1, 2022
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
|
PR #16899: Size comparison from 193b85c to 0cd253e Increases above 0.2%:
Increases (16 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (9 builds for cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect)
Full report (20 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Apr 1, 2022
|
PR #16899: Size comparison from 1ded008 to 39971eb Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2, esp32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16899: Size comparison from a673eb7 to 963f3ba Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2, esp32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* Add SupportsConcurrentConnection attribute * Update ZAP files * Add SupportsConcurrentConnection` flag to SDK - General Commissioning cluster recently had the `SupportsConcurrentConnection` attribute added to indicate which mode is going to be supported by the device. This attribute was missing. - Several elements of the GeneralCommissioningCluster were using stale names or older optionality. Fixes project-chip#16898 - This PR adds support for `SupportsConcurrentConnection` attribute - This PR renames `location` to `newRegulatoryConfig` attribute to match spec - Updated all ZAP files to have the mandatory attribute Testing done: - All unit tests pass - All cert tests pass - Added necessary YAML test to prove-out reading the value * Regen zap * Restyled by clang-format * Restyled by prettier-yaml * external->External * Regenerated ZAP * Restyled by clang-format * regen zap again, for the Nth time * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* Add SupportsConcurrentConnection attribute * Update ZAP files * Add SupportsConcurrentConnection` flag to SDK - General Commissioning cluster recently had the `SupportsConcurrentConnection` attribute added to indicate which mode is going to be supported by the device. This attribute was missing. - Several elements of the GeneralCommissioningCluster were using stale names or older optionality. Fixes project-chip#16898 - This PR adds support for `SupportsConcurrentConnection` attribute - This PR renames `location` to `newRegulatoryConfig` attribute to match spec - Updated all ZAP files to have the mandatory attribute Testing done: - All unit tests pass - All cert tests pass - Added necessary YAML test to prove-out reading the value * Regen zap * Restyled by clang-format * Restyled by prettier-yaml * external->External * Regenerated ZAP * Restyled by clang-format * regen zap again, for the Nth time * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Add SupportsConcurrentConnection attribute * Update ZAP files * Add SupportsConcurrentConnection` flag to SDK - General Commissioning cluster recently had the `SupportsConcurrentConnection` attribute added to indicate which mode is going to be supported by the device. This attribute was missing. - Several elements of the GeneralCommissioningCluster were using stale names or older optionality. Fixes project-chip#16898 - This PR adds support for `SupportsConcurrentConnection` attribute - This PR renames `location` to `newRegulatoryConfig` attribute to match spec - Updated all ZAP files to have the mandatory attribute Testing done: - All unit tests pass - All cert tests pass - Added necessary YAML test to prove-out reading the value * Regen zap * Restyled by clang-format * Restyled by prettier-yaml * external->External * Regenerated ZAP * Restyled by clang-format * regen zap again, for the Nth time * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SupportsConcurrentConnectionattribute added to indicate which mode is going to be supported by the device.
This attribute was missing.
or older optionality.
Fixes #16898
Change overview
SupportsConcurrentConnectionattributelocationtonewRegulatoryConfigattribute to match specTesting