-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nicer logging for InteractionModel::Status. #16855
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:better-status-logging
Mar 31, 2022
Merged
Add nicer logging for InteractionModel::Status. #16855
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:better-status-logging
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change we get things like: Error: IM Error 0x000005C6: General error: 0xc6 (NEEDS_TIMED_INTERACTION) instead of just Error: IM Error 0x000005C6: General error: 0xc6
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248 and
holbrookt
March 30, 2022 21:24
pullapprove
bot
requested review from
wbschiller,
tecimovic,
woody-apple,
turon,
xylophone21,
vijs,
yunhanw-google and
vivien-apple
March 30, 2022 21:24
PR #16855: Size comparison from bbbf7ce to 6ec9794 Increases above 0.2%:
Increases (11 builds for linux)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
yunhanw-google
approved these changes
Mar 30, 2022
tcarmelveilleux
approved these changes
Mar 30, 2022
msandstedt
approved these changes
Mar 31, 2022
msandstedt
approved these changes
Mar 31, 2022
PR #16855: Size comparison from bbbf7ce to d7eda28 Increases above 0.2%:
Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
* Add nicer logging for InteractionModel::Status. After this change we get things like: Error: IM Error 0x000005C6: General error: 0xc6 (NEEDS_TIMED_INTERACTION) instead of just Error: IM Error 0x000005C6: General error: 0xc6 * Address review comment
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Add nicer logging for InteractionModel::Status. After this change we get things like: Error: IM Error 0x000005C6: General error: 0xc6 (NEEDS_TIMED_INTERACTION) instead of just Error: IM Error 0x000005C6: General error: 0xc6 * Address review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change we get things like:
instead of just
Problem
Logging of status is a bit inscrutable, unless you remember the hex codes.
Change overview
Add a way to log something more informative, and a way to turn that off for smaller configs as needed.
Testing
Tried various things that return errors, with CHIP_CONFIG_IM_STATUS_CODE_VERBOSE_FORMAT set to both 1 and 0.