Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nicer logging for InteractionModel::Status. #16855

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Add nicer logging for InteractionModel::Status. #16855

merged 2 commits into from
Mar 31, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

After this change we get things like:

Error: IM Error 0x000005C6: General error: 0xc6 (NEEDS_TIMED_INTERACTION)

instead of just

Error: IM Error 0x000005C6: General error: 0xc6

Problem

Logging of status is a bit inscrutable, unless you remember the hex codes.

Change overview

Add a way to log something more informative, and a way to turn that off for smaller configs as needed.

Testing

Tried various things that return errors, with CHIP_CONFIG_IM_STATUS_CODE_VERBOSE_FORMAT set to both 1 and 0.

@bzbarsky-apple
Add nicer logging for InteractionModel::Status.
6ec9794 
After this change we get things like:

    Error: IM Error 0x000005C6: General error: 0xc6 (NEEDS_TIMED_INTERACTION)

instead of just

    Error: IM Error 0x000005C6: General error: 0xc6
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16855: Size comparison from bbbf7ce to 6ec9794

Increases above 0.2%:

platform target config section bbbf7ce 6ec9794 change % change
linux all-clusters-app debug .rodata 217061 218501 1440 0.7
bridge-app debug+rpc .rodata 145196 146636 1440 1.0
chip-tool debug .rodata 526805 528213 1408 0.3
chip-tool-no-interactive-ipv6only arm64 .rodata 501468 503132 1664 0.3
door-lock-app debug .rodata 181788 183228 1440 0.8
lighting-app debug+rpc .rodata 175772 177212 1440 0.8
ota-provider-app debug .rodata 167539 168947 1408 0.8
ota-requestor-app debug .rodata 163724 165132 1408 0.9
shell debug .rodata 210258 211698 1440 0.7
thermostat-no-ble arm64 .rodata 140172 141836 1664 1.2
tv-app debug .rodata 206603 208011 1408 0.7
Increases (11 builds for linux)
platform target config section bbbf7ce 6ec9794 change % change
linux all-clusters-app debug (read only) 2544809 2546841 2032 0.1
.rodata 217061 218501 1440 0.7
.text 2163730 2164322 592 0.0
bridge-app debug+rpc (read only) 1776957 1778989 2032 0.1
.rodata 145196 146636 1440 1.0
.text 1516213 1516805 592 0.0
chip-tool debug (read only) 10321909 10323925 2016 0.0
.rodata 526805 528213 1408 0.3
.text 9007717 9008325 608 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9930676 9933140 2464 0.0
.rodata 501468 503132 1664 0.3
.text 8371188 8371988 800 0.0
door-lock-app debug (read only) 2029585 2031617 2032 0.1
.rodata 181788 183228 1440 0.8
.text 1697794 1698386 592 0.0
lighting-app debug+rpc (read only) 2207313 2209345 2032 0.1
.rodata 175772 177212 1440 0.8
.text 1872178 1872770 592 0.0
ota-provider-app debug (read only) 1969681 1971697 2016 0.1
.rodata 167539 168947 1408 0.8
.text 1650082 1650690 608 0.0
ota-requestor-app debug (read only) 1997193 1999193 2000 0.1
.rodata 163724 165132 1408 0.9
.text 1680402 1680994 592 0.0
shell debug (read only) 2457929 2459977 2048 0.1
.rodata 210258 211698 1440 0.7
.text 2090530 2091138 608 0.0
thermostat-no-ble arm64 (read only) 2286796 2289276 2480 0.1
.rodata 140172 141836 1664 1.2
.text 1923040 1923856 816 0.0
tv-app debug (read only) 2705777 2707777 2000 0.1
.rodata 206603 208011 1408 0.7
.text 2324354 2324946 592 0.0
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bbbf7ce 6ec9794 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667303 667303 0 0.0
(read/write) 184432 184432 0 0.0
.bss 81776 81776 0 0.0
.data 3140 3140 0 0.0
.rodata 79575 79575 0 0.0
.text 587248 587248 0 0.0
lock-mtd LP_CC2652R7 (read only) 616439 616439 0 0.0
(read/write) 154500 154500 0 0.0
.bss 77504 77504 0 0.0
.data 3140 3140 0 0.0
.rodata 79455 79455 0 0.0
.text 536496 536496 0 0.0
pump-app LP_CC2652R7 (read only) 686115 686115 0 0.0
(read/write) 166772 166772 0 0.0
.bss 82160 82160 0 0.0
.data 3136 3136 0 0.0
.rodata 81579 81579 0 0.0
.text 604052 604052 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669019 669019 0 0.0
(read/write) 183620 183620 0 0.0
.bss 81912 81912 0 0.0
.data 3136 3136 0 0.0
.rodata 77987 77987 0 0.0
.text 590548 590548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 608654 608654 0 0.0
.app_xip_area 515404 515404 0 0.0
.bss 75988 75988 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 566186 566186 0 0.0
.app_xip_area 474472 474472 0 0.0
.bss 74492 74492 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578278 578278 0 0.0
.app_xip_area 476900 476900 0 0.0
.bss 83828 83828 0 0.0
.data 512 512 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 929636 929636 0 0.0
(read/write) 129120 129120 0 0.0
.bss 127120 127120 0 0.0
.data 2000 2000 0 0.0
.text 929628 929628 0 0.0
BRD4161A+rpc (read only) 958660 958660 0 0.0
(read/write) 145084 145084 0 0.0
.bss 142904 142904 0 0.0
.data 2180 2180 0 0.0
.text 958652 958652 0 0.0
window-app BRD4161A (read only) 859136 859136 0 0.0
(read/write) 127088 127088 0 0.0
.bss 125208 125208 0 0.0
.data 1876 1876 0 0.0
.text 859128 859128 0 0.0
esp32 all-clusters-app c3devkit (read only) 969534 969534 0 0.0
(read/write) 1394882 1394882 0 0.0
.dram0.bss 62424 62424 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 199304 199304 0 0.0
.flash.text 969534 969534 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1025179 1025179 0 0.0
(read/write) 462636 462636 0 0.0
.dram0.bss 67952 67952 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 228816 228816 0 0.0
.flash.text 1019795 1019795 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 707104 707104 0 0.0
.bss 77984 77984 0 0.0
.data 1880 1880 0 0.0
.text 621440 621440 0 0.0
lock k32w061+release (read/write) 706196 706196 0 0.0
.bss 77952 77952 0 0.0
.data 1920 1920 0 0.0
.text 620524 620524 0 0.0
linux all-clusters-app debug (read only) 2544809 2546841 2032 0.1
(read/write) 143448 143448 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 79032 79032 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 217061 218501 1440 0.7
.text 2163730 2164322 592 0.0
bridge-app debug+rpc (read only) 1776957 1778989 2032 0.1
(read/write) 89616 89616 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145196 146636 1440 1.0
.text 1516213 1516805 592 0.0
chip-tool debug (read only) 10321909 10323925 2016 0.0
(read/write) 356784 356784 0 0.0
.bss 22528 22528 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 327000 327000 0 0.0
.dynamic 624 624 0 0.0
.got 4872 4872 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 526805 528213 1408 0.3
.text 9007717 9008325 608 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9930676 9933140 2464 0.0
(read/write) 475681 475681 0 0.0
.bss 40785 40785 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 373712 373712 0 0.0
.dynamic 560 560 0 0.0
.got 56232 56232 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 501468 503132 1664 0.3
.text 8371188 8371988 800 0.0
door-lock-app debug (read only) 2029585 2031617 2032 0.1
(read/write) 117056 117056 0 0.0
.bss 47648 47648 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 62984 62984 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181788 183228 1440 0.8
.text 1697794 1698386 592 0.0
lighting-app debug+rpc (read only) 2207313 2209345 2032 0.1
(read/write) 124048 124048 0 0.0
.bss 48928 48928 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 68056 68056 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175772 177212 1440 0.8
.text 1872178 1872770 592 0.0
ota-provider-app debug (read only) 1969681 1971697 2016 0.1
(read/write) 112816 112816 0 0.0
.bss 47584 47584 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58280 58280 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167539 168947 1408 0.8
.text 1650082 1650690 608 0.0
ota-requestor-app debug (read only) 1997193 1999193 2000 0.1
(read/write) 116040 116040 0 0.0
.bss 48512 48512 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 60536 60536 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163724 165132 1408 0.9
.text 1680402 1680994 592 0.0
shell debug (read only) 2457929 2459977 2048 0.1
(read/write) 147464 147464 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73664 73664 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210258 211698 1440 0.7
.text 2090530 2091138 608 0.0
thermostat-no-ble arm64 (read only) 2286796 2289276 2480 0.1
(read/write) 148465 148465 0 0.0
.bss 62833 62833 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 77040 77040 0 0.0
.dynamic 560 560 0 0.0
.got 4528 4528 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140172 141836 1664 1.2
.text 1923040 1923856 816 0.0
tv-app debug (read only) 2705777 2707777 2000 0.1
(read/write) 247648 247648 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206603 208011 1408 0.7
.text 2324354 2324946 592 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358348 2358348 0 0.0
.bss 185036 185036 0 0.0
.data 5768 5768 0 0.0
.text 1320948 1320948 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1146471 1146471 0 0.0
bss 143068 143068 0 0.0
rodata 142640 142640 0 0.0
text 785932 785932 0 0.0
p6 all-clusters-app default (read/write) 2501464 2501464 0 0.0
.bss 118456 118456 0 0.0
.data 2648 2648 0 0.0
.text 1459728 1459728 0 0.0
light-app default (read/write) 2403624 2403624 0 0.0
.bss 111928 111928 0 0.0
.data 2504 2504 0 0.0
.text 1361888 1361888 0 0.0
lock-app default (read/write) 2367232 2367232 0 0.0
.bss 111672 111672 0 0.0
.data 2464 2464 0 0.0
.text 1325496 1325496 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 790928 790928 0 0.0
bss 70280 70280 0 0.0
noinit 40416 40416 0 0.0
text 560950 560950 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 31, 2022 •
edited
Loading

PR #16855: Size comparison from bbbf7ce to d7eda28

Increases above 0.2%:

platform target config section bbbf7ce d7eda28 change % change
linux all-clusters-app debug .rodata 217061 218757 1696 0.8
bridge-app debug+rpc (read only) 1776957 1781869 4912 0.3
.rodata 145196 146865 1669 1.1
.text 1516213 1519477 3264 0.2
chip-tool debug .got 4872 4896 24 0.5
.init_array 648 656 8 1.2
.rodata 526805 529677 2872 0.5
chip-tool-no-interactive-ipv6only arm64 .rodata 501468 503580 2112 0.4
door-lock-app debug (read only) 2029585 2034561 4976 0.2
.rodata 181788 183425 1637 0.9
lighting-app debug+rpc (read only) 2207313 2212353 5040 0.2
.rodata 175772 177473 1701 1.0
ota-provider-app debug (read only) 1969681 1974377 4696 0.2
.rodata 167539 169091 1552 0.9
ota-requestor-app debug (read only) 1997193 2002217 5024 0.3
.rodata 163724 165412 1688 1.0
shell debug (read only) 2457929 2465145 7216 0.3
.rodata 210258 211922 1664 0.8
.text 2090530 2096034 5504 0.3
thermostat-no-ble arm64 .rodata 140172 141892 1720 1.2
tv-app debug (read only) 2705777 2713401 7624 0.3
.rodata 206603 208587 1984 1.0
.text 2324354 2330018 5664 0.2
Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bbbf7ce d7eda28 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667303 667787 484 0.1
.bss 81776 81784 8 0.0
.rodata 79575 79627 52 0.1
.text 587248 587680 432 0.1
lock-mtd LP_CC2652R7 (read only) 616439 616923 484 0.1
.bss 77504 77512 8 0.0
.rodata 79455 79507 52 0.1
.text 536496 536928 432 0.1
pump-app LP_CC2652R7 (read only) 686115 686607 492 0.1
.bss 82160 82168 8 0.0
.rodata 81579 81631 52 0.1
.text 604052 604492 440 0.1
pump-controller-app LP_CC2652R7 (read only) 669019 669503 484 0.1
.bss 81912 81920 8 0.0
.rodata 77987 78039 52 0.1
.text 590548 590980 432 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 608654 609826 1172 0.2
.app_xip_area 515404 516576 1172 0.2
.bss 75988 75996 8 0.0
lock cyw930739m2evb_01 (read/write) 566186 567330 1144 0.2
.app_xip_area 474472 475616 1144 0.2
.bss 74492 74500 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578278 579270 992 0.2
.app_xip_area 476900 477892 992 0.2
.bss 83828 83836 8 0.0
efr32 lighting-app BRD4161A (read only) 929636 930548 912 0.1
.bss 127120 127128 8 0.0
.text 929628 930540 912 0.1
BRD4161A+rpc (read only) 958660 959540 880 0.1
.bss 142904 142912 8 0.0
.text 958652 959532 880 0.1
window-app BRD4161A (read only) 859136 860064 928 0.1
.bss 125208 125216 8 0.0
.text 859128 860056 928 0.1
esp32 all-clusters-app c3devkit (read only) 969534 970018 484 0.0
(read/write) 1394882 1394914 32 0.0
.dram0.bss 62424 62432 8 0.0
.flash.rodata 199304 199352 48 0.0
.flash.text 969534 970018 484 0.0
m5stack (read only) 1025179 1025759 580 0.1
(read/write) 462636 462684 48 0.0
.dram0.bss 67952 67960 8 0.0
.flash.rodata 228816 228864 48 0.0
.flash.text 1019795 1020375 580 0.1
k32w light k32w061+release (read/write) 707104 707572 468 0.1
.bss 77984 77992 8 0.0
.text 621440 621908 468 0.1
lock k32w061+release (read/write) 706196 706680 484 0.1
.bss 77952 77960 8 0.0
.text 620524 621008 484 0.1
linux all-clusters-app debug (read only) 2544809 2549841 5032 0.2
.rodata 217061 218757 1696 0.8
.text 2163730 2167090 3360 0.2
bridge-app debug+rpc (read only) 1776957 1781869 4912 0.3
(read/write) 89616 89632 16 0.0
.bss 44520 44536 16 0.0
.rodata 145196 146865 1669 1.1
.text 1516213 1519477 3264 0.2
chip-tool debug (read only) 10321909 1033108 9176 0.1
.data.rel.ro 327000 327072 72 0.0
.got 4872 4896 24 0.5
.init_array 648 656 8 1.2
.rodata 526805 529677 2872 0.5
.text 9007717 9013685 5968 0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9930676 9939636 8960 0.1
.data.rel.ro 373712 373848 136 0.0
.rodata 501468 503580 2112 0.4
.text 8371188 8377892 6704 0.1
door-lock-app debug (read only) 2029585 2034561 4976 0.2
.rodata 181788 183425 1637 0.9
.text 1697794 1701154 3360 0.2
lighting-app debug+rpc (read only) 2207313 2212353 5040 0.2
(read/write) 124048 124080 32 0.0
.bss 48928 48960 32 0.1
.rodata 175772 177473 1701 1.0
.text 1872178 1875538 3360 0.2
ota-provider-app debug (read only) 1969681 1974377 4696 0.2
.data.rel.ro 58280 58296 16 0.0
.rodata 167539 169091 1552 0.9
.text 1650082 1653250 3168 0.2
ota-requestor-app debug (read only) 1997193 2002217 5024 0.3
.data.rel.ro 60536 60552 16 0.0
.rodata 163724 165412 1688 1.0
.text 1680402 1683762 3360 0.2
shell debug (read only) 2457929 2465145 7216 0.3
(read/write) 147464 147496 32 0.0
.data.rel.ro 73664 73696 32 0.0
.rodata 210258 211922 1664 0.8
.text 2090530 2096034 5504 0.3
thermostat-no-ble arm64 (read only) 2286796 2291700 4904 0.2
.rodata 140172 141892 1720 1.2
.text 1923040 1926304 3264 0.2
tv-app debug (read only) 2705777 2713401 7624 0.3
(read/write) 247648 247968 320 0.1
.bss 164288 164608 320 0.2
.data.rel.ro 74168 74176 8 0.0
.rodata 206603 208587 1984 1.0
.text 2324354 2330018 5664 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2358348 2358604 256 0.0
.bss 185036 185044 8 0.0
.text 1320948 1321204 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1146471 1146903 432 0.0
bss 143068 143076 8 0.0
rodata 142640 142696 56 0.0
text 785932 786320 388 0.0
p6 all-clusters-app default (read/write) 2501464 2502488 1024 0.0
.bss 118456 118464 8 0.0
.text 1459728 1460752 1024 0.1
light-app default (read/write) 2403624 2404648 1024 0.0
.bss 111928 111936 8 0.0
.text 1361888 1362912 1024 0.1
lock-app default (read/write) 2367232 2368256 1024 0.0
.bss 111672 111680 8 0.0
.text 1325496 1326520 1024 0.1
telink lighting-app tlsr9518adk80d (read/write) 790928 791548 620 0.1
bss 70280 70288 8 0.0
text 560950 561516 566 0.1
Decreases (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6)
platform target config section bbbf7ce d7eda28 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 184432 183956 -476 -0.3
.data 3140 3132 -8 -0.3
lock-mtd LP_CC2652R7 .data 3140 3132 -8 -0.3
pump-app LP_CC2652R7 (read/write) 166772 166288 -484 -0.3
.data 3136 3128 -8 -0.3
pump-controller-app LP_CC2652R7 (read/write) 183620 183144 -476 -0.3
.data 3136 3128 -8 -0.3
cyw30739 light cyw930739m2evb_01 .data 608 600 -8 -1.3
lock cyw930739m2evb_01 .data 572 564 -8 -1.4
ota-requestor-no-progress-logging cyw930739m2evb_01 .data 512 504 -8 -1.6
efr32 lighting-app BRD4161A .data 2000 1992 -8 -0.4
BRD4161A+rpc .data 2180 2172 -8 -0.4
window-app BRD4161A .data 1876 1868 -8 -0.4
esp32 all-clusters-app c3devkit .dram0.data 14228 14220 -8 -0.1
m5stack .dram0.data 34032 34024 -8 -0.0
k32w light k32w061+release .data 1880 1872 -8 -0.4
lock k32w061+release .data 1920 1912 -8 -0.4
linux all-clusters-app debug .data 1280 1264 -16 -1.2
bridge-app debug+rpc .data 1984 1968 -16 -0.8
chip-tool debug (read/write) 356784 356408 -376 -0.1
.bss 22528 22048 -480 -2.1
chip-tool-no-interactive-ipv6only arm64 (read/write) 475681 475393 -288 -0.1
.bss 40785 40385 -400 -1.0
.data 1144 1128 -16 -1.4
door-lock-app debug .data 1024 1008 -16 -1.6
lighting-app debug+rpc .data 1504 1488 -16 -1.1
ota-requestor-app debug (read/write) 116040 116008 -32 -0.0
.data 1512 1480 -32 -2.1
shell debug .data 800 784 -16 -2.0
thermostat-no-ble arm64 (read/write) 148465 148433 -32 -0.0
.data 1048 1032 -16 -1.5
.got 4528 4512 -16 -0.4
mbed lock-app CY8CPROTO_062_4343W+release .data 5768 5760 -8 -0.1
p6 all-clusters-app default .data 2648 2640 -8 -0.3
light-app default .data 2504 2496 -8 -0.3
lock-app default .data 2464 2456 -8 -0.3
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bbbf7ce d7eda28 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667303 667787 484 0.1
(read/write) 184432 183956 -476 -0.3
.bss 81776 81784 8 0.0
.data 3140 3132 -8 -0.3
.rodata 79575 79627 52 0.1
.text 587248 587680 432 0.1
lock-mtd LP_CC2652R7 (read only) 616439 616923 484 0.1
(read/write) 154500 154500 0 0.0
.bss 77504 77512 8 0.0
.data 3140 3132 -8 -0.3
.rodata 79455 79507 52 0.1
.text 536496 536928 432 0.1
pump-app LP_CC2652R7 (read only) 686115 686607 492 0.1
(read/write) 166772 166288 -484 -0.3
.bss 82160 82168 8 0.0
.data 3136 3128 -8 -0.3
.rodata 81579 81631 52 0.1
.text 604052 604492 440 0.1
pump-controller-app LP_CC2652R7 (read only) 669019 669503 484 0.1
(read/write) 183620 183144 -476 -0.3
.bss 81912 81920 8 0.0
.data 3136 3128 -8 -0.3
.rodata 77987 78039 52 0.1
.text 590548 590980 432 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 608654 609826 1172 0.2
.app_xip_area 515404 516576 1172 0.2
.bss 75988 75996 8 0.0
.data 608 600 -8 -1.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 566186 567330 1144 0.2
.app_xip_area 474472 475616 1144 0.2
.bss 74492 74500 8 0.0
.data 572 564 -8 -1.4
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578278 579270 992 0.2
.app_xip_area 476900 477892 992 0.2
.bss 83828 83836 8 0.0
.data 512 504 -8 -1.6
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 929636 930548 912 0.1
(read/write) 129120 129120 0 0.0
.bss 127120 127128 8 0.0
.data 2000 1992 -8 -0.4
.text 929628 930540 912 0.1
BRD4161A+rpc (read only) 958660 959540 880 0.1
(read/write) 145084 145084 0 0.0
.bss 142904 142912 8 0.0
.data 2180 2172 -8 -0.4
.text 958652 959532 880 0.1
window-app BRD4161A (read only) 859136 860064 928 0.1
(read/write) 127088 127088 0 0.0
.bss 125208 125216 8 0.0
.data 1876 1868 -8 -0.4
.text 859128 860056 928 0.1
esp32 all-clusters-app c3devkit (read only) 969534 970018 484 0.0
(read/write) 1394882 1394914 32 0.0
.dram0.bss 62424 62432 8 0.0
.dram0.data 14228 14220 -8 -0.1
.flash.rodata 199304 199352 48 0.0
.flash.text 969534 970018 484 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1025179 1025759 580 0.1
(read/write) 462636 462684 48 0.0
.dram0.bss 67952 67960 8 0.0
.dram0.data 34032 34024 -8 -0.0
.flash.rodata 228816 228864 48 0.0
.flash.text 1019795 1020375 580 0.1
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 707104 707572 468 0.1
.bss 77984 77992 8 0.0
.data 1880 1872 -8 -0.4
.text 621440 621908 468 0.1
lock k32w061+release (read/write) 706196 706680 484 0.1
.bss 77952 77960 8 0.0
.data 1920 1912 -8 -0.4
.text 620524 621008 484 0.1
linux all-clusters-app debug (read only) 2544809 2549841 5032 0.2
(read/write) 143448 143448 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1264 -16 -1.2
.data.rel.ro 79032 79032 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 217061 218757 1696 0.8
.text 2163730 2167090 3360 0.2
bridge-app debug+rpc (read only) 1776957 1781869 4912 0.3
(read/write) 89616 89632 16 0.0
.bss 44520 44536 16 0.0
.data 1984 1968 -16 -0.8
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145196 146865 1669 1.1
.text 1516213 1519477 3264 0.2
chip-tool debug (read only) 10321909 1033108 9176 0.1
(read/write) 356784 356408 -376 -0.1
.bss 22528 22048 -480 -2.1
.data 1072 1072 0 0.0
.data.rel.ro 327000 327072 72 0.0
.dynamic 624 624 0 0.0
.got 4872 4896 24 0.5
.init 27 27 0 0.0
.init_array 648 656 8 1.2
.rodata 526805 529677 2872 0.5
.text 9007717 9013685 5968 0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9930676 9939636 8960 0.1
(read/write) 475681 475393 -288 -0.1
.bss 40785 40385 -400 -1.0
.data 1144 1128 -16 -1.4
.data.rel.ro 373712 373848 136 0.0
.dynamic 560 560 0 0.0
.got 56232 56232 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 501468 503580 2112 0.4
.text 8371188 8377892 6704 0.1
door-lock-app debug (read only) 2029585 2034561 4976 0.2
(read/write) 117056 117056 0 0.0
.bss 47648 47648 0 0.0
.data 1024 1008 -16 -1.6
.data.rel.ro 62984 62984 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181788 183425 1637 0.9
.text 1697794 1701154 3360 0.2
lighting-app debug+rpc (read only) 2207313 2212353 5040 0.2
(read/write) 124048 124080 32 0.0
.bss 48928 48960 32 0.1
.data 1504 1488 -16 -1.1
.data.rel.ro 68056 68056 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175772 177473 1701 1.0
.text 1872178 1875538 3360 0.2
ota-provider-app debug (read only) 1969681 1974377 4696 0.2
(read/write) 112816 112816 0 0.0
.bss 47584 47584 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58280 58296 16 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167539 169091 1552 0.9
.text 1650082 1653250 3168 0.2
ota-requestor-app debug (read only) 1997193 2002217 5024 0.3
(read/write) 116040 116008 -32 -0.0
.bss 48512 48512 0 0.0
.data 1512 1480 -32 -2.1
.data.rel.ro 60536 60552 16 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163724 165412 1688 1.0
.text 1680402 1683762 3360 0.2
shell debug (read only) 2457929 2465145 7216 0.3
(read/write) 147464 147496 32 0.0
.bss 67304 67304 0 0.0
.data 800 784 -16 -2.0
.data.rel.ro 73664 73696 32 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210258 211922 1664 0.8
.text 2090530 2096034 5504 0.3
thermostat-no-ble arm64 (read only) 2286796 2291700 4904 0.2
(read/write) 148465 148433 -32 -0.0
.bss 62833 62833 0 0.0
.data 1048 1032 -16 -1.5
.data.rel.ro 77040 77040 0 0.0
.dynamic 560 560 0 0.0
.got 4528 4512 -16 -0.4
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140172 141892 1720 1.2
.text 1923040 1926304 3264 0.2
tv-app debug (read only) 2705777 2713401 7624 0.3
(read/write) 247648 247968 320 0.1
.bss 164288 164608 320 0.2
.data 3136 3136 0 0.0
.data.rel.ro 74168 74176 8 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206603 208587 1984 1.0
.text 2324354 2330018 5664 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358348 2358604 256 0.0
.bss 185036 185044 8 0.0
.data 5768 5760 -8 -0.1
.text 1320948 1321204 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1146471 1146903 432 0.0
bss 143068 143076 8 0.0
rodata 142640 142696 56 0.0
text 785932 786320 388 0.0
p6 all-clusters-app default (read/write) 2501464 2502488 1024 0.0
.bss 118456 118464 8 0.0
.data 2648 2640 -8 -0.3
.text 1459728 1460752 1024 0.1
light-app default (read/write) 2403624 2404648 1024 0.0
.bss 111928 111936 8 0.0
.data 2504 2496 -8 -0.3
.text 1361888 1362912 1024 0.1
lock-app default (read/write) 2367232 2368256 1024 0.0
.bss 111672 111680 8 0.0
.data 2464 2456 -8 -0.3
.text 1325496 1326520 1024 0.1
telink lighting-app tlsr9518adk80d (read/write) 790928 791548 620 0.1
bss 70280 70288 8 0.0
noinit 40416 40416 0 0.0
text 560950 561516 566 0.1

@bzbarsky-apple bzbarsky-apple merged commit 7dce058 into project-chip:master Mar 31, 2022
@bzbarsky-apple bzbarsky-apple deleted the better-status-logging branch March 31, 2022 04:24
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@bzbarsky-apple @rochaferraz
Add nicer logging for InteractionModel::Status. (project-chip#16855)
0d1230e 
* Add nicer logging for InteractionModel::Status.

After this change we get things like:

    Error: IM Error 0x000005C6: General error: 0xc6 (NEEDS_TIMED_INTERACTION)

instead of just

    Error: IM Error 0x000005C6: General error: 0xc6

* Address review comment
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@bzbarsky-apple @andrei-menzopol
Add nicer logging for InteractionModel::Status. (project-chip#16855)
48bf399 
* Add nicer logging for InteractionModel::Status.

After this change we get things like:

    Error: IM Error 0x000005C6: General error: 0xc6 (NEEDS_TIMED_INTERACTION)

instead of just

    Error: IM Error 0x000005C6: General error: 0xc6

* Address review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin lib linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @tcarmelveilleux @msandstedt @yunhanw-google